From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [patch] i915: signedness bug in check_overlay_src()
Date: Wed, 27 Oct 2010 22:58:45 +0100
Message-ID: <b9dded$gtljue@orsmga002.jf.intel.com>
References: <20101027211724.GI6062@bicker>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
In-Reply-To: <20101027211724.GI6062@bicker>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Dan Carpenter <error27@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Wed, 27 Oct 2010 23:17:25 +0200, Dan Carpenter <error27@gmail.com> wrote:
> "depth" should be signed in case packed_depth_bytes() returns -EINVAL.
> 
> This probably doesn't make a difference at runtime.  In the original
> code we would return -EINVAL later if (rec->offset_Y % 4294967274) is
> non-zero.

Applied to fixes, thanks.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre