From: Antonio Quartulli References: <20200717134739.21168-1-arne@...1227...> <20200717134739.21168-4-arne@...1227...> <0b251f8c-9745-319b-db9e-58a661cd7e13@...2181...> Message-ID: Date: Tue, 21 Jul 2020 15:47:39 +0200 MIME-Version: 1.0 In-Reply-To: <0b251f8c-9745-319b-db9e-58a661cd7e13@...2181...> Content-Language: en-US Subject: Re: [Openvpn-devel] [PATCH v5 4/9] Implement tls-groups option to specify eliptic curves/groups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Arne Schwabe , openvpn-devel@lists.sourceforge.net On 21/07/2020 15:46, Antonio Quartulli wrote: > Aren't we calling strsep() twice in a row now? > Once in the while() condition and once at the end of the cycle? > > I think Arne agreed on the issue on IRC, but maybe forgot to fix the patch? > > However, please note that now the patch compiles on my gitlab-ci test bench. -- Antonio Quartulli