From: "cron2 (Code Review)" Date: Mon, 9 Sep 2024 06:56:26 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., selva.nair@...277..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="sasTYX9IygM="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Add test for static-challenge concatenation option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: selvanair , plaisthos , flichtenheld Cc: openvpn-devel --sasTYX9IygM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/666?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld, Code-Review+2 by plaisthos Change subject: Add test for static-challenge concatenation option ...................................................................... Add test for static-challenge concatenation option Change-Id: I41f6c1f7acb58f30fc4db0e32505018f64fcad28 Signed-off-by: Selva Nair Acked-by: Arne Schwabe Acked-by: Frank Lichtenheld Message-Id: <20240830141824.108599-1-selva.nair@...277...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29= 054.html Signed-off-by: Gert Doering --- M tests/unit_tests/openvpn/test_user_pass.c 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/66/666/2 diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/o= penvpn/test_user_pass.c index 4dc4b83..620542d 100644 --- a/tests/unit_tests/openvpn/test_user_pass.c +++ b/tests/unit_tests/openvpn/test_user_pass.c @@ -326,7 +326,25 @@ reset_user_pass(&up); - flags |=3D GET_USER_PASS_INLINE_CREDS; + flags |=3D GET_USER_PASS_STATIC_CHALLENGE_CONCAT; + + expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT= Username:"); + will_return(query_user_exec_builtin, "c1user"); + expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT= Password:"); + will_return(query_user_exec_builtin, "c1password"); + will_return(query_user_exec_builtin, true); + expect_string(query_user_exec_builtin, query_user[i].prompt, "CHALLENG= E: Please enter token PIN"); + will_return(query_user_exec_builtin, "0123456"); + will_return(query_user_exec_builtin, true); + assert_true(get_user_pass_cr(&up, NULL, "UT", flags, challenge)); + assert_true(up.defined); + assert_string_equal(up.username, "c1user"); + /* password and response concatenated */ + assert_string_equal(up.password, "c1password0123456"); + + reset_user_pass(&up); + + flags =3D GET_USER_PASS_STATIC_CHALLENGE|GET_USER_PASS_INLINE_CREDS; /*FIXME: query_user_exec() called even though nothing queued */ will_return(query_user_exec_builtin, true); -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/666?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I41f6c1f7acb58f30fc4db0e32505018f64fcad28 Gerrit-Change-Number: 666 Gerrit-PatchSet: 2 Gerrit-Owner: selvanair Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --sasTYX9IygM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #2 to the change originally cr= eated by selvanair.

View Change

The following approvals got outdated= and were removed: Code-Review+2 by flichtenheld, Code-Review+2 by plaisthos

Add test for stat=
ic-challenge concatenation option

Change-Id: I41f6c1f7acb58f30fc4db0= e32505018f64fcad28
Signed-off-by: Selva Nair <selva.nair@...277...>= ;
Acked-by: Arne Schwabe <arne-openvpn@...1227...>
Acked-by: Fr= ank Lichtenheld <frank@...2641...>
Message-Id: <20240830141824.= 108599-1-selva.nair@...277...>
URL: https://www.mail-archive.com/open= vpn-devel@lists.sourceforge.net/msg29054.html
Signed-off-by: Gert Doerin= g <gert@...1296...>
---
M tests/unit_tests/openvpn/test_user_pa= ss.c
1 file changed, 19 insertions(+), 1 deletion(-)

git pull =
ssh://gerrit.openvpn.net:29418/openvpn refs/changes/66/666/2
diff -=
-git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/openvpn=
/test_user_pass.c
index 4dc4b83..620542d 100644
<= span>--- a/tests/unit_tests/openvpn/test_user_pass.c
+++ b/= tests/unit_tests/openvpn/test_user_pass.c
@@ -326,7 +326,25= @@

reset_user_pass(&up);=

- flags = |=3D GET_USER_PASS_INLINE_CREDS;
+ flags |=3D GET_USER_PASS_STATIC_CHALLENGE_CONCAT;+
+ expect_string(query_user_exec_builtin, quer= y_user[i].prompt, "Enter UT Username:");
+ will_return(query_user_exec_builtin, &qu= ot;c1user");
+ = expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter = UT Password:");
= + will_return(query_user_exec_builtin, "c1password");+ will_return(query_user_e= xec_builtin, true);
+= expect_string(query_user_exec_builtin, query_user[i].prompt, "CHAL= LENGE: Please enter token PIN");
+ will_return(query_user_exec_builtin, "0123456&qu= ot;);
+ will_retur= n(query_user_exec_builtin, true);
+ assert_true(get_user_pass_cr(&up, NULL, "UT"= ;, flags, challenge));
+ assert_string_equal(up.username, "c1user");
+ /* password and respo= nse concatenated */
+= assert_string_equal(up.password, "c1password0123456");=
+
+ reset_user_pass(&up);
+

+ flags =3D GET_USER_PASS_STATIC_CHALLENGE|GET_USER_= PASS_INLINE_CREDS;

/*FIXME: query_us= er_exec() called even though nothing queued */
will_re= turn(query_user_exec_builtin, true);

To= view, visit change 666. To unsubscribe, or for help writing mail filters, visit= settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I41f6c1f7acb58f30fc4db0e3250= 5018f64fcad28
Gerrit-Change-Number: 666
Gerrit-PatchSet: 2
Gerrit-Owner: selvanair <selva.nair@...1354...= ..>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--sasTYX9IygM=--