From: "cron2 (Code Review)" Date: Mon, 9 Sep 2024 06:56:31 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., selva.nair@...277..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="/SF9F06rmwM="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Add test for static-challenge concatenation option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: selvanair Cc: flichtenheld , plaisthos , openvpn-devel --/SF9F06rmwM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/66= 6?usp=3Demail ) Change subject: Add test for static-challenge concatenation option ...................................................................... Add test for static-challenge concatenation option Change-Id: I41f6c1f7acb58f30fc4db0e32505018f64fcad28 Signed-off-by: Selva Nair Acked-by: Arne Schwabe Acked-by: Frank Lichtenheld Message-Id: <20240830141824.108599-1-selva.nair@...277...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29= 054.html Signed-off-by: Gert Doering --- M tests/unit_tests/openvpn/test_user_pass.c 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/o= penvpn/test_user_pass.c index 4dc4b83..620542d 100644 --- a/tests/unit_tests/openvpn/test_user_pass.c +++ b/tests/unit_tests/openvpn/test_user_pass.c @@ -326,7 +326,25 @@ reset_user_pass(&up); - flags |=3D GET_USER_PASS_INLINE_CREDS; + flags |=3D GET_USER_PASS_STATIC_CHALLENGE_CONCAT; + + expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT= Username:"); + will_return(query_user_exec_builtin, "c1user"); + expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT= Password:"); + will_return(query_user_exec_builtin, "c1password"); + will_return(query_user_exec_builtin, true); + expect_string(query_user_exec_builtin, query_user[i].prompt, "CHALLENG= E: Please enter token PIN"); + will_return(query_user_exec_builtin, "0123456"); + will_return(query_user_exec_builtin, true); + assert_true(get_user_pass_cr(&up, NULL, "UT", flags, challenge)); + assert_true(up.defined); + assert_string_equal(up.username, "c1user"); + /* password and response concatenated */ + assert_string_equal(up.password, "c1password0123456"); + + reset_user_pass(&up); + + flags =3D GET_USER_PASS_STATIC_CHALLENGE|GET_USER_PASS_INLINE_CREDS; /*FIXME: query_user_exec() called even though nothing queued */ will_return(query_user_exec_builtin, true); -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/666?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I41f6c1f7acb58f30fc4db0e32505018f64fcad28 Gerrit-Change-Number: 666 Gerrit-PatchSet: 2 Gerrit-Owner: selvanair Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: merged --/SF9F06rmwM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 submitted this change.

View Change

Add test for static-challenge concatenation op=
tion

Change-Id: I41f6c1f7acb58f30fc4db0e32505018f64fcad28
Signed-= off-by: Selva Nair <selva.nair@...277...>
Acked-by: Arne Schwabe &= lt;arne-openvpn@...1227...>
Acked-by: Frank Lichtenheld <frank@...493...= 2641...>
Message-Id: <20240830141824.108599-1-selva.nair@...277...= >
URL: https://www.mail-archive.com/openvpn-devel@...1223...= et/msg29054.html
Signed-off-by: Gert Doering <gert@...1296...>
= ---
M tests/unit_tests/openvpn/test_user_pass.c
1 file changed, 19 in= sertions(+), 1 deletion(-)

diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_test=
s/openvpn/test_user_pass.c
index 4dc4b83..620542d 100644
--- a/tests/unit_tests/openvpn/test_user_pass.c
+++ b/tests/unit_tests/openvpn/test_user_pass.c

@@ -326,= 7 +326,25 @@

reset_user_pass(&up= );

- = flags |=3D GET_USER_PASS_INLINE_CREDS;
+ flags |=3D GET_USER_PASS_STATIC_CHALLENGE_CONCAT;=
+
+ expect_string(query_user_exec_buil= tin, query_user[i].prompt, "Enter UT Username:");
+ will_return(query_user_exec_bui= ltin, "c1user");
+ expect_string(query_user_exec_builtin, query_user[i].prompt, &qu= ot;Enter UT Password:");
+ will_return(query_user_exec_builtin, "c1password");=
+ will_return(que= ry_user_exec_builtin, true);
+ expect_string(query_user_exec_builtin, query_user[i].prompt, &= quot;CHALLENGE: Please enter token PIN");
+ will_return(query_user_exec_builtin, "0= 123456");
+ w= ill_return(query_user_exec_builtin, true);
+ assert_true(get_user_pass_cr(&up, NULL, &quo= t;UT", flags, challenge));
+ assert_true(up.defined);
+ assert_string_equal(up.username, "c1user"= ;);
+ /* password = and response concatenated */
+ assert_string_equal(up.password, "c1password0123456"= );
+
+ reset_user_pass(&up);=
+
+ flags =3D GET_USER_PASS_STATIC_CHALLENGE|= GET_USER_PASS_INLINE_CREDS;

/*FIXME:= query_user_exec() called even though nothing queued */
= will_return(query_user_exec_builtin, true);

To view, visit change 666. To unsubscribe, or for help writing mail filte= rs, visit settings.

<= div itemscope itemtype=3D"http://schema.org/EmailMessage">
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I41f6c1f7acb58f30fc4db0e3250= 5018f64fcad28
Gerrit-Change-Number: 666
Gerrit-PatchSet: 2
Gerrit-Owner: selvanair <selva.nair@...1354...= ..>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: merged
--/SF9F06rmwM=--