From: "plaisthos (Code Review)"
Date: Tue, 2 Jan 2024 16:45:08 +0000
In-Reply-To:
References:
Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net,
frank@...2641..., gert@...1296...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="DbXDjfk+TjI="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Implement the
--tls-export-cert feature
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: cron2 , flichtenheld , openvpn-devel
--DbXDjfk+TjI=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/466?usp=3Demail )
Change subject: Implement the --tls-export-cert feature
......................................................................
Patch Set 7:
(4 comments)
Patchset:
PS6:
So we have to decide how to go about this. The current patch only So just e=
xporting and providing
File doc/man-sections/script-options.rst:
http://gerrit.openvpn.net/c/openvpn/+/466/comment/f8e03d25_01b36152 :
PS6, Line 426: --tls-export-cert-path dir
> the manpage calls the option "tls-export-cert-path", while options. [=E2=
=80=A6]
Ooops missed that one.
File src/openvpn/init.c:
http://gerrit.openvpn.net/c/openvpn/+/466/comment/e88dae53_952dc331 :
PS6, Line 3339: to.export_peer_cert_dir =3D options->tls_export_peer_ce=
rt_path;
> why call this "_dir" in the to, and "_path" in options-> ?
Fixed and now using always _dir
File src/openvpn/ssl_verify.c:
http://gerrit.openvpn.net/c/openvpn/+/466/comment/6cb0e20f_1acc6fec :
PS6, Line 734: if (opt->export_peer_cert_dir)
> So I tried to understand why it seemed to work in my testing. [=E2=80=A6]
This version of the patch now removes the environment variable together wit=
h the file. That is not as intrusive and should give at least backwards com=
patibility for now. The better solution is more complicated and requires mo=
dification to env handling (or even lot bigger refactoring) and is moved to=
follow up patches.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/466?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia9b3f1813d2d0d492d17c87348b4cebd0bf19ce2
Gerrit-Change-Number: 466
Gerrit-PatchSet: 7
Gerrit-Owner: plaisthos
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: cron2
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Tue, 02 Jan 2024 16:45:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--DbXDjfk+TjI=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld.
View C=
hange
4 comments:
Ooops missed that one.
File src/openvpn/init.c:=
Patch Set #6, Line=
3339: to.export_pe=
er_cert_dir =3D options->tls_export_peer_cert_path;
why call this "_dir" in the to, and "_path" in option=
s-> ?
Fixed and now using always _dir
File src/openvpn/ssl_verify.c:
Patch Set #6, Line 734: if (opt->export_peer_cert_dir)<=
/code>
So I tried to understand why it seemed to work in my =
testing. [=E2=80=A6]
This version of the patch now removes the environment =
variable together with the file. That is not as intrusive and should give a=
t least backwards compatibility for now. The better solution is more compli=
cated and requires modification to env handling (or even lot bigger refacto=
ring) and is moved to follow up patches.
To view,=
visit ch=
ange 466. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia9b3f1813d2d0d492d17c87348b=
4cebd0bf19ce2
Gerrit-Change-Number: 466
Gerrit-PatchSet: 7
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: cron2 <gert@...1296...>=
;
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Tue, 02 Jan 2024 16:45:08=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...=
>
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Gerrit-MessageType: comment
--DbXDjfk+TjI=--