Received: by 2002:a05:7022:ef0e:b0:81:d0c2:543b with SMTP id qy14csp3969090dlb; Thu, 4 Jul 2024 20:37:22 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUBR1XgE2XJFa8/r8qPmgDn4W194s+HP3fx2kx9YbK4Be69MfPyy0oBdPx6tWJgpo54aYPm/kGLe4/Z43qQBkTeduTq2Rwf X-Google-Smtp-Source: AGHT+IFBvrEdxDMjD+iwLd3fh81kqJbanLbIo1s8Y5xvbOWHdVdJA54RZDbUleNfAOTlX1HSfZsW X-Received: by 2002:a05:690c:827:b0:648:3fb2:753b with SMTP id 00721157ae682-652d6d9a2a6mr33092337b3.24.1720150642666; Thu, 04 Jul 2024 20:37:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720150642; cv=none; d=google.com; s=arc-20160816; b=e8YetPdUzlC4/UOBuvRHAFXj+NLjLqjVTBR/ce2721/Zd06Xqu1Zrm2YF0pNWJ9PP2 xeQE2g6Ub70HaQbYzALT3J7XlV61TaulThielT9BYgnIXVZqKws61jnIdacQWXFjJG3S 8nH6Qs9sCZakAieatwADc8nl/Q4Oa4fMw5T4AURSHUgFW4tCJ++LjAhyw0s5fkaju6Eq u069c0SAahtum5E5slCHF8Z5Ky/1UxCw+neX3bxI1jfRCjc1JJy4II6xAZP0bB2yE6tH 5ax78OcS4bIrlssBVct7jdFgPgMVMWfVoEZptfytZUUIHwtLShLylHR49hCJE24z987C 866A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=qrD3APwVTbEb6+UMXnlZvDWL8hR6derTmvhNktZVIG4=; fh=XYd3nlz1imZB8xXeQHM+01qZJ8iudtgMnw6k7asy4OQ=; b=vEhAOvgLmoFLbElov5AHZPfXJoAQqvfOmi7eQW3wd6G2koHwGvF+gyyhmYDXMBHuxJ SLEoejPz/EZkAT/3i8P2LFCqFDIHxxQK/DV4o43poMiT9dbEwOrSpnSR4Qzf4kLDyKBr fCE9tFLo9G5EOnLpSYPgJGXF3gqBuADE2ktQLSUw6UeN6WvFtAH5kMqeYARVc6BlUdG1 G1PL1Mbh8pxGzSXV5SIkeaV+UWgCmi3fzCYKGPzwrEQx99KuJUHattg5nkelazPnq204 uilAns2Fs2se+vB/O/2brMaAEx1Qy1CC37cISaY8rCb38Mq6Ud5M0w/T0rSJijyYe1p1 dxIg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeconstruct.com.au header.s=2022a header.b=hloTUKUj; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codeconstruct.com.au Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-79d78a29e99si1507545885a.748.2024.07.04.20.37.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Jul 2024 20:37:22 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@codeconstruct.com.au header.s=2022a header.b=hloTUKUj; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codeconstruct.com.au Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPZkn-0006i6-LB; Thu, 04 Jul 2024 23:36:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPZkm-0006hp-J9; Thu, 04 Jul 2024 23:36:56 -0400 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPZkk-0007qi-S8; Thu, 04 Jul 2024 23:36:56 -0400 Received: from [192.168.68.112] (ppp118-210-145-155.adl-adc-lon-bras33.tpg.internode.on.net [118.210.145.155]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 749522014E; Fri, 5 Jul 2024 11:36:50 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1720150611; bh=qrD3APwVTbEb6+UMXnlZvDWL8hR6derTmvhNktZVIG4=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=hloTUKUjB1hfce45LdMBEgN3FArVjPsw+wV9r4vJk5fYS1gNAJAEXNc4hkxVsl/QO cb0Dw/ETc9IjGN40nIh7LrDTFcNhShH8uFQpicSJSWlSJEtvfxiEF/LlqIUtePTcyU RKFllkwycrFbDAatPlmiMXb5uHPmx+OvSZ6Q4C0L5LrK8ahskKJz4iPd7NiFuUvcxR 5O4GL94ottZD63QFQhL5b+jT2QEaw2neF6OqjVgdQPuMj/zHUR7H912VdDRXq8a118 lJcImNOdiEVmW6JoVoJ5veB41XXFfEkpIU+RthtngBXP1sUaehm4zmaFgz7Jt4Ugd4 HoOOsJ6dAYtgQ== Message-ID: Subject: Re: [PATCH 3/8] aspeed/scu: Add boot-from-eMMC HW strapping bit for AST2600 SoC From: Andrew Jeffery To: =?ISO-8859-1?Q?C=E9dric?= Le Goater , qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Joel Stanley , Steven Lee , Troy Lee , Jamin Lin , Peter Maydell , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , =?ISO-8859-1?Q?C=E9dric?= Le Goater Date: Fri, 05 Jul 2024 13:06:49 +0930 In-Reply-To: <20240704053651.1100732-4-clg@redhat.com> References: <20240704053651.1100732-1-clg@redhat.com> <20240704053651.1100732-4-clg@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 Received-SPF: pass client-ip=203.29.241.158; envelope-from=andrew@codeconstruct.com.au; helo=codeconstruct.com.au X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: M+lN3Ub1tyfO On Thu, 2024-07-04 at 07:36 +0200, C=C3=A9dric Le Goater wrote: > From: C=C3=A9dric Le Goater >=20 > Bit SCU500[2] of the AST2600 controls the boot device of the SoC. >=20 > Future changes will configure this bit to boot from eMMC disk images > specially built for this purpose. >=20 > Signed-off-by: Joel Stanley > Signed-off-by: C=C3=A9dric Le Goater > --- > include/hw/misc/aspeed_scu.h | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/include/hw/misc/aspeed_scu.h b/include/hw/misc/aspeed_scu.h > index 58db28db45aa..c9f98c20ffd9 100644 > --- a/include/hw/misc/aspeed_scu.h > +++ b/include/hw/misc/aspeed_scu.h > @@ -349,6 +349,10 @@ uint32_t aspeed_scu_get_apb_freq(AspeedSCUState *s); > #define SCU_AST2600_H_PLL_BYPASS_EN (0x1 << 24) > #define SCU_AST2600_H_PLL_OFF (0x1 << 23) > =20 > +/* STRAP1 SCU500 */ > +#define AST2600_HW_STRAP_BOOT_SRC_EMMC (0x1 << 2) > +#define AST2600_HW_STRAP_BOOT_SRC_SPI (0x0 << 2) Maybe these should have a `SCU_` prefix for consistency? Anyway: Reviewed-by: Andrew Jeffery