Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D35E3C433DF for ; Thu, 21 May 2020 19:46:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93CD720814 for ; Thu, 21 May 2020 19:46:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pGKDgUi5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="eKV+Qnhq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93CD720814 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U+qs/xczw0HpSyIiWq00Kx2+vOpe+Rp1jFFGeKLe27A=; b=pGKDgUi5XkwFuqco46/+M7ZLq 8qOekwmTEdQ3iYlylsDjYiaV4kdEYx+HkTPJkUdu5mPo+S+aSWf4BEIUCd0obNAjYdw9VhB7+UWQq T5qPKeCr6ITHbV78S8Zfw2zm09RuhZtfflGuEY4KOKtXhBM65j0ghjr+jyQgaCT2Cs0dGD6cl1QQv mKBb8ec6LLFHu83nEejBDSqCTM0oAKLBZLMM6k0ITkzlaZLbH/b+mN2d+0LKglL8NYjGvFEY3QKsu MxNdq3p+lf1B6FngwTMZzvNUDmthZLMq9ZGbLwp3HepJOe9fa3s38NVHvIpl37h5LceNG6cYDCfNo qESBgm89Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbr9a-0005s3-99; Thu, 21 May 2020 19:46:54 +0000 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbr9X-0005ri-HU for linux-nvme@lists.infradead.org; Thu, 21 May 2020 19:46:53 +0000 Received: by mail-pj1-x1044.google.com with SMTP id nu7so3674880pjb.0 for ; Thu, 21 May 2020 12:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=72Z6I8JW4vuYp65kWpwR9Txg68W/7Ut08M8oiuIzIZU=; b=eKV+QnhqyJzUOjwVuPzMTSI7Mx+3KiA/ZEuPqaRG0MZR8fI7r9SCD7ZYIZepaYliMS OUQgujL7Lddx0F6s8YddNAFTYh/P/WbiMu47PX1YthswNGYUNZjCIa2tVfDh1kLHqOwv Jbdl8YFLz62xwHzMBiNCPGI+DtqCa5mBAcKJw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=72Z6I8JW4vuYp65kWpwR9Txg68W/7Ut08M8oiuIzIZU=; b=FdJj+FxdrDcVRfRiuAV9jKK79byVNBS7y57ersa+uXcFzIsR3hkkEWsLPlmQQlfKYt /V4PUy8uUCO07rC5Fe9YOqmpF3+jfTnusFQeHeWzHcegjg4qy6SOhH4NLAdXgQF1dg/u vIzhLFvjGEBxD3jnReJAFnlVI8QzPwI+rlPeXMAp48OpQBy8D3fEyH1Fvg2TXXuaXQvL bLo99X1iJMfc3Qb4PPXNat/6r+ImCvnuTYngby0rua1iuGRJYNBroatDflqhvBkPhH/a OQmKB8lT+D6qH+Vwyly2qgzrl8+S+cGdn8erLUKd9ajpnRRPN/0ESFJv1Cqe2K7ed7R/ utGw== X-Gm-Message-State: AOAM532fyURVH5DlC30GhRzdb3Own/eTcHOoNroWOI1/YSSKfwyithyi HPQH6d1e5QSawqjhZpC0F6as+Q== X-Google-Smtp-Source: ABdhPJw7C9/oVpQZoH01PVwj+/CCZpmK9yjlLKYwkxsuMAGy0wDwwrPjWX+F4NI4VMpmMQ/nvTGyLg== X-Received: by 2002:a17:902:7c98:: with SMTP id y24mr10924633pll.37.1590090409866; Thu, 21 May 2020 12:46:49 -0700 (PDT) Received: from [10.230.128.89] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id z5sm4740843pfj.29.2020.05.21.12.46.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2020 12:46:48 -0700 (PDT) Subject: Re: [PATCH] nvme: set dma alignment to qword To: Christoph Hellwig , Keith Busch References: <20200521022253.3268324-1-kbusch@kernel.org> <77425d7c-e8b8-b012-b1b3-c083b0b3af3c@grimberg.me> <20200521152820.GA3269657@dhcp-10-100-145-180.wdl.wdc.com> <20200521152929.GA18535@lst.de> <20200521154151.GB3269657@dhcp-10-100-145-180.wdl.wdc.com> <20200521154256.GB19160@lst.de> From: James Smart Message-ID: Date: Thu, 21 May 2020 12:46:45 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200521154256.GB19160@lst.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200521_124651_582130_C1FBB6DD X-CRM114-Status: GOOD ( 15.73 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , linux-nvme@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 5/21/2020 8:42 AM, Christoph Hellwig wrote: > On Thu, May 21, 2020 at 08:41:51AM -0700, Keith Busch wrote: >> On Thu, May 21, 2020 at 05:29:29PM +0200, Christoph Hellwig wrote: >>> On Thu, May 21, 2020 at 08:28:20AM -0700, Keith Busch wrote: >>>> On Wed, May 20, 2020 at 11:05:51PM -0700, Sagi Grimberg wrote: >>>>>> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c >>>>>> index 805d289e6cd9..ba860efd250d 100644 >>>>>> --- a/drivers/nvme/host/core.c >>>>>> +++ b/drivers/nvme/host/core.c >>>>>> @@ -2283,6 +2283,7 @@ static void nvme_set_queue_limits(struct nvme_ctrl *ctrl, >>>>>> blk_queue_max_segments(q, min_t(u32, max_segments, USHRT_MAX)); >>>>>> } >>>>>> blk_queue_virt_boundary(q, ctrl->page_size - 1); >>>>>> + blk_queue_dma_alignment(q, 7); >>>>> Shouldn't be an issue for rdma/tcp, think that it should also be OK for >>>>> FC as well but not sure. >>>> Okay, just to be safe, I'll make this a nvme_ctrl_ops callback. >>> No callbacks please, especially without users. If FC needs an override >>> we should just add a field to struct nvme_ctrl. >> Well, pci would be a user. But if you're okay with having the driver >> default to this alignment, would you consider taking this original patch, >> or do you want confirmation from FC developers on whether or not this >> is safe? > Lets wait for feedback from the FC folks. > > _______________________________________________ > linux-nvme mailing list > linux-nvme@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-nvme It won't bother the FC devices as they are typically byte-based for payload dma requirements. -- james _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme