Message-ID: Date: Fri, 25 Mar 2022 16:09:42 +0100 MIME-Version: 1.0 Content-Language: en-US References: <400a4652-39d6-ec8d-6f58-824f552e0440@...2666...> <9f710eb5-007c-cc8e-56b0-1b00c3f12c19@...1227...> <1315401d-b450-6db4-08f5-fed79f51a205@...2666...> <889af1a8-eee2-d869-00ef-29ada1db2bb6@...1227...> From: Antonio Quartulli In-Reply-To: <889af1a8-eee2-d869-00ef-29ada1db2bb6@...1227...> Subject: Re: [Openvpn-devel] [PATCH] Enablement of quantum-safe key establishment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Arne Schwabe , Michael Baentsch , openvpn-devel@lists.sourceforge.net On 25/03/2022 16:04, Arne Schwabe wrote: > Am 25.03.22 um 08:21 schrieb Michael Baentsch: >> Thanks very much for the quick and thorough feedback. Indeed your last >> question is pivotal making the patch _much_ simpler (attached): The >> problem manifests itself only in the presence of providers introduced >> in OpenSSL3.0. At the same time, the curve name causing the "dance >> code" is permitted as of OpenSSL3.0... >> >> So all other observations below are moot/should be resolved with the >> much simpler new patch attached. Feel free to delete/amend the comment >> changes as you see fit. > > Thanks v2 looks much better code wise and gets ack from me. To commit > the patch could you either send the patch in git format-message format > or provide a commit subject and text so we can make full commit of your > patch? We also need the patch to bear the sign-off-by line, so better create an actual git commit and export it via git-format-patch. Cheers, -- Antonio Quartulli