Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3119C7EE23 for ; Thu, 1 Jun 2023 02:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:From:References:Cc:To: Subject:Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wFal3KQ3m5CWaignHijFXTplTuSHTN6U6GENXllXukc=; b=XsAd2yHENgKH44J8sEU+V8a86R bql/KvX6DofaGajFyJkWkVon1Vm3APSjWS+RYVLu0q1bDrj+oxwBRdEx5dN/3+BZFAznDhM5afxDp 3sdI24hlQ9fiEzKIbGfDKei0f0tymcgV6p1i7I3CXMKHkslTvgGzpt4/fwBmKt8nbILVFrsDLVXDH kIPiBEAXNSl2DA/0SwDfyuzQzpH/J9Jf8+HqShpN68GHjGw162vXNSIaWQ2tJIwKE5I+6ITkzoNHC VXS97CRuzDoLuv4WPwf6pVyGbcZ+CR5HCkD70kipPWIRSwWq+1ghAZ5uWf+FGGAC83EbOL2VE/Ne6 VxxDrUng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4Y8R-001j6P-10; Thu, 01 Jun 2023 02:33:55 +0000 Received: from mail-bn8nam11on20601.outbound.protection.outlook.com ([2a01:111:f400:7eae::601] helo=NAM11-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4Y8P-001j5t-05 for linux-arm-kernel@lists.infradead.org; Thu, 01 Jun 2023 02:33:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CYQvsCQTijCXihNn72DxscmIixk7OmZI0IYnAjlPIXH5YHD/AKwMjYJoKIplrR/XFcC9DRmS0mki4fLNXI46zV4K5JeohAVHfS9Hqd6GE2lvYMijjBTWVw+awSDu/MxhMwPNCi9nACwJuUsQwTYoDBVAvkE19JaWKIzmq2If3SsIOkUJN3PdKvZGJmXKVCi+H4zOLCRjmIWCz0YocBCVUm59xHJ1O0z2OCLesaJjXmAPqY+ishVNxz2lIzdSRkXS6BHAjzPE0SGoCPLCwZopr9VaVUXU8GmZ7k1ek/40f0GF8XhJ2nhJPEp1IjoVNJd9RSGOrF+tB7bKlL8dPSZnTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2nUNdf0nr+13qz9JZg94dHFZZbur9ayIOeDwJVSTUzg=; b=b6pKPKLVXkN8ErbKThUCho2fQcx1cKqPIastYddR8quOLyrROU4r+9Ek5XmDGlIPCkauSXl1aCBU3iKRiOLjc8yXooCHPXvkFIQeZRW5pBJWxS+32MG+8kfBCoWwXN34ssYMblEJk4nJwQV394faIi98yZDfGmJByFhIFefgTFznaQSBDGO3jUpV5s4RyKp0roQjjeWAOZkYYHZ2op/YksrJ143tSTThK53j/njhNBM17OcDi9Yb7lkOyVvEBoNKHWsFaqUnRUHLIZwKwQF72L/CA5aNFdHbW6GorqBTekYPjlQfzytDWRjXvXzzD2tozl62iF1NRrb4uwvszRL0ZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2nUNdf0nr+13qz9JZg94dHFZZbur9ayIOeDwJVSTUzg=; b=R6rh55aRe97WDqWhlWAwEXkR70N3VqZfBkpTaBldjMZGRjTOnD9mx0sMGqi4NvSRi9HI19lah2r5F5Bf3aE3DtHN9jpRYWEgZ9lFiGnFd1f+7+1hwCaRUV3wmILrlBqFoWrCgqmBIXMSLT+y1GB6I9ws7fDvJ3tpYEbt4MHuxuL2GD0GQQ0eLCpFRlTl62zobbO0c51St5hjM0z6CGf+K9mG/WUVvefyLiZt2mh4nVR0kXC8Q77TsxZ+lCSd5vSenRrGPot1w2Gh3D0Hvqa6lfPa1Hk1sX9in5ncCCHEeyRtqDdXw7S7GEK3UBAI4s1PvOyMb8SvaavYiqjq9rLj/A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from MN0PR12MB5762.namprd12.prod.outlook.com (2603:10b6:208:375::12) by MN2PR12MB4125.namprd12.prod.outlook.com (2603:10b6:208:1d9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.22; Thu, 1 Jun 2023 02:33:41 +0000 Received: from MN0PR12MB5762.namprd12.prod.outlook.com ([fe80::152a:5550:dfe1:2c32]) by MN0PR12MB5762.namprd12.prod.outlook.com ([fe80::152a:5550:dfe1:2c32%6]) with mapi id 15.20.6455.020; Thu, 1 Jun 2023 02:33:41 +0000 Message-ID: Date: Wed, 31 May 2023 21:33:37 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFC] ACPI/irq: Apply ACPI_IRQCHIP_FWSPEC_ARG0 only for GSI domain Content-Language: en-US To: Marc Zyngier , James Morse Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org, Jason Sequeira References: <20230428165825.699910-1-sdonthineni@nvidia.com> From: Shanker Donthineni In-Reply-To: <20230428165825.699910-1-sdonthineni@nvidia.com> X-ClientProxiedBy: BY3PR05CA0046.namprd05.prod.outlook.com (2603:10b6:a03:39b::21) To MN0PR12MB5762.namprd12.prod.outlook.com (2603:10b6:208:375::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN0PR12MB5762:EE_|MN2PR12MB4125:EE_ X-MS-Office365-Filtering-Correlation-Id: 1be89dc1-d3fe-4771-173a-08db62489cc9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t82vSl16on2U/Dztafa2l0e91K9c+srPCHEX2UCDNRmBNeokZcj8qB5rc1z0ANIiA3qVR1E0iFrbkt8Uk6njUjQFfZ8d6PskNwR9vkLjVR0QvPZxc3rtVPUXXagEojVihXilwaf2taB6Y59bpR300YngIgRaKr8gkYmahL3XB1tCM0zfwcC2MHWQ99QGoJ7K5csnjinbusocttyBoHTRF/KWuYzt7YIXD6RZbb5f6p+JPGWTeglLJp0HDIa8zv6IuGkscYKxpwbtRftjL22Nw3yRZOtaZBuXPCGqLA1vO6S/qa1R3W/KdzyEBtZotoaYNgx9kb5WzZTwIQmXW4RQnpANrIrMINwrCm3cifckzoxY+1r/VU0DHQKAcNZNv3WxsB6wAtGCMEmtI4uvO0oheznrabpjvWegUst69DEwDi9d+Iv2mH763ZlKK86yBJ+sSzuqAEksUf8RCYWOjuC8o9zFs6q6v32q8Mh1GtaHvxyuL947YdOg7xepT761aoKgOW44qtthxnPKD8ns2bWLP7qIwkyluqvzIKYU3aiMHgK6XgpBLt6vhMqR81mvLgqHfTUAht7aVijiE7Xvt2Y5AaMbymqFHlBA7NY8abE9bBcHpM0DP0HdNBMMf8zzvOLHCuys/Jzk7W1QsHFsDwTBZQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR12MB5762.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(366004)(346002)(376002)(136003)(396003)(451199021)(4326008)(66946007)(66556008)(66476007)(8676002)(31686004)(316002)(41300700001)(2906002)(5660300002)(8936002)(110136005)(54906003)(6486002)(6666004)(478600001)(107886003)(36756003)(186003)(6506007)(83380400001)(6512007)(26005)(53546011)(2616005)(86362001)(31696002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVhqbzVrR2wxaXlKQThTbzNTTHgwcG1Pc1lEMTRnb01MV0F5MFl6UFBPR3JH?= =?utf-8?B?SE4ra2Z0dEQzaFFlcnliaTRUQ25jK1dwci8vVlQwUC9mcGh4WGM0VFpXbzdN?= =?utf-8?B?RkdEb3dlR0pud1JMbWFLSkFrNnVoL0Jma2R6di9FbkRLdmZaQlRPZlZMcnh1?= =?utf-8?B?N3Vzc2NJSEw5ZE1SWmxuN1VyRFVuZ2poQ1B6TkJ0cGN6ck8vTDFpL3ZESmNa?= =?utf-8?B?ZHB2c2lpMmFGOUdHTnR6VytFK0diSkhGb0hyY0N1bi9uaENpMzJuQlI4OVRY?= =?utf-8?B?VXUvTkc2QmJPdEpWSXdUbDJaYjd1bkJZd3REejgxWXAwVVN6cDJpak5yWVRt?= =?utf-8?B?Ykh5aWwzQm9DdUxkMSsyMXFMZXlJUnllak5sM0Y5TjBxVDZpRHJDd0V5UEkw?= =?utf-8?B?NTJMRVFTRFNWWkdzb21kTnVHSkNOV3JkYklUdVIrcWtYOVZlNHRIRlRodTVN?= =?utf-8?B?NWJGUzd0N1dNOEN6bXNpcm0vRUlYQ05lbE83M0Z0ZkdMM1BsRkpNd25mS00z?= =?utf-8?B?RVJ5TmpPdGNWTktVV3hIY0lRczRSOXZjKzNnUXp6T2ZNZkh1MnlwRGtoYjZI?= =?utf-8?B?b2Y0NHdGbTZYNU9Pd1E3SDNrbGttZlVQQmp5QThqTnNtbE9JODV1VStsSlFq?= =?utf-8?B?dEppWk1FSDJJckk2cDhqQWczU21KWDlTY3FQSkVacWZ3dDIxcWVYYllWeU16?= =?utf-8?B?TlNnczRYdHFSV01kclQ5UVNVaFhsemh2dVpaSExwNmk0cE91VE5PME1VZHo2?= =?utf-8?B?MDB1d1V1L0pYOVdncFV1c1pyOWIrYTd3WFRMcnRwQ2Q2VzJBTVI2VDBuSHkv?= =?utf-8?B?YkVaR05HRkpjR0owNUlIY0lsSC92bHZuUWE0YkFPWDBVS1hMYXJ3SlM0eEQx?= =?utf-8?B?T2VyakF0WDNmSTIvNGJWNUtBVFAzWXZacjhzLzlTVlNUZm9YM210dW5IcUhv?= =?utf-8?B?WFFVaStxbHpESUcxL2pZQlBuaURtS2tiQmpENEh2a05MaGQ5TktvYS9OcXE3?= =?utf-8?B?NXEvZG8wZHU2aFN3OFpsZnJZUzVtc2VPZURCUVdXOFJ6K3A4dkcybGlRKy91?= =?utf-8?B?eDUrSmQvMDUrSUNXYkZ3V1ZlSFc5cTVmQU10KzI4cURjZFlKWjhhVnZ4dUFL?= =?utf-8?B?aElKMGhvT2pMMm1hTkhsVnA0OWIwbHJKajBVOEdsVko3VlRyblZRZkgvQ01Y?= =?utf-8?B?Nzd6RUh5bzZIbFh0SkZCVjd1MjQwQXlJaVVlU3pCck5JSVI5eFk4RUZrWW1R?= =?utf-8?B?THN2OGdISDdGNmZuOVMvQ091UjY0cGxqZnp3eVlwaDBPV2lwS2h3bVVqeXpH?= =?utf-8?B?Y2lUZWwvY0NXTTJwaDUxamJuaTZDK2tIR2M2OGtsYjhHa2xnV2RSaUFYWWNk?= =?utf-8?B?Zzd5dXJ0eGFRaFZhZzJGT1BWL1VKbnNHd0krQzRkbGtTamNtczJJUzVvYlVD?= =?utf-8?B?YWJnV0tYWUdyRXU4MGhDaGU2TGs5ZC81Yng0R0loSXJkYkV2K3VRdkFZeTRz?= =?utf-8?B?NWVqc0NSU2JiTGU3NmM4c3NxU0l0VC9aSTh0MlB3YWxUbnVUS0dZQU4vWUxp?= =?utf-8?B?bG1NUzNUQkdjN2F5dmhMNWthZ01MT2xJck9hb0ZweHdGRW1yMXMwUW1hZnNS?= =?utf-8?B?cWdvUDliNnFGYlpSNlV1c1BWcURRa284bmxrNytVOGFydzMyR0lmQ2tNNzZ4?= =?utf-8?B?MnJRWjlHNU1POG5DTDNtbG0rblkxMjNuOFNwZVZyVVJvVG9JTkZzcnRsRGFa?= =?utf-8?B?MUYrSGV1ZGFiSEZneVZOZ2JiUE5jNnp6QkZUVXREQmJxMCs4c2NORFVGY1h0?= =?utf-8?B?RFp1THBQMzZZUTlOOGFhYXNEbHZFc1ZJdTFvNTF6b1pUMnlmamlVYThFcG1i?= =?utf-8?B?N0RTaFNPR2pBWktBaHhOWllDZmtYVHRpb2wzUVZEaGFRSk80aW4xaStHM3Y2?= =?utf-8?B?L09aTmhNKzd1eDFNRGZ3N2VwSCszV0VDQ1g2RkJqekU4bDh0Z0NhTitVTGZM?= =?utf-8?B?TDNKL3JlUkhnSFNyWnJqdlR0THRFRm9ldm5BdWdKS3Y0YmhDclFUYzhNTG1x?= =?utf-8?B?V1hJZEJOc0ZaTGU4eFdnazdwNjlSUnFnYUNoTThObnEzdWpXTzh5VXFaS2R5?= =?utf-8?Q?Y1+7leQvrHUNHsd5SRzs/k0mx?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1be89dc1-d3fe-4771-173a-08db62489cc9 X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 02:33:41.3497 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rYnyI19akH+FspT3qQaxwuRypzYenXdJuufybwWzZdMgbdt2I21GrOhUhk4uwKPhecOKn0Yt31pkqYAiqSqVMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4125 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230531_193353_149321_8CE0D033 X-CRM114-Status: GOOD ( 20.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi James When the IRQ combining feature is enabled, the following modification becomes necessary. Without implementing this change. The MPAM feature is not working on NVIDIA platforms. Please review the code and provide feedback. On 4/28/23 11:58, Shanker Donthineni wrote: > The implementation of the updated GICv3 parameter parsing code in > pack_fwspec() is not compatible for the non-GSI drivers. It uses > the offset 1 for hardware IRQ, but the unmodified GPIO driver > expects the offset value to be 0, leading to a regression. > > This patch applies new mapping to the GSI driver only to fix > the issue. > > Signed-off-by: Shanker Donthineni > --- > > drivers/acpi/irq.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/irq.c b/drivers/acpi/irq.c > index d4225d0b45d0..3d7f0643ed14 100644 > --- a/drivers/acpi/irq.c > +++ b/drivers/acpi/irq.c > @@ -53,7 +53,8 @@ static void pack_fwspec(struct irq_fwspec *fwspec, u32 gsi, int trigger, > { > unsigned int offset = 0; > > - if (IS_ENABLED(CONFIG_ACPI_IRQCHIP_FWSPEC_ARG0)) { > + if (IS_ENABLED(CONFIG_ACPI_IRQCHIP_FWSPEC_ARG0) && > + (fwspec->fwnode == acpi_get_gsi_domain_id(gsi))) { > fwspec->param[0] = ACPI_IRQCHIP_FWSPEC_ARG0; > offset = 1; > } > @@ -216,8 +217,8 @@ static inline void acpi_irq_parse_one_match(struct fwnode_handle *fwnode, > ctx->rc = 0; > *ctx->res_flags = acpi_dev_irq_flags(triggering, polarity, shareable, wake_capable); > > - pack_fwspec(ctx->fwspec, hwirq, triggering, polarity); > ctx->fwspec->fwnode = fwnode; > + pack_fwspec(ctx->fwspec, hwirq, triggering, polarity); > } > > /** _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel