From: Peter Ujfalusi Subject: Re: [PATCH RFC 1/3] drm/i2c: tda998x: implement different I2S flavours Date: Mon, 25 Feb 2019 15:28:51 +0200 Message-ID: References: <20190222212619.ghxly3eb6dx7p2ut@shell.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by gabe.freedesktop.org (Postfix) with ESMTPS id 552C689755 for ; Mon, 25 Feb 2019 13:28:31 +0000 (UTC) In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King , Sven Van Asbroeck , Mark Brown , Jyri Sarha Cc: David Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org aGkgUnVzc2VsbCwKCk9uIDIyLzAyLzIwMTkgMjMuMjcsIFJ1c3NlbGwgS2luZyB3cm90ZToKPiBB ZGQgc3VwcG9ydCBmb3IgdGhlIGxlZnQgYW5kIHJpZ2h0IGp1c3RpZmllZCBJMlMgZm9ybWF0cyBh cyB3ZWxsIGFzIHRoZQo+IG1vcmUgdHJhbmRpdGlvbmFsICJQaGlsaXBzIiBJMlMgZm9ybWF0LgoK Rmlyc3Qgb2YgYWxsLCB0aGFuayB5b3UgZm9yIHRoZSBwYXRjaCwgaXQgd29ya3MuCgpUZXN0ZWQt Ynk6IFBldGVyIFVqZmFsdXNpIDxwZXRlci51amZhbHVzaUB0aS5jb20+CgpUaGVyZSBpcyBob3dl dmVyIG9uZSB0aGluZyBJJ20gbm90IHN1cmUgYWJvdXQuCnRoZSAzLjgga2VybmVsIGNvbmZpZ3Vy ZWQgdGhlIHBhZ2UwOjB4ZmMgcmVnaXN0ZXIgWzFdOgovKiBzZWxlY3QgSTJTIGZvcm1hdCwgYW5k IGRhdGFzaXplICovCnJlZ193cml0ZShlbmNvZGVyLCBSRUdfSTJTX0ZPUk1BVCwgMHgwYSk7CgpJ biB0aGVvcnkgdGhpcyBzaG91bGQgc2VsZWN0IGxlZnRfaiBhbmQgc2V0IGJpdDMgd2hpY2ggZG9l cyBzb21ldGhpbmcuCkl0IGxvb2tzIGxpa2UgdGhhdCB0aGUgTWNBU1AgaXMgY29uZmlndXJlZCB0 byBJMlMgbW9kZSBpbiAzLjgga2VybmVsCndoaWNoIHdvdWxkIHJlc3VsdCBjaGFubmVsIHN3YXAg YXQgbGVhc3QgdGhlcmUgKEkyUyB2cyBsZWZ0X2opLgoKRG8geW91IGtub3cgd2hhdCB0aGUgYml0 MyBpcyBjb25maWd1cmluZyBhbmQgdG8gd2hhdD8KClsxXQpodHRwczovL2dpdGh1Yi5jb20vYmVh Z2xlYm9hcmQvbGludXgvYmxvYi8xZjJmMzQwMmE2ZTRiOGM5MDE0OGMwY2EyZmQzYWNiYTkxNzM4 ZWIzL2RyaXZlcnMvZ3B1L2RybS9pMmMvdGRhOTk4eF9kcnYuYyNMODUxCgoKPiAKPiBTaWduZWQt b2ZmLWJ5OiBSdXNzZWxsIEtpbmcgPHJtaytrZXJuZWxAYXJtbGludXgub3JnLnVrPgo+IC0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTJjL3RkYTk5OHhfZHJ2LmMgfCA1NyArKysrKysrKysrKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0KPiAgaW5jbHVkZS9kcm0vaTJjL3RkYTk5OHguaCAgICAg ICAgIHwgMTEgKysrKystLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCA0NyBpbnNlcnRpb25zKCspLCAy MSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2kyYy90ZGE5 OTh4X2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL2kyYy90ZGE5OTh4X2Rydi5jCj4gaW5kZXggYTdj MzlmMzk3OTNmLi42NDVkODg0ZmI5ZTggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2ky Yy90ZGE5OTh4X2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2kyYy90ZGE5OTh4X2Rydi5j Cj4gQEAgLTI0Miw3ICsyNDIsOSBAQCBzdHJ1Y3QgdGRhOTk4eF9wcml2IHsKPiAgIyBkZWZpbmUg SFZGX0NOVFJMXzFfU0VNSV9QTEFOQVIgICgxIDw8IDYpCj4gICNkZWZpbmUgUkVHX1JQVF9DTlRS TCAgICAgICAgICAgICBSRUcoMHgwMCwgMHhmMCkgICAgIC8qIHdyaXRlICovCj4gICNkZWZpbmUg UkVHX0kyU19GT1JNQVQgICAgICAgICAgICBSRUcoMHgwMCwgMHhmYykgICAgIC8qIHJlYWQvd3Jp dGUgKi8KPiAtIyBkZWZpbmUgSTJTX0ZPUk1BVCh4KSAgICAgICAgICAgICgoKHgpICYgMykgPDwg MCkKPiArIyBkZWZpbmUgSTJTX0ZPUk1BVF9QSElMSVBTICAgICAgICgwIDw8IDApCj4gKyMgZGVm aW5lIEkyU19GT1JNQVRfTEVGVF9KICAgICAgICAoMiA8PCAwKQo+ICsjIGRlZmluZSBJMlNfRk9S TUFUX1JJR0hUX0ogICAgICAgKDMgPDwgMCkKPiAgI2RlZmluZSBSRUdfQUlQX0NMS1NFTCAgICAg ICAgICAgIFJFRygweDAwLCAweGZkKSAgICAgLyogd3JpdGUgKi8KPiAgIyBkZWZpbmUgQUlQX0NM S1NFTF9BSVBfU1BESUYJICAoMCA8PCAzKQo+ICAjIGRlZmluZSBBSVBfQ0xLU0VMX0FJUF9JMlMJ ICAoMSA8PCAzKQo+IEBAIC04NzIsMTQgKzg3NCwxNCBAQCBzdGF0aWMgaW50Cj4gIHRkYTk5OHhf Y29uZmlndXJlX2F1ZGlvKHN0cnVjdCB0ZGE5OTh4X3ByaXYgKnByaXYsCj4gIAkJCXN0cnVjdCB0 ZGE5OTh4X2F1ZGlvX3BhcmFtcyAqcGFyYW1zKQo+ICB7Cj4gLQl1OCBidWZbNl0sIGNsa3NlbF9h aXAsIGNsa3NlbF9mcywgY3RzX24sIGFkaXY7Cj4gKwl1OCBidWZbNl0sIGNsa3NlbF9haXAsIGNs a3NlbF9mcywgY3RzX24sIGFkaXYsIGkyc19mbXQ7Cj4gIAl1MzIgbjsKPiAgCj4gIAkvKiBFbmFi bGUgYXVkaW8gcG9ydHMgKi8KPiAgCXJlZ193cml0ZShwcml2LCBSRUdfRU5BX0FQLCBwYXJhbXMt PmNvbmZpZyk7Cj4gIAo+ICAJLyogU2V0IGF1ZGlvIGlucHV0IHNvdXJjZSAqLwo+IC0Jc3dpdGNo IChwYXJhbXMtPmZvcm1hdCkgewo+ICsJc3dpdGNoIChwYXJhbXMtPmZvcm1hdCAmIEFGTVRfTUFT Sykgewo+ICAJY2FzZSBBRk1UX1NQRElGOgo+ICAJCXJlZ193cml0ZShwcml2LCBSRUdfRU5BX0FD TEssIDApOwo+ICAJCXJlZ193cml0ZShwcml2LCBSRUdfTVVYX0FQLCBNVVhfQVBfU0VMRUNUX1NQ RElGKTsKPiBAQCAtOTA3LDYgKzkwOSwxOSBAQCB0ZGE5OTh4X2NvbmZpZ3VyZV9hdWRpbyhzdHJ1 Y3QgdGRhOTk4eF9wcml2ICpwcml2LAo+ICAJCQljdHNfbiA9IENUU19OX00oMykgfCBDVFNfTl9L KDMpOwo+ICAJCQlicmVhazsKPiAgCQl9Cj4gKwo+ICsJCXN3aXRjaCAocGFyYW1zLT5mb3JtYXQg JiBBRk1UX0kyU19NQVNLKSB7Cj4gKwkJY2FzZSBBRk1UX0kyU19MRUZUX0o6Cj4gKwkJCWkyc19m bXQgPSBJMlNfRk9STUFUX0xFRlRfSjsKPiArCQkJYnJlYWs7Cj4gKwkJY2FzZSBBRk1UX0kyU19S SUdIVF9KOgo+ICsJCQlpMnNfZm10ID0gSTJTX0ZPUk1BVF9SSUdIVF9KOwo+ICsJCQlicmVhazsK PiArCQlkZWZhdWx0Ogo+ICsJCQlpMnNfZm10ID0gSTJTX0ZPUk1BVF9QSElMSVBTOwo+ICsJCQli cmVhazsKPiArCQl9Cj4gKwkJcmVnX3dyaXRlKHByaXYsIFJFR19JMlNfRk9STUFULCBpMnNfZm10 KTsKPiAgCQlicmVhazsKPiAgCj4gIAlkZWZhdWx0Ogo+IEBAIC05OTIsMjMgKzEwMDcsMTUgQEAg c3RhdGljIGludCB0ZGE5OTh4X2F1ZGlvX2h3X3BhcmFtcyhzdHJ1Y3QgZGV2aWNlICpkZXYsIHZv aWQgKmRhdGEsCj4gIAo+ICAJc3dpdGNoIChkYWlmbXQtPmZtdCkgewo+ICAJY2FzZSBIRE1JX0ky UzoKPiAtCQlpZiAoZGFpZm10LT5iaXRfY2xrX2ludiB8fCBkYWlmbXQtPmZyYW1lX2Nsa19pbnYg fHwKPiAtCQkgICAgZGFpZm10LT5iaXRfY2xrX21hc3RlciB8fCBkYWlmbXQtPmZyYW1lX2Nsa19t YXN0ZXIpIHsKPiAtCQkJZGV2X2VycihkZXYsICIlczogQmFkIGZsYWdzICVkICVkICVkICVkXG4i LCBfX2Z1bmNfXywKPiAtCQkJCWRhaWZtdC0+Yml0X2Nsa19pbnYsIGRhaWZtdC0+ZnJhbWVfY2xr X2ludiwKPiAtCQkJCWRhaWZtdC0+Yml0X2Nsa19tYXN0ZXIsCj4gLQkJCQlkYWlmbXQtPmZyYW1l X2Nsa19tYXN0ZXIpOwo+IC0JCQlyZXR1cm4gLUVJTlZBTDsKPiAtCQl9Cj4gLQkJZm9yIChpID0g MDsgaSA8IEFSUkFZX1NJWkUocHJpdi0+YXVkaW9fcG9ydCk7IGkrKykKPiAtCQkJaWYgKHByaXYt PmF1ZGlvX3BvcnRbaV0uZm9ybWF0ID09IEFGTVRfSTJTKQo+IC0JCQkJYXVkaW8uY29uZmlnID0g cHJpdi0+YXVkaW9fcG9ydFtpXS5jb25maWc7Cj4gLQkJYXVkaW8uZm9ybWF0ID0gQUZNVF9JMlM7 Cj4gKwkJYXVkaW8uZm9ybWF0ID0gQUZNVF9JMlMgfCBBRk1UX0kyU19QSElMSVBTOwo+ICsJCWJy ZWFrOwo+ICsJY2FzZSBIRE1JX0xFRlRfSjoKPiArCQlhdWRpby5mb3JtYXQgPSBBRk1UX0kyUyB8 IEFGTVRfSTJTX0xFRlRfSjsKPiArCQlicmVhazsKPiArCWNhc2UgSERNSV9SSUdIVF9KOgo+ICsJ CWF1ZGlvLmZvcm1hdCA9IEFGTVRfSTJTIHwgQUZNVF9JMlNfUklHSFRfSjsKPiAgCQlicmVhazsK PiAgCWNhc2UgSERNSV9TUERJRjoKPiAtCQlmb3IgKGkgPSAwOyBpIDwgQVJSQVlfU0laRShwcml2 LT5hdWRpb19wb3J0KTsgaSsrKQo+IC0JCQlpZiAocHJpdi0+YXVkaW9fcG9ydFtpXS5mb3JtYXQg PT0gQUZNVF9TUERJRikKPiAtCQkJCWF1ZGlvLmNvbmZpZyA9IHByaXYtPmF1ZGlvX3BvcnRbaV0u Y29uZmlnOwo+ICAJCWF1ZGlvLmZvcm1hdCA9IEFGTVRfU1BESUY7Cj4gIAkJYnJlYWs7Cj4gIAlk ZWZhdWx0Ogo+IEBAIC0xMDE2LDExICsxMDIzLDI1IEBAIHN0YXRpYyBpbnQgdGRhOTk4eF9hdWRp b19od19wYXJhbXMoc3RydWN0IGRldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ICAJCXJldHVybiAt RUlOVkFMOwo+ICAJfQo+ICAKPiArCWZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKHByaXYtPmF1 ZGlvX3BvcnQpOyBpKyspCj4gKwkJaWYgKHByaXYtPmF1ZGlvX3BvcnRbaV0uZm9ybWF0ID09IChh dWRpby5mb3JtYXQgJiBBRk1UX01BU0spKQo+ICsJCQlhdWRpby5jb25maWcgPSBwcml2LT5hdWRp b19wb3J0W2ldLmNvbmZpZzsKPiArCj4gIAlpZiAoYXVkaW8uY29uZmlnID09IDApIHsKPiAgCQlk ZXZfZXJyKGRldiwgIiVzOiBObyBhdWRpbyBjb25maWd1cmF0aW9uIGZvdW5kXG4iLCBfX2Z1bmNf Xyk7Cj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gIAl9Cj4gIAo+ICsJaWYgKChhdWRpby5mb3JtYXQg JiBBRk1UX01BU0spID09IEhETUlfSTJTICYmCj4gKwkgICAgKGRhaWZtdC0+Yml0X2Nsa19pbnYg fHwgZGFpZm10LT5mcmFtZV9jbGtfaW52IHx8Cj4gKwkgICAgIGRhaWZtdC0+Yml0X2Nsa19tYXN0 ZXIgfHwgZGFpZm10LT5mcmFtZV9jbGtfbWFzdGVyKSkgewo+ICsJCWRldl9lcnIoZGV2LCAiJXM6 IEJhZCBmbGFncyAlZCAlZCAlZCAlZFxuIiwgX19mdW5jX18sCj4gKwkJCWRhaWZtdC0+Yml0X2Ns a19pbnYsIGRhaWZtdC0+ZnJhbWVfY2xrX2ludiwKPiArCQkJZGFpZm10LT5iaXRfY2xrX21hc3Rl ciwKPiArCQkJZGFpZm10LT5mcmFtZV9jbGtfbWFzdGVyKTsKPiArCQlyZXR1cm4gLUVJTlZBTDsK PiArCX0KPiArCj4gIAltdXRleF9sb2NrKCZwcml2LT5hdWRpb19tdXRleCk7Cj4gIAlpZiAocHJp di0+c3VwcG9ydHNfaW5mb2ZyYW1lcyAmJiBwcml2LT5zaW5rX2hhc19hdWRpbykKPiAgCQlyZXQg PSB0ZGE5OTh4X2NvbmZpZ3VyZV9hdWRpbyhwcml2LCAmYXVkaW8pOwo+IGRpZmYgLS1naXQgYS9p bmNsdWRlL2RybS9pMmMvdGRhOTk4eC5oIGIvaW5jbHVkZS9kcm0vaTJjL3RkYTk5OHguaAo+IGlu ZGV4IDNjYjI1Y2NiZTVlNi4uYjA4NjRmMGJlMDE3IDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJt L2kyYy90ZGE5OTh4LmgKPiArKysgYi9pbmNsdWRlL2RybS9pMmMvdGRhOTk4eC5oCj4gQEAgLTYs OSArNiwxNCBAQAo+ICAjaW5jbHVkZSA8ZHQtYmluZGluZ3MvZGlzcGxheS90ZGE5OTh4Lmg+Cj4g IAo+ICBlbnVtIHsKPiAtCUFGTVRfVU5VU0VEID0JMCwKPiAtCUFGTVRfU1BESUYgPQlUREE5OTh4 X1NQRElGLAo+IC0JQUZNVF9JMlMgPQlUREE5OTh4X0kyUywKPiArCUFGTVRfVU5VU0VEICAgICAg PSAwLAo+ICsJQUZNVF9TUERJRiAgICAgICA9IFREQTk5OHhfU1BESUYsCj4gKwlBRk1UX0kyUyAg ICAgICAgID0gVERBOTk4eF9JMlMsCj4gKwlBRk1UX01BU0sgICAgICAgID0gQUZNVF9TUERJRiB8 IEFGTVRfSTJTLAo+ICsJQUZNVF9JMlNfUEhJTElQUyA9IDAgPDwgNCwKPiArCUFGTVRfSTJTX0xF RlRfSiAgPSAxIDw8IDQsCj4gKwlBRk1UX0kyU19SSUdIVF9KID0gMiA8PCA0LAo+ICsJQUZNVF9J MlNfTUFTSyAgICA9IDMgPDwgNCwKPiAgfTsKPiAgCj4gIHN0cnVjdCB0ZGE5OTh4X2F1ZGlvX3Bh cmFtcyB7Cj4gCgotIFDDqXRlcgoKVGV4YXMgSW5zdHJ1bWVudHMgRmlubGFuZCBPeSwgUG9ya2th bGFua2F0dSAyMiwgMDAxODAgSGVsc2lua2kuClktdHVubnVzL0J1c2luZXNzIElEOiAwNjE1NTIx LTQuIEtvdGlwYWlra2EvRG9taWNpbGU6IEhlbHNpbmtpCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==