From: Tvrtko Ursulin Subject: Re: [PATCH v2] drm/i915/query: Split out query item checks Date: Wed, 16 Jan 2019 09:23:26 +0000 Message-ID: References: <20190109075108.16779-1-abdiel.janulgue@linux.intel.com> <20190116085926.24420-1-abdiel.janulgue@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C5AB6EF6E for ; Wed, 16 Jan 2019 09:23:27 +0000 (UTC) In-Reply-To: <20190116085926.24420-1-abdiel.janulgue@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Abdiel Janulgue , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE2LzAxLzIwMTkgMDg6NTksIEFiZGllbCBKYW51bGd1ZSB3cm90ZToKPiBUaGlzIHNpbXBs aWZpZXMgYWRkaW5nIG5ldyBxdWVyeSBpdGVtIG9iamVjdHMuCj4gCj4gdjI6IFVzZSBxdWVyeV9o ZHIgKFR2cnRrbywgQ2hyaXMpLgo+ICAgICAgaW50IGluc3RlYWQgb2YgdTMyIGluIHJldHVybiAo VHZydGtvKQo+IAo+IFNpZ25lZC1vZmYtYnk6IEFiZGllbCBKYW51bGd1ZSA8YWJkaWVsLmphbnVs Z3VlQGxpbnV4LmludGVsLmNvbT4KPiBDYzogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGlu ZW5AbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9x dWVyeS5jIHwgMzkgKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNo YW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3F1ZXJ5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X3F1ZXJ5LmMKPiBpbmRleCBjYmNiOTU3YjcxNDEuLmIyNDQ5Y2ZmZGE1MSAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3F1ZXJ5LmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X3F1ZXJ5LmMKPiBAQCAtMTAsMTIgKzEwLDM0IEBACj4gICAjaW5j bHVkZSAiaTkxNV9xdWVyeS5oIgo+ICAgI2luY2x1ZGUgPHVhcGkvZHJtL2k5MTVfZHJtLmg+Cj4g ICAKPiArc3RhdGljIGludCBpbml0X3F1ZXJ5X2l0ZW1fY2hlY2sodm9pZCAqcXVlcnlfaGRyLCBz aXplX3QgZGF0YV9zeiwKCkFGQUlSIEkgdGhpbmsgd2UgdGFsa2VkIGFib3V0IHJlbmFtaW5nIGJv dGggaGVhZGVyIHJlbGF0ZWQgZmllbGRzLCBzbyAKcXVlcnlfaGRyIGFuZCBxdWVyeV9zeiwgbm8/ CgpUaGUgcmVzdCBsb29rcyBnb29kIHRvIG1lLgoKQWx0aG91Z2ggbm93IEkgYW0gYWxzbyB0aGlu a2luZyBhYm91dCBob3cgZGVzY3JpcHRpdmUgCiJpbml0X3F1ZXJ5X2l0ZW1fY2hlY2siIGlzLi4g c28gYW0gdGVtcHRlZCB0byBzdWdnZXN0IHNvbWUgbW9yZSBvYnZpb3VzIApuYW1lIGZvciBpdCwg bWF5YmUgZXZlbiBzaG9ydGVyLiA6KSBjb3B5X3F1ZXJ5X2l0ZW0/CgpSZWdhcmRzLAoKVHZydGtv Cgo+ICsJCQkJIHUzMiB0b3RhbF9sZW5ndGgsCj4gKwkJCQkgc3RydWN0IGRybV9pOTE1X3F1ZXJ5 X2l0ZW0gKnF1ZXJ5X2l0ZW0pCj4gK3sKPiArCWlmIChxdWVyeV9pdGVtLT5sZW5ndGggPT0gMCkK PiArCQlyZXR1cm4gdG90YWxfbGVuZ3RoOwo+ICsKPiArCWlmIChxdWVyeV9pdGVtLT5sZW5ndGgg PCB0b3RhbF9sZW5ndGgpCj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gKwo+ICsJaWYgKGNvcHlfZnJv bV91c2VyKHF1ZXJ5X2hkciwgdTY0X3RvX3VzZXJfcHRyKHF1ZXJ5X2l0ZW0tPmRhdGFfcHRyKSwK PiArCQkJICAgZGF0YV9zeikpCj4gKwkJcmV0dXJuIC1FRkFVTFQ7Cj4gKwo+ICsJaWYgKCFhY2Nl c3Nfb2sodTY0X3RvX3VzZXJfcHRyKHF1ZXJ5X2l0ZW0tPmRhdGFfcHRyKSwKPiArCQkgICAgICAg dG90YWxfbGVuZ3RoKSkKPiArCQlyZXR1cm4gLUVGQVVMVDsKPiArCj4gKwlyZXR1cm4gMDsKPiAr fQo+ICsKPiAgIHN0YXRpYyBpbnQgcXVlcnlfdG9wb2xvZ3lfaW5mbyhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsCj4gICAJCQkgICAgICAgc3RydWN0IGRybV9pOTE1X3F1ZXJ5X2l0 ZW0gKnF1ZXJ5X2l0ZW0pCj4gICB7Cj4gICAJY29uc3Qgc3RydWN0IHNzZXVfZGV2X2luZm8gKnNz ZXUgPSAmUlVOVElNRV9JTkZPKGRldl9wcml2KS0+c3NldTsKPiAgIAlzdHJ1Y3QgZHJtX2k5MTVf cXVlcnlfdG9wb2xvZ3lfaW5mbyB0b3BvOwo+ICAgCXUzMiBzbGljZV9sZW5ndGgsIHN1YnNsaWNl X2xlbmd0aCwgZXVfbGVuZ3RoLCB0b3RhbF9sZW5ndGg7Cj4gKwlpbnQgcmV0Owo+ICAgCj4gICAJ aWYgKHF1ZXJ5X2l0ZW0tPmZsYWdzICE9IDApCj4gICAJCXJldHVybiAtRUlOVkFMOwo+IEBAIC0z MywyMyArNTUsMTQgQEAgc3RhdGljIGludCBxdWVyeV90b3BvbG9neV9pbmZvKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgIAo+ICAgCXRvdGFsX2xlbmd0aCA9IHNpemVvZih0 b3BvKSArIHNsaWNlX2xlbmd0aCArIHN1YnNsaWNlX2xlbmd0aCArIGV1X2xlbmd0aDsKPiAgIAo+ IC0JaWYgKHF1ZXJ5X2l0ZW0tPmxlbmd0aCA9PSAwKQo+IC0JCXJldHVybiB0b3RhbF9sZW5ndGg7 Cj4gLQo+IC0JaWYgKHF1ZXJ5X2l0ZW0tPmxlbmd0aCA8IHRvdGFsX2xlbmd0aCkKPiAtCQlyZXR1 cm4gLUVJTlZBTDsKPiAtCj4gLQlpZiAoY29weV9mcm9tX3VzZXIoJnRvcG8sIHU2NF90b191c2Vy X3B0cihxdWVyeV9pdGVtLT5kYXRhX3B0ciksCj4gLQkJCSAgIHNpemVvZih0b3BvKSkpCj4gLQkJ cmV0dXJuIC1FRkFVTFQ7Cj4gKwlyZXQgPSBpbml0X3F1ZXJ5X2l0ZW1fY2hlY2soJnRvcG8sIHNp emVvZih0b3BvKSwgdG90YWxfbGVuZ3RoLAo+ICsJCQkJICAgIHF1ZXJ5X2l0ZW0pOwo+ICsJaWYg KHJldCAhPSAwKQo+ICsJCXJldHVybiByZXQ7Cj4gICAKPiAgIAlpZiAodG9wby5mbGFncyAhPSAw KQo+ICAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgIAo+IC0JaWYgKCFhY2Nlc3Nfb2sodTY0X3RvX3Vz ZXJfcHRyKHF1ZXJ5X2l0ZW0tPmRhdGFfcHRyKSwKPiAtCQkgICAgICAgdG90YWxfbGVuZ3RoKSkK PiAtCQlyZXR1cm4gLUVGQVVMVDsKPiAtCj4gICAJbWVtc2V0KCZ0b3BvLCAwLCBzaXplb2YodG9w bykpOwo+ICAgCXRvcG8ubWF4X3NsaWNlcyA9IHNzZXUtPm1heF9zbGljZXM7Cj4gICAJdG9wby5t YXhfc3Vic2xpY2VzID0gc3NldS0+bWF4X3N1YnNsaWNlczsKPiAKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==