From: "its_Giaan (Code Review)" Date: Wed, 29 Jan 2025 10:54:35 +0000 In-Reply-To: References: Reply-To: gianmarco@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296..., a@...2181... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="E8tEQqdnl7g="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: mroute/management: fix uninitialized variable (UNINIT) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cron2 , plaisthos , flichtenheld , openvpn-devel --E8tEQqdnl7g= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, flichtenheld, ordex, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/880?usp=3Demail ) Change subject: mroute/management: fix uninitialized variable (UNINIT) ...................................................................... Patch Set 4: (3 comments) File src/openvpn/manage.c: http://gerrit.openvpn.net/c/openvpn/+/880/comment/1917e810_8df15a58 : PS3, Line 597: n_killed =3D (*man->persist.callback.kill_by_cn)= (man->persist.callback.arg, p2); > Ah, no, not that one :-) for CN we only have p1 Done http://gerrit.openvpn.net/c/openvpn/+/880/comment/76fd57cc_1aede7fa : PS3, Line 600: msg(M_CLIENT, "SUCCESS: common name '%s' fou= nd, %d client(s) killed", p2, n_killed); > too enthusiastic Done http://gerrit.openvpn.net/c/openvpn/+/880/comment/1f0de4eb_2449a9e2 : PS3, Line 604: msg(M_CLIENT, "ERROR: common name '%s' not f= ound", p2); > and here Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/880?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4be0ff4d308213d2ef8ba66bd3178eee1f60fff1 Gerrit-Change-Number: 880 Gerrit-PatchSet: 4 Gerrit-Owner: its_Giaan Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: ordex Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Attention: ordex Gerrit-Comment-Date: Wed, 29 Jan 2025 10:54:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 Gerrit-MessageType: comment --E8tEQqdnl7g= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, flichtenheld, ordex, plais= thos.

View C= hange

3 comments:

    =
  • File src/openvpn/manage.c:

    • Patch Set #3, Line 597:= n_killed =3D (= *man->persist.callback.kill_by_cn)(man->persist.callback.arg, p2);

      Ah, no, not that one :-) for CN we only have p1

      Done

    • Patch Set #3, Line 600: msg(M_CLIENT, "SUCCESS: common name &#= 39;%s' found, %d client(s) killed", p2, n_killed);

      too enthusiastic

      Done

    • Patch Set #3, Line 604: <= code style=3D"font-family:monospace,monospace"> msg(M_CLIENT= , "ERROR: common name '%s' not found", p2);

      =

      and here

      Done

To view, visit change 880. To u= nsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4be0ff4d308213d2ef8ba66bd31= 78eee1f60fff1
Gerrit-Change-Number: 880
Gerrit-PatchSet: 4
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: ordex <a@...2181...>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: ordex <a@...2181...> <= /div>
Gerrit-Comment-Date: Wed, 29 Jan 2025 10:54:35= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...= >
Gerrit-MessageType: comment
--E8tEQqdnl7g=--