Received: from eggs.gnu.org ([209.51.188.92]:34630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1YqW-0005Zv-DX for qemu-devel@nongnu.org; Wed, 06 Mar 2019 10:52:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1YqV-000054-76 for qemu-devel@nongnu.org; Wed, 06 Mar 2019 10:52:40 -0500 From: Vladimir Sementsov-Ogievskiy Date: Wed, 6 Mar 2019 15:52:33 +0000 Message-ID: References: <20190305234337.18353-1-jsnow@redhat.com> <20190305234337.18353-5-jsnow@redhat.com> <6c9c5b9b-8093-e993-1027-db692d20e2e1@virtuozzo.com> <737eb62f-47f4-1824-909d-8578584b8794@redhat.com> In-Reply-To: <737eb62f-47f4-1824-909d-8578584b8794@redhat.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 4/5] block/qcow2-bitmap: Allow resizes with persistent bitmaps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , "qemu-devel@nongnu.org" Cc: "eblake@redhat.com" , Kevin Wolf , "qemu-block@nongnu.org" , Max Reitz MDYuMDMuMjAxOSAxODo0MSwgSm9obiBTbm93IHdyb3RlOg0KPiANCj4gDQo+IE9uIDMvNi8xOSAx MDozMyBBTSwgVmxhZGltaXIgU2VtZW50c292LU9naWV2c2tpeSB3cm90ZToNCj4+IDA2LjAzLjIw MTkgMjo0MywgSm9obiBTbm93IHdyb3RlOg0KPj4+IFNpbmNlIHdlIG5vdyBsb2FkIGFsbCBiaXRt YXBzIGludG8gbWVtb3J5IGFueXdheSwgd2UgY2FuIGp1c3QgdHJ1bmNhdGUgdGhlbQ0KPj4+IGlu LW1lbW9yeSBhbmQgdGhlbiBmbHVzaCB0aGVtIGJhY2sgdG8gZGlzay4gSnVzdCBpbiBjYXNlLCB3 ZSB3aWxsIHN0aWxsIGNoZWNrDQo+Pj4gYW5kIGVuZm9yY2UgdGhhdCB0aGlzIHNob3J0Y3V0IGlz IHZhbGlkIC0tIGkuZS4gdGhhdCBhbnkgYml0bWFwIGRlc2NyaWJlZA0KPj4+IG9uLWRpc2sgaXMg aW5kZWVkIGluLW1lbW9yeSBhbmQgY2FuIGJlIG1vZGlmaWVkLg0KPj4+DQo+Pj4gSWYgdGhlcmUg YXJlIGFueSBpbmNvbnNpc3RlbnQgYml0bWFwcywgd2UgcmVmdXNlIHRvIGFsbG93IHRoZSB0cnVu Y2F0ZSBhcw0KPj4+IHdlIGRvIG5vdCBhY3R1YWxseSBsb2FkIHRoZXNlIGJpdG1hcHMgaW50byBt ZW1vcnksIGFuZCBpdCBpc24ndCBzYWZlIG9yDQo+Pj4gcmVhc29uYWJsZSB0byBhdHRlbXB0IHRv IHRydW5jYXRlIGNvcnJ1cHRlZCBkYXRhLg0KPj4+DQo+Pj4gU2lnbmVkLW9mZi1ieTogSm9obiBT bm93IDxqc25vd0ByZWRoYXQuY29tPg0KPj4+IC0tLQ0KPj4+ICAgIGJsb2NrL3Fjb3cyLmggICAg ICAgIHwgIDEgKw0KPj4+ICAgIGJsb2NrL3Fjb3cyLWJpdG1hcC5jIHwgNDIgKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+Pj4gICAgYmxvY2svcWNvdzIuYyAgICAg ICAgfCAyNyArKysrKysrKysrKysrKysrKysrKy0tLS0tLS0NCj4+PiAgICAzIGZpbGVzIGNoYW5n ZWQsIDYzIGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pDQo+Pj4NCj4+PiBkaWZmIC0tZ2l0 IGEvYmxvY2svcWNvdzIuaCBiL2Jsb2NrL3Fjb3cyLmgNCj4+PiBpbmRleCA0YzFmZGZjYmVjLi5i OTIyN2E3MmNjIDEwMDY0NA0KPj4+IC0tLSBhL2Jsb2NrL3Fjb3cyLmgNCj4+PiArKysgYi9ibG9j ay9xY293Mi5oDQo+Pj4gQEAgLTY4OSw2ICs2ODksNyBAQCBRY293MkJpdG1hcEluZm9MaXN0ICpx Y293Ml9nZXRfYml0bWFwX2luZm9fbGlzdChCbG9ja0RyaXZlclN0YXRlICpicywNCj4+PiAgICBp bnQgcWNvdzJfcmVvcGVuX2JpdG1hcHNfcndfaGludChCbG9ja0RyaXZlclN0YXRlICpicywgYm9v bCAqaGVhZGVyX3VwZGF0ZWQsDQo+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgRXJyb3IgKiplcnJwKTsNCj4+PiAgICBpbnQgcWNvdzJfcmVvcGVuX2JpdG1hcHNfcncoQmxv Y2tEcml2ZXJTdGF0ZSAqYnMsIEVycm9yICoqZXJycCk7DQo+Pj4gK2ludCBxY293Ml90cnVuY2F0 ZV9iaXRtYXBzX2NoZWNrKEJsb2NrRHJpdmVyU3RhdGUgKmJzLCBFcnJvciAqKmVycnApOw0KPj4+ ICAgIHZvaWQgcWNvdzJfc3RvcmVfcGVyc2lzdGVudF9kaXJ0eV9iaXRtYXBzKEJsb2NrRHJpdmVy U3RhdGUgKmJzLCBFcnJvciAqKmVycnApOw0KPj4+ICAgIHZvaWQgcWNvdzJfZmx1c2hfcGVyc2lz dGVudF9kaXJ0eV9iaXRtYXBzKEJsb2NrRHJpdmVyU3RhdGUgKmJzLCBFcnJvciAqKmVycnApOw0K Pj4+ICAgIGludCBxY293Ml9yZW9wZW5fYml0bWFwc19ybyhCbG9ja0RyaXZlclN0YXRlICpicywg RXJyb3IgKiplcnJwKTsNCj4+PiBkaWZmIC0tZ2l0IGEvYmxvY2svcWNvdzItYml0bWFwLmMgYi9i bG9jay9xY293Mi1iaXRtYXAuYw0KPj4+IGluZGV4IDkzNzMwNTVkM2IuLjI0ZjI4MGJjY2MgMTAw NjQ0DQo+Pj4gLS0tIGEvYmxvY2svcWNvdzItYml0bWFwLmMNCj4+PiArKysgYi9ibG9jay9xY293 Mi1iaXRtYXAuYw0KPj4+IEBAIC0xMTY3LDYgKzExNjcsNDggQEAgaW50IHFjb3cyX3Jlb3Blbl9i aXRtYXBzX3J3KEJsb2NrRHJpdmVyU3RhdGUgKmJzLCBFcnJvciAqKmVycnApDQo+Pj4gICAgICAg IHJldHVybiBxY293Ml9yZW9wZW5fYml0bWFwc19yd19oaW50KGJzLCBOVUxMLCBlcnJwKTsNCj4+ PiAgICB9DQo+Pj4gICAgDQo+Pj4gKy8qIENoZWNrcyB0byBzZWUgaWYgaXQncyBzYWZlIHRvIHJl c2l6ZSBiaXRtYXBzICovDQo+Pj4gK2ludCBxY293Ml90cnVuY2F0ZV9iaXRtYXBzX2NoZWNrKEJs b2NrRHJpdmVyU3RhdGUgKmJzLCBFcnJvciAqKmVycnApDQo+Pj4gK3sNCj4+PiArICAgIEJEUlZR Y293MlN0YXRlICpzID0gYnMtPm9wYXF1ZTsNCj4+PiArICAgIFFjb3cyQml0bWFwTGlzdCAqYm1f bGlzdDsNCj4+PiArICAgIFFjb3cyQml0bWFwICpibTsNCj4+PiArICAgIGludCByZXQgPSAwOw0K Pj4+ICsNCj4+PiArICAgIGlmIChzLT5uYl9iaXRtYXBzID09IDApIHsNCj4+PiArICAgICAgICBy ZXR1cm4gMDsNCj4+PiArICAgIH0NCj4+PiArDQo+Pj4gKyAgICBibV9saXN0ID0gYml0bWFwX2xp c3RfbG9hZChicywgcy0+Yml0bWFwX2RpcmVjdG9yeV9vZmZzZXQsDQo+Pj4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBzLT5iaXRtYXBfZGlyZWN0b3J5X3NpemUsIGZhbHNlLCBlcnJw KTsNCj4+PiArICAgIGlmIChibV9saXN0ID09IE5VTEwpIHsNCj4+PiArICAgICAgICByZXR1cm4g LUVJTlZBTDsNCj4+PiArICAgIH0NCj4+PiArDQo+Pj4gKyAgICBRU0lNUExFUV9GT1JFQUNIKGJt LCBibV9saXN0LCBlbnRyeSkgew0KPj4+ICsgICAgICAgIEJkcnZEaXJ0eUJpdG1hcCAqYml0bWFw ID0gYmRydl9maW5kX2RpcnR5X2JpdG1hcChicywgYm0tPm5hbWUpOw0KPj4+ICsgICAgICAgIGlm IChiaXRtYXAgPT0gTlVMTCkgew0KPj4+ICsgICAgICAgICAgICAvKiBXZSByZWx5IG9uIGFsbCBi aXRtYXBzIGJlaW5nIGluLW1lbW9yeSB0byBiZSBhYmxlIHRvIHJlc2l6ZSB0aGVtLA0KPj4+ICsg ICAgICAgICAgICAgKiBPdGhlcndpc2UsIHdlJ2QgbmVlZCB0byByZXNpemUgdGhlbSBvbiBkaXNr IGV4cGxpY2l0bHkgKi8NCj4+PiArICAgICAgICAgICAgZXJyb3Jfc2V0ZyhlcnJwLCAiQ2Fubm90 IHJlc2l6ZSBxY293MiB3aXRoIHBlcnNpc3RlbnQgYml0bWFwcyB0aGF0ICINCj4+PiArICAgICAg ICAgICAgICAgICAgICAgICAid2VyZSBub3QgbG9hZGVkIGludG8gbWVtb3J5Iik7DQo+Pj4gKyAg ICAgICAgICAgIHJldCA9IC1FTk9UU1VQOw0KPj4+ICsgICAgICAgICAgICBnb3RvIG91dDsNCj4+ PiArICAgICAgICB9DQo+Pj4gKw0KPj4+ICsgICAgICAgIC8qIFRoZSBjaGVja3MgYWdhaW5zdCBy ZWFkb25seSBhbmQgYnVzeSBhcmUgcmVkdW5kYW50LCBidXQgY2VydGFpbmx5DQo+Pj4gKyAgICAg ICAgICogZG8gbm8gaGFybS4gY2hlY2tzIGFnYWluc3QgaW5jb25zaXN0ZW50IGFyZSBjcnVjaWFs OiAqLw0KPj4+ICsgICAgICAgIGlmIChiZHJ2X2RpcnR5X2JpdG1hcF9jaGVjayhiaXRtYXAsIEJE UlZfQklUTUFQX0RFRkFVTFQsIGVycnApKSB7DQo+Pj4gKyAgICAgICAgICAgIHJldCA9IC1FTk9U U1VQOw0KPj4+ICsgICAgICAgICAgICBnb3RvIG91dDsNCj4+PiArICAgICAgICB9DQo+Pj4gKyAg ICB9DQo+Pj4gKw0KPj4+ICtvdXQ6DQo+Pj4gKyAgICBiaXRtYXBfbGlzdF9mcmVlKGJtX2xpc3Qp Ow0KPj4+ICsgICAgcmV0dXJuIHJldDsNCj4+PiArfQ0KPj4+ICsNCj4+PiAgICAvKiBzdG9yZV9i aXRtYXBfZGF0YSgpDQo+Pj4gICAgICogU3RvcmUgYml0bWFwIHRvIGltYWdlLCBmaWxsaW5nIGJp dG1hcCB0YWJsZSBhY2NvcmRpbmdseS4NCj4+PiAgICAgKi8NCj4+PiBkaWZmIC0tZ2l0IGEvYmxv Y2svcWNvdzIuYyBiL2Jsb2NrL3Fjb3cyLmMNCj4+PiBpbmRleCA3ZmIyNzMwZjA5Li42ZmQ5MjUy NDk0IDEwMDY0NA0KPj4+IC0tLSBhL2Jsb2NrL3Fjb3cyLmMNCj4+PiArKysgYi9ibG9jay9xY293 Mi5jDQo+Pj4gQEAgLTM0NzIsNyArMzQ3Miw3IEBAIHN0YXRpYyBpbnQgY29yb3V0aW5lX2ZuIHFj b3cyX2NvX3RydW5jYXRlKEJsb2NrRHJpdmVyU3RhdGUgKmJzLCBpbnQ2NF90IG9mZnNldCwNCj4+ PiAgICB7DQo+Pj4gICAgICAgIEJEUlZRY293MlN0YXRlICpzID0gYnMtPm9wYXF1ZTsNCj4+PiAg ICAgICAgdWludDY0X3Qgb2xkX2xlbmd0aDsNCj4+PiAtICAgIGludDY0X3QgbmV3X2wxX3NpemU7 DQo+Pj4gKyAgICBpbnQ2NF90IG5ld19sMV9zaXplLCBvZmZzZXRfYmU7DQo+Pj4gICAgICAgIGlu dCByZXQ7DQo+Pj4gICAgICAgIFFEaWN0ICpvcHRpb25zOw0KPj4+ICAgIA0KPj4+IEBAIC0zNDk4 LDEwICszNDk4LDggQEAgc3RhdGljIGludCBjb3JvdXRpbmVfZm4gcWNvdzJfY29fdHJ1bmNhdGUo QmxvY2tEcml2ZXJTdGF0ZSAqYnMsIGludDY0X3Qgb2Zmc2V0LA0KPj4+ICAgICAgICAgICAgZ290 byBmYWlsOw0KPj4+ICAgICAgICB9DQo+Pj4gICAgDQo+Pj4gLSAgICAvKiBjYW5ub3QgcHJvY2Vl ZCBpZiBpbWFnZSBoYXMgYml0bWFwcyAqLw0KPj4+IC0gICAgaWYgKHMtPm5iX2JpdG1hcHMpIHsN Cj4+PiAtICAgICAgICAvKiBUT0RPOiByZXNpemUgYml0bWFwcyBpbiB0aGUgaW1hZ2UgKi8NCj4+ PiAtICAgICAgICBlcnJvcl9zZXRnKGVycnAsICJDYW4ndCByZXNpemUgYW4gaW1hZ2Ugd2hpY2gg aGFzIGJpdG1hcHMiKTsNCj4+PiArICAgIC8qIE9ubHkgY2VydGFpbiBwZXJzaXN0ZW50IGJpdG1h cHMgY2FuIGJlIHJlc2l6ZWQ6ICovDQo+Pj4gKyAgICBpZiAocWNvdzJfdHJ1bmNhdGVfYml0bWFw c19jaGVjayhicywgZXJycCkpIHsNCj4+PiAgICAgICAgICAgIHJldCA9IC1FTk9UU1VQOw0KPj4+ ICAgICAgICAgICAgZ290byBmYWlsOw0KPj4+ICAgICAgICB9DQo+Pj4gQEAgLTM3MDIsOSArMzcw MCw5IEBAIHN0YXRpYyBpbnQgY29yb3V0aW5lX2ZuIHFjb3cyX2NvX3RydW5jYXRlKEJsb2NrRHJp dmVyU3RhdGUgKmJzLCBpbnQ2NF90IG9mZnNldCwNCj4+PiAgICAgICAgYnMtPnRvdGFsX3NlY3Rv cnMgPSBvZmZzZXQgLyBCRFJWX1NFQ1RPUl9TSVpFOw0KPj4+ICAgIA0KPj4+ICAgICAgICAvKiB3 cml0ZSB1cGRhdGVkIGhlYWRlci5zaXplICovDQo+Pj4gLSAgICBvZmZzZXQgPSBjcHVfdG9fYmU2 NChvZmZzZXQpOw0KPj4+ICsgICAgb2Zmc2V0X2JlID0gY3B1X3RvX2JlNjQob2Zmc2V0KTsNCj4+ PiAgICAgICAgcmV0ID0gYmRydl9wd3JpdGVfc3luYyhicy0+ZmlsZSwgb2Zmc2V0b2YoUUNvd0hl YWRlciwgc2l6ZSksDQo+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICZvZmZzZXQsIHNp emVvZih1aW50NjRfdCkpOw0KPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAmb2Zmc2V0 X2JlLCBzaXplb2YodWludDY0X3QpKTsNCj4+PiAgICAgICAgaWYgKHJldCA8IDApIHsNCj4+PiAg ICAgICAgICAgIGVycm9yX3NldGdfZXJybm8oZXJycCwgLXJldCwgIkZhaWxlZCB0byB1cGRhdGUg dGhlIGltYWdlIHNpemUiKTsNCj4+PiAgICAgICAgICAgIGdvdG8gZmFpbDsNCj4+PiBAQCAtMzcx OSw2ICszNzE3LDIxIEBAIHN0YXRpYyBpbnQgY29yb3V0aW5lX2ZuIHFjb3cyX2NvX3RydW5jYXRl KEJsb2NrRHJpdmVyU3RhdGUgKmJzLCBpbnQ2NF90IG9mZnNldCwNCj4+PiAgICAgICAgaWYgKHJl dCA8IDApIHsNCj4+PiAgICAgICAgICAgIGdvdG8gZmFpbDsNCj4+PiAgICAgICAgfQ0KPj4+ICsN Cj4+PiArICAgIC8qIEZsdXNoIGJpdG1hcHMgKi8NCj4+PiArICAgIGlmIChzLT5uYl9iaXRtYXBz KSB7DQo+Pj4gKyAgICAgICAgRXJyb3IgKmxvY2FsX2VyciA9IE5VTEw7DQo+Pj4gKw0KPj4+ICsg ICAgICAgIC8qIFVzdWFsbHksIGJpdG1hcHMgZ2V0IHJlc2l6ZWQgYWZ0ZXIgdGhpcyBjYWxsLg0K Pj4+ICsgICAgICAgICAqIEZvcmNlIGl0IGVhcmxpZXIgc28gd2UgY2FuIG1ha2UgdGhlIG1ldGFk YXRhIGNvbnNpc3RlbnQuICovDQo+Pj4gKyAgICAgICAgYmRydl9kaXJ0eV9iaXRtYXBfdHJ1bmNh dGUoYnMsIG9mZnNldCk7DQo+Pj4gKyAgICAgICAgcWNvdzJfZmx1c2hfcGVyc2lzdGVudF9kaXJ0 eV9iaXRtYXBzKGJzLCAmbG9jYWxfZXJyKTsNCj4+PiArICAgICAgICBpZiAobG9jYWxfZXJyKSB7 DQo+Pj4gKyAgICAgICAgICAgIHJldCA9IC1FSU5WQUw7DQo+Pj4gKyAgICAgICAgICAgIGdvdG8g ZmFpbDsNCj4+PiArICAgICAgICB9DQo+Pj4gKyAgICB9DQo+Pg0KPj4gV2h5IHRvIGZsdXNoIGFm dGVyIHJlc2l6ZT8gQml0bWFwcyB3aWxsIGJlIElOX1VTRSBpbiB0aGUgaW1hZ2UgYW55d2F5Li4u DQo+Pg0KPj4gQ291bGQgd2UgaW1wbGVtZW50IHJlc2l6ZSB3aXRob3V0IGZsdXNoIGZpcnN0LCAg aXQgd291bGQgYmUgb25lIHBhdGNoICsgdGVzdD8gQW5kIHRoZW4gY29uc2lkZXINCj4+IGZsdXNo aW5nIGluIHNlcGFyYXRlPw0KPj4NCj4gDQo+IElmIHlvdSBkb24ndCBmbHVzaCBpdCB0byBkaXNr LCBhbGwgY2FsbHMgdG8gcmV0cmlldmUgdGhlIGJtX2xpc3QgYmVnaW4NCj4gZmFpbGluZyBiZWNh dXNlIG9mIGluY29uc2lzdGVudCBtZXRhZGF0YS4NCj4gDQo+IEZ1dHVyZSBjYWxscyB0byBhZGQg Yml0bWFwcywgcmVtb3ZlIGJpdG1hcHMsIGV0YyB3aWxsIHN0YXJ0IGZhaWxpbmcuIEl0DQo+IHNl ZW1lZCBzYWZlc3QgYW5kIGVhc2llc3QgdG8ganVzdCBmbHVzaCB0aGUgd2hvbGUgc3VpdGUgdG8g ZGlzay4gSSBhbQ0KPiB0cnlpbmcgdG8gYXZvaWQgcHJlbWF0dXJlIG9wdGltaXphdGlvbnMgYXQg dGhpcyBzdGFnZSwgYXMgSSBiZWxpZXZlDQo+IHJlc2l6ZXMgd2lsbCBiZSB2ZXJ5IGluZnJlcXVl bnQgZXZlbnRzLg0KDQpIbW1tLCB1bmRlcnN0YW5kLg0KDQpCdXQgSSB0aGluaywgaWYgd2UgYXJl IGdvaW5nIHRvIGFsbG93IHJlc2l6ZXMsIGl0IGRlZmluaXRlbHkgbWVhbnMgdGhhdCBJTl9VU0Ug ZmxhZyBjb3ZlcnMgbm90DQpvbmx5IGJpdG1hcCBkYXRhLCBidXQgc2l6ZSBmaWVsZCB0b28uIEFu ZCB3ZSBtdXN0IHdyaXRlIGl0IHRvIHNwZWNpZmljYXRpb24uIEFuZCBpdCBpcyByaWdodA0KZXZl biBpZiB5b3UgZmx1c2ggaGVyZSwgYXMgcmVzaXplIG1heSBmYWlsIGFmdGVyIHlvdXIgZmx1c2gs IGFuZCBhY3R1YWwgZGlzayBzaXplIHdpbGwgcmVtYWluDQp1bmNoYW5nZWQgd2hlbiBiaXRtYXBz IGFyZSBmbHVzaGVkIHdpdGggbmV3IHNpemUuDQoNCkFuZCBpZiBzaXplIGlzIGNvdmVyZWQgYnkg SU5fVVNFLCB3ZSBzaG91bGQgaWdub3JlIGl0IGZvciBJTl9VU0UgYml0bWFwcyAoZm9yIElOX1VT RSBieSB1cyB0b28pLg0KQW5kIGl0IG1lYW5zLCB0aGF0IHdlIG5lZWQgY2hlY2sgaXQgb25seSBv biBxY293Ml9vcGVuLiBBbmQgbm90IG9uIG90aGVyIGNhc2VzLg0KDQotLSANCkJlc3QgcmVnYXJk cywNClZsYWRpbWlyDQo=