Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDD26C77B7E for ; Thu, 25 May 2023 15:53:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E98D384710; Thu, 25 May 2023 17:53:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="DCAq7Md/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 89AE8846E0; Thu, 25 May 2023 17:53:43 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on20600.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e83::600]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 266A484710 for ; Thu, 25 May 2023 17:53:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nDrEG+DdbBnqLgjrNU9m+pbsi55Zp6qLeXbtCLexYlv/Jv9Lw1dsRw3l9wcvprwHayYuiBl20U4n5raYYfJATd1hvYa5GRrPMWfUNX5vcRvU0lfKdUSBnbhI9HQjQqE+TB/xy86I0N+UeVB6Oh//n4ANymGQyB/CmatfpD3+8E5ikjoaLnRCi0n6UjrLU+B75VxE4HWN4lr8m5viKRb3j1YhgOT6ukQ5BrRAZfXQGQ5YVAyxzO5CnduOeZJL4QGTO1py7elflCTZZtlQc9rLqeuq9TkSfy4+cnSuLpeVmTj0nFUdqid6d6amttwcN5Zv7VDJCaNucD6sYcag7Ysf1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DISZmyVpvldjlLUcdnxl/Kb6FpAWKa4v8An/NHDivBk=; b=Jp6J7Gyzwx9OMUSOahmMdJOKKUIkP2GvNOr15l+XpgvooJ/H208geqOTEHo3lJcBD6//wTHGAODYaG9bBg9J0qXfnptoc4UgvFu3F0QMKYpbBQ2MWGWY1SZVA++kzaYQvo4sSv0AYQiNk+NujtnXR3rnA00WTFeKYJaG1RKRA6Sh4j9SYwbmkZP51l5R1hxKhopDnB+NlBeQz2DpydH3LxQ9WbpJVboML4Ga3QbUwzPN32T14hZOOVO7UZjq3I3/0ypSUv2Y3Tpb37EQV5tLKacp5oAYMogKFuhPUGumzTSl2JhEsPH4YuZ7UtCh0HirMP5CogKgOJRAnTAoI2ztgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DISZmyVpvldjlLUcdnxl/Kb6FpAWKa4v8An/NHDivBk=; b=DCAq7Md/3+VUZMtGgwEi9meaWLUzQT9vlL6SPhKLMTrX0L1KX2C+uI103AR2Zmy4iFhO98vup6Bm0ngqgCFh1l6+sTefCSEF8RKZ7w+/S6IsBFzWC+xREjRIgsW9XIvQattBwTsBskk0aobUQBgeGEWGG0XJ+8M9rZFKCV7ALzk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BYAPR12MB4758.namprd12.prod.outlook.com (2603:10b6:a03:a5::28) by PH8PR12MB7183.namprd12.prod.outlook.com (2603:10b6:510:228::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15; Thu, 25 May 2023 15:53:34 +0000 Received: from BYAPR12MB4758.namprd12.prod.outlook.com ([fe80::e78e:b7da:7b9a:a578]) by BYAPR12MB4758.namprd12.prod.outlook.com ([fe80::e78e:b7da:7b9a:a578%4]) with mapi id 15.20.6411.028; Thu, 25 May 2023 15:53:34 +0000 Message-ID: Date: Thu, 25 May 2023 17:53:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2] PCI: zynqmp: Add ZynqMP NWL PCIe root port driver Content-Language: en-US To: Stefan Roese , u-boot@lists.denx.de Cc: Simon Glass , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Bin Meng References: <20230525094918.111949-1-sr@denx.de> From: Michal Simek In-Reply-To: <20230525094918.111949-1-sr@denx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0132.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::6) To BYAPR12MB4758.namprd12.prod.outlook.com (2603:10b6:a03:a5::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR12MB4758:EE_|PH8PR12MB7183:EE_ X-MS-Office365-Filtering-Correlation-Id: 60db67bc-8228-4cdb-8317-08db5d3831de X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zxuph/O0QkLW/M/WKTulu0Clgjx3jfeSvkBIKgN0G+mQeu3NFTWA8dQtW0G9cKUgyF2rogBts7diwkPCMDRpM3RyRIGrKF5tsjp3bebCEyCjOtFUZUSvdlYzgqU/Dcawz0s85rFLtZ107lA8IDwqrsO2eJsotyYiB1kFG/63JxvaoXWN9bcADPJLR5NRgcbOWLwBPyKHNZy3DoT9vBfG966vX8MgDZoNodvUuBjUHsijubHJgyTVx/h9/6EH3mtYlzsNfhCgNzAkS356eaM/cjC+d897i0Nk81ylz84BsoTRN+Or8oHgAG8ICeFI3QdPKCIzqwOZjTpgpbj1JkzbvBM1DtfnBcF02ZRF1afKLrcxIVKu+lrjqXAV6h8/nuL3L0LI4PAp6WQ1HQ0x0MVk9lke8PY9xePObx1xpByvv/TfvB+lXxcTGhXdT8kVqaYN6Ph6ijbwc3r3E/V6CGB4OtP5G/z/N9gRvH5Scz1MzscIu0jfYvnvO5Rz1rq5P5p5gPw4/Cs2wBodWKP4it6F1MLATnCjvsGbCE56LOIFS6oEMtX+xs/6tb2CN5JgjyeEAk/mMHrqo24676Bf7HbPGmeocvkOy0XD8wWOsYhYpVswXsPL0qDq+3hhsS7crYD6XL+pynGLhbism0jITQSAKA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB4758.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(366004)(136003)(396003)(376002)(346002)(451199021)(66556008)(54906003)(41300700001)(6486002)(31686004)(66476007)(66946007)(5660300002)(8676002)(8936002)(6506007)(53546011)(6512007)(44832011)(478600001)(4326008)(6666004)(316002)(26005)(186003)(66574015)(2616005)(2906002)(31696002)(86362001)(38100700002)(36756003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bjJENU0zR3ZQUlU0SG5ZZmliQU5YTnN5dElYOEZEaWdUUDZiS2NrQnNWcWhx?= =?utf-8?B?bUFxbTBsL2RqZmhmYVNTd1E4dFhKN0VTaGNDZkZvRllLbDYwRlpBLyt2TUFx?= =?utf-8?B?Rm5LUFFhNytBNTBPUWlrdzFvdXg4cDdqQmthMlNpcUFHeUg3UDZySXQzVFFY?= =?utf-8?B?VFc4ZCt0L2VSRDdaOThHSkYxeXNMa3BrTTE3ellEa3dSbVcveHJVNlMxWWdT?= =?utf-8?B?YnpKdWRDQzVnZU50b3ZhcjlROU10QUN1andNeXMxbkNFVG02cWZkbGM5Unp4?= =?utf-8?B?bTczQUJyb3BaQUlVK25qTmdlTjhFVVVreWFXaG9vcDh0WHBYOUZlNWxpbXVj?= =?utf-8?B?Z0thempFc2ZlNWI2SHFkbkpmaWJZSWt3S1IyRVR5ZDB5Z0p0WjROTS9wMmI3?= =?utf-8?B?dXpoVFJiYmVIVFpGRzl3T1ZNQ05nd21HUE14SzRYNUIybGdRNjZOUFpxQUlm?= =?utf-8?B?QmVLVmh1QnNiVWlFVHFYQU1wSEcrUEhCc3JTdHNWWGRjTzRuNFExTWZPWXND?= =?utf-8?B?SndJQUdLVTZYV0NjQ2dHb2g1eGpnMWl1T3o4Y0NKaExHRFp2WnlvcjB5SmlX?= =?utf-8?B?bXlQdWZEV0I1aldlbGlDdHNlNFY0NzJha0k4d2dhOG9NMVFra05pUndvbkZx?= =?utf-8?B?QkNJeU5XZVpBSDhLdmpyM1JzT1NDTE0xblEzZzZUMUdydm1BYjR0RWovaGVw?= =?utf-8?B?dFE5RUprSk55aXJNMmdvUkh6MG1NYWUvRkRMcDhjVldCZHFxL3ExTlpwUHlF?= =?utf-8?B?bjM2cHh5Qnp6dHlOZWRqdWN0WjIvZ1Q5bFRCdzlwdkQvSmpUWktWRXo2OHAz?= =?utf-8?B?V3FXcFhBQ01jQVNsbHM3UnZGQlVucjZJVE01L3lDNUR3RFYrMTdDM1pxRUlI?= =?utf-8?B?ZFdueXFLUTZ0Z1FxWmU1YzNYMStKSW42M01BdysrSmhocjJDSmhVanh3Z2ZS?= =?utf-8?B?VnJXQ21VTFVKbS9OQmhQUjlPMHlxSUloNFNMY2Y3SlBHVk5tRnVLblp0bXp0?= =?utf-8?B?T1BSWEV4NFo0Y25RcWlnT1RnTTlqY1FtcXRWaTB5dGQvdVd3WHFxM0wrbktF?= =?utf-8?B?QVRBL2loK3dlQ0haT3FMMFpNa0p1NEpRcUw1SHUyZkY2YXF1UXpDVHlJNzNY?= =?utf-8?B?TmtNMVRhVkRPNXZSdDFicFVVWFBaWnR5N3lnbU9NRjIrNFh0UFNxSXY4VVlU?= =?utf-8?B?K0MvdmQ5Y25RcnprNmZvMmFiRG5pOXRYeFV0ZXoyb1FaUHRuQVh2dlJhZ2pV?= =?utf-8?B?SlNzRG5LQmc1VnFqZUNURFBnc3hCb2VDMGhzcEgwWWZMMkRocEFvSHhDSnFw?= =?utf-8?B?Ry9MNmlvcEprbWRwN0NCbTFXQ3hsSlBwbzRJTkJ6ck9SSlVrNTdsbm4ySDlx?= =?utf-8?B?ZkxsWWxGWFFONDZURnphbmpBZU9ZQzYwTlM0dmFuMFQ4SXVVblMwbGVRYVBn?= =?utf-8?B?MVRGeEdhbUhJR0FocEc0R2h1a1FFa0xTWkwyVWRFU2tEOUF5S21aY2MvRGlR?= =?utf-8?B?UCtmVTBMMnB2N2Q4dWJDbWVObGNOK3pUeVNzd2NhbFAzOEFZbTJIQlg4eEpK?= =?utf-8?B?ZnUydnU0bmwvZGhXS01XN2czK3FraVhyZXFyMy91YjdWeUNlTVlIdGFFcU9v?= =?utf-8?B?bWpkZmlmNTJvTE5nZWtISkxaeVlFWjY4QUw1dzlGL3BVK1FiQmp3N05vMHAz?= =?utf-8?B?R3lLTmlodVYvN0tka2xrQUVVOFZJVDM5aERaVnM5dDgwZ1U5anlhRUhid21V?= =?utf-8?B?M2NZVytHcXZQMlYyc3Zub1o2V3ZrNlhHU0t5cjVkczhTckczeGx6UVR6NVdY?= =?utf-8?B?SlhocWM4ZW43bjZVVUwzbVZNZDdFMDJvbGJJV3pBcUQ0bVUxVnlocDFMRlh3?= =?utf-8?B?K2NxZG9RVFh0KzhrUktWYzBwcXU2TkR3NkZoV1pHZWZqN2IycGM4cS9RaWlp?= =?utf-8?B?anJtOGd4UXdLMHpYR1dqYzB5Nm1Sckg1aDBSNVdpZFV2MmZhd0ZmMHRYN0FD?= =?utf-8?B?cGhXaERSRmZlNFAzZ1NxcEF6YnpBMkV3aFA0aWpzQ2lTYmQvOWdQOFVvQWRn?= =?utf-8?B?dnJkbjdtczRIdWZPMWF6TCtYTnVoZVFYekRLNDNYRTJUUy8yUEdnMm15bEgr?= =?utf-8?Q?ElpaxRvxefJt8Wmu+W64OZdLS?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60db67bc-8228-4cdb-8317-08db5d3831de X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2023 15:53:34.0764 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 02pm0TQl3AEk1UwjgvF3V6DRi2LbnFIe3lZLggfg03Hapv4yVVlI+IhECepBt/gP X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7183 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 5/25/23 11:49, Stefan Roese wrote: > This patch adds the PCIe controller driver for the Xilinx / AMD ZynqMP > NWL PCIe Bridge as root port. The driver source is partly copied from > the Linux PCI driver and modified to enable usage in U-Boot (e.g. > simplified and interrupt support removed). > > Signed-off-by: Stefan Roese > Cc: Simon Glass > Cc: Pali Rohár > Cc: Bin Meng > Cc: Michal Simek > --- > v2: > - Remove some unused members from struct nwl_pcie > - Fix usage of dev_seq() in nwl_pcie_config_address() > - Remove writing to PCI_PRIMARY_BUS reg as this is done by the > common U-Boot PCI code later > > MAINTAINERS | 1 + > drivers/pci/Kconfig | 7 + > drivers/pci/Makefile | 1 + > drivers/pci/pcie-xilinx-nwl.c | 352 ++++++++++++++++++++++++++++++++++ > 4 files changed, 361 insertions(+) > create mode 100644 drivers/pci/pcie-xilinx-nwl.c Tested-by: Michal Simek Acked-by: Michal Simek I am happy to take this via my tree if you like. We should also enable this driver by default in xilinx_zynqmp_virt_defconfig and likely any pcie driver to be able to test it. I used e1000 based card and it works as expected. Thanks, Michal