Received: from eggs.gnu.org ([2001:4830:134:3::10]:34596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLvRX-0008Po-NJ for qemu-devel@nongnu.org; Mon, 04 Dec 2017 13:26:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLvRW-0003OW-QN for qemu-devel@nongnu.org; Mon, 04 Dec 2017 13:26:15 -0500 References: <20171120201004.14999-1-mreitz@redhat.com> <20171120201004.14999-25-mreitz@redhat.com> From: Max Reitz Message-ID: Date: Mon, 4 Dec 2017 19:26:02 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TlpQCUgBAujUHGiVElfcQ5StlVn1eqAjR" Subject: Re: [Qemu-devel] [PATCH v7 for-2.12 24/25] block/curl: Implement bdrv_refresh_filename() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Kevin Wolf , Eric Blake , John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TlpQCUgBAujUHGiVElfcQ5StlVn1eqAjR From: Max Reitz To: Alberto Garcia , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Kevin Wolf , Eric Blake , John Snow Message-ID: Subject: Re: [PATCH v7 for-2.12 24/25] block/curl: Implement bdrv_refresh_filename() References: <20171120201004.14999-1-mreitz@redhat.com> <20171120201004.14999-25-mreitz@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2017-12-04 17:51, Alberto Garcia wrote: > On Mon 20 Nov 2017 09:10:03 PM CET, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- >> block/curl.c | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/block/curl.c b/block/curl.c >> index 11318a9a29..fe57223fda 100644 >> --- a/block/curl.c >> +++ b/block/curl.c >> @@ -957,6 +957,20 @@ static int64_t curl_getlength(BlockDriverState *b= s) >> return s->len; >> } >> =20 >> +static void curl_refresh_filename(BlockDriverState *bs) >> +{ >> + BDRVCURLState *s =3D bs->opaque; >> + >> + if (!s->sslverify || s->cookie || >> + s->username || s->password || s->proxyusername || s->proxypas= sword) >> + { >=20 > Is !s->sslverify negative because that setting is true by default? Yes, exactly. If it's false, you'd need to override it (and you can't do that through a plain filename). Thanks for reviewing, again. :-) Max --TlpQCUgBAujUHGiVElfcQ5StlVn1eqAjR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFGBAEBCAAwFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAlolkzoSHG1yZWl0ekBy ZWRoYXQuY29tAAoJEPQH2wBh1c9ARCkH/Rjpf4dYwXYI2fQITN4h7sUk/KQ8S0JU 7U1481+LfRA1ZtUTydV5CyMCUy+5HjvUWUVi61ZRe5W7H7/1v+IK4BPAVeYYoCzq qZ1n2PBavMu9orf2l0587Gll4JRI+zqmjzo9rdHf8Xs9Njelp8ZDLqo6Qir1ZQI2 GQPgjFqDPa4INBQyj+pzqeAH6VYiGasjatnuqWEO80MjcIIdGmkhrehjhDHj68ud 3FgBqq4oKHRp9b/ZH2gSPp8CIDrTwBo3Tdm5rUnjrf3rewzgWJYtM+OgvhLM+/Gm 7tCE18+lJ2kOpMHaAz+oSCMK8Bv7yF0HHpfxUQzuE66tCD4wWkg2Bbc= =6OJX -----END PGP SIGNATURE----- --TlpQCUgBAujUHGiVElfcQ5StlVn1eqAjR--