From: Yaodong Li Subject: Re: [PATCH v8 3/6] drm/i915/guc: Implement dynamic GuC WOPCM offset and size Date: Tue, 6 Feb 2018 20:51:56 -0800 Message-ID: References: <1517875362-12755-1-git-send-email-yaodong.li@intel.com> <1517875362-12755-3-git-send-email-yaodong.li@intel.com> <3bab3ad3-0b37-7a99-15a1-1c609f464e87@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id C71C06E1B5 for ; Wed, 7 Feb 2018 04:53:32 +0000 (UTC) In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko , intel-gfx@lists.freedesktop.org, Sagar Arun Kamble Cc: Sujaritha Sundaresan List-Id: intel-gfx@lists.freedesktop.org CgpPbiAwMi8wNi8yMDE4IDAyOjI1IFBNLCBNaWNoYWwgV2FqZGVjemtvIHdyb3RlOgo+Cj4+PiBk ZWZhdWx0X2Rlc2NfdGVtcGxhdGUoZGV2X3ByaXYsIGRldl9wcml2LT5tbS5hbGlhc2luZ19wcGd0 dCk7Cj4+PiDCoCAtwqDCoMKgIC8qIEd1QyByZXF1aXJlcyB0aGUgcmluZyB0byBiZSBwbGFjZWQg YWJvdmUgR1VDX1dPUENNX1RPUC4gSWYgCj4+PiBHdUMgaXMgbm90Cj4+PiArwqDCoMKgIC8qCj4+ PiArwqDCoMKgwqAgKiBHdUMgcmVxdWlyZXMgdGhlIHJpbmcgdG8gYmUgcGxhY2VkIGFib3ZlIEd1 QyBXT1BDTSB0b3AuIElmIAo+Pj4gR3VDIGlzIG5vdAo+Pj4gwqDCoMKgwqDCoMKgICogcHJlc2Vu dCBvciBub3QgaW4gdXNlIHdlIHN0aWxsIG5lZWQgYSBzbWFsbCBiaWFzIGFzIHJpbmcgCj4+PiB3 cmFwYXJvdW5kCj4+PiDCoMKgwqDCoMKgwqAgKiBhdCBvZmZzZXQgMCBzb21ldGltZXMgaGFuZ3Mu IE5vIGlkZWEgd2h5Lgo+Pj4gwqDCoMKgwqDCoMKgICovCj4+PiDCoMKgwqDCoMKgIGlmIChVU0VT X0dVQyhkZXZfcHJpdikpCj4+PiAtwqDCoMKgwqDCoMKgwqAgY3R4LT5nZ3R0X29mZnNldF9iaWFz ID0gR1VDX1dPUENNX1RPUDsKPj4+ICvCoMKgwqDCoMKgwqDCoCBjdHgtPmdndHRfb2Zmc2V0X2Jp YXMgPSBkZXZfcHJpdi0+Z3VjLndvcGNtLnRvcDsKPgo+IEkga25vdyB0aGF0IEpvb25hcyB3YXMg YWdhaW5zdCB1c2luZyBleHRyYSBpbmxpbmUgZnVuY3Rpb24gdG8gcmVhZAo+IHZhbHVlIG9mICJn dWMud29wY20udG9wIiBidXQgbWF5YmUgd2Ugc2hvdWxkIGRpc2N1c3MgaXQgYWdhaW4gYXMKPiBu b3cgd2UgbWF5YmUgdXNpbmcgaW52YWxpZC91bnNldCB2YWx1ZSBzaW5jZSBub3cgd2UgYXJlIG5v dCB2ZXJpZnlpbmcKPiAiZ3VjLT53b3BjbS52YWxpZCIgZmxhZy4KPgpJdCBzaG91bGQgYmUgZmlu ZSBpbiB0aGlzIGNhc2Ugc2luY2Ugd2UgaGF2ZSBlYXJseSBpbml0ZWQgdGhlIHZhbHVlIHRvIAp0 aGUgd29yc3QKY2FzZSAodXNpbmcgdGhlIHNpemUgb2YgYWxsIFdPUENNKS4gd2UgY291bGQgbm90 IHVzZSB2YWxpZCBoZXJlIHNpbmNlIAp1Y19pbml0CmhhcyBiZWVuIGNhbGxlZCBhdCB0aGlzIHBv aW50Lgo+Pj4KPj4+ICtzdGF0aWMgaW5saW5lIGludCBnZW45X2d1Y193b3BjbV9zaXplX2NoZWNr KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlIAo+Pj4gKmk5MTUpCj4KPiBtYXliZSBpdCB3b3VsZCBi ZSBiZXR0ZXIgdG8gcGFzcyAid29wY20iIGluc3RlYWQgb2YgImk5MTUiID8KPgpobW0sIEkgdGhp bmsgaXQncyBiZXR0ZXIgdG8gaGF2ZSBhbiB1bmlmaWVkIHBhcmFtZXRlciBsaXN0IGZvciBhbGwg dGhlIApjaGVjayBmdW5jdGlvbnMuCmFuZCBpdCB0aGUgc2FtZSBzaW5jZSB3ZSB3aWxsIGhhdmUg dG8gZ2V0IHdvcGNtIGZyb20gaTkxNSBhbnl3YXlzLgo+Pj4gK3sKPj4+ICvCoMKgwqAgc3RydWN0 IGludGVsX2d1Y193b3BjbSAqd29wY20gPSAmaTkxNS0+Z3VjLndvcGNtOwo+PiB1c2UgdmFyaWFi bGUgbmFtZSBhcyBndWNfd29wY20/Cj4+PiArwqDCoMKgIHUzMiBndWNfd29wY21fc3RhcnQ7Cj4+ PiArwqDCoMKgIHUzMiBkZWx0YTsKPj4+ICsKPj4+ICvCoMKgwqAgLyoKPj4+ICvCoMKgwqDCoCAq IEd1QyBXT1BDTSBzaXplIGlzIGF0IGxlYXN0IDQgYnl0ZXMgbGFyZ2VyIHRoYW4gdGhlIG9mZnNl dCAKPj4+IGZyb20gV09QQ00KPgo+IEVpdGhlciB1c2UgNEIgZGlyZWN0bHkgYmVsb3cgKGFzIHlv dSBnaXZlIGV4cGxhbmF0aW9uIGhlcmUpIG9yIG1vdmUgdGhhdAo+IGNvbW1lbnQgbmVhciB0aGUg ZGVmaW5pdGlvbiBvZiBHRU45X0dVQ19XT1BDTV9ERUxUQS4KPgo+Pj4gK8KgwqDCoMKgICogYmFz ZSAoR3VDIFdPUENNIG9mZnNldCBmcm9tIFdPUENNIGJhc2UgKyAKPj4+IEdFTjlfR1VDX1dPUENN X09GRlNFVCkgZHVlCj4+PiArwqDCoMKgwqAgKiB0byBoYXJkd2FyZSBsaW1pdGF0aW9uIG9uIEdl bjkuCj4+PiArwqDCoMKgwqAgKi8KPj4+ICvCoMKgwqAgZ3VjX3dvcGNtX3N0YXJ0ID0gd29wY20t Pm9mZnNldCArIEdFTjlfR1VDX1dPUENNX09GRlNFVDsKPj4+ICvCoMKgwqAgaWYgKHVubGlrZWx5 KGd1Y193b3BjbV9zdGFydCA+IHdvcGNtLT5zaXplKSkKPj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1 cm4gLUUyQklHOwo+Pj4gKwo+Pj4gK8KgwqDCoCBkZWx0YSA9IHdvcGNtLT5zaXplIC0gZ3VjX3dv cGNtX3N0YXJ0Owo+Pj4gK8KgwqDCoCBpZiAodW5saWtlbHkoZGVsdGEgPCBHRU45X0dVQ19XT1BD TV9ERUxUQSkpCj4+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FMkJJRzsKPj4+ICsKPj4+ICvC oMKgwqAgcmV0dXJuIDA7Cj4+PiArfQo+Pj4gKwo+Pj4gK3N0YXRpYyBpbmxpbmUgaW50IGd1Y193 b3BjbV9jaGVja19od19yZXN0cmljdGlvbnMoc3RydWN0IGludGVsX2d1YyAKPj4+ICpndWMpCj4+ PiArewo+Pj4gK8KgwqDCoCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSA9IGd1Y190b19p OTE1KGd1Yyk7Cj4+PiArCj4+PiArwqDCoMKgIGlmIChJU19HRU45KGk5MTUpKQo+Pj4gK8KgwqDC oMKgwqDCoMKgIHJldHVybiBnZW45X2d1Y193b3BjbV9zaXplX2NoZWNrKGk5MTUpOwo+Cj4gcGxl YXNlIHVzZSBmdW5jdGlvbiBuYW1lIHRoYXQgbWF0Y2hlcyBkaXNwYXRjaGVyIGZ1bmN0aW9uCj4K PiBndWNfd29wY21fY2hlY2tfaHdfcmVzdHJpY3Rpb25zKCkKPiBnZW45X2d1Y193b3BjbV9jaGVj a19od19yZXN0cmljdGlvbnMoKQo+Cj4gb3IKPgo+IGd1Y193b3BjbV9zaXplX2NoZWNrKCkKPiBn ZW45X2d1Y193b3BjbV9zaXplX2NoZWNrKCkKPgo+Pj4gKwo+Pj4gK8KgwqDCoCByZXR1cm4gMDsK Pj4+ICt9Cj4+PiArCj4+PiArLyoqCj4+PiArICogaW50ZWxfZ3VjX3dvcGNtX2luaXQoKSAtIElu aXRpYWxpemUgdGhlIEd1QyBXT1BDTS4uCj4+IHJlbW92ZSBleHRyYSAiLiIKPj4+IMKgwqAgKiBA Z3VjOiBpbnRlbCBndWMuCj4+PiArICogQGd1Y19md19zaXplOiBzaXplIG9mIEd1QyBmaXJtd2Fy ZS4KPj4+ICsgKiBAaHVjX2Z3X3NpemU6IHNpemUgb2YgSHVDIGZpcm13YXJlLgo+Pj4gwqDCoCAq Cj4+PiAtICogR2V0IHRoZSBwbGF0Zm9ybSBzcGVjaWZpYyBHdUMgV09QQ00gc2l6ZS4KPj4+ICsg KiBDYWxjdWxhdGUgdGhlIEd1QyBXT1BDTSBvZmZzZXQgYW5kIHNpemUgYmFzZWQgb24gR3VDIGFu ZCBIdUMgCj4+PiBmaXJtd2FyZSBzaXplcy4KPj4+ICsgKiBUaGlzIGZ1bmN0aW9uIHdpbGwgdG8g c2V0IHRoZSBHdUMgV09QQ00gc2l6ZSB0byB0aGUgc2l6ZSBvZiAKPj4+IG1heGltdW0gV09QQ00K Pj4gcmVtb3ZlICJ0byIKPj4+ICsgKiBhdmFpbGFibGUgZm9yIEd1Qy4gVGhpcyBmdW5jdGlvbiB3 aWxsIGFsc28gZW5mb3JjZSBwbGF0Zm9ybSAKPj4+IGRlcGVuZGVudAo+Pj4gKyAqIGhhcmR3YXJl IHJlc3RyaWN0aW9ucyBvbiBHdUMgV09QQ00gb2Zmc2V0IGFuZCBzaXplLiBJdCB3aWxsIGZhaWwg Cj4+PiB0aGUgR3VDCj4+PiArICogV09QQ00gaW5pdCBpZiBhbnkgb2YgdGhlc2UgY2hlY2tzIHdl cmUgZmFpbGVkLCBzbyB0aGF0IHRoZSAKPj4+IGZvbGxvd2luZyBHdUMKPj4+ICsgKiBmaXJtd2Fy ZSB1cGxvYWRpbmcgd291bGQgYmUgYWJvcnRlZC4KPj4+IMKgwqAgKgo+Pj4gLSAqIFJldHVybjog c2l6ZSBvZiB0aGUgR3VDIFdPUENNLgo+Pj4gKyAqIFJldHVybjogMCBvbiBzdWNjZXNzLCBub24t emVybyBlcnJvciBjb2RlIG9uIGZhaWx1cmUuCj4+PiDCoMKgICovCj4+PiAtdTMyIGludGVsX2d1 Y193b3BjbV9zaXplKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPgo+IEhtbSwgaXQgbG9va3MgdGhh dCBhbGwgeW91ciBjaGFuZ2VzIGZvciB0aGlzIGZ1bmN0aW9uIGZyb20gcGF0Y2ggMi82Cj4gYXJl IG5vdyBsb3N0IC4uLgo+CnBhdGNoIDEvNiAmIDIvNiBhcmUgb25seSBmb3Igc29tZSBjb2RlIG1v dmluZ3MuIGJ1dCBoYXZlIHRvIG1ha2UgaXQgY2xlYW4uCmJ1dCBJIGRvIG5vdCBuZWVkIHRoaXMg ZnVuYyBhbnltb3JlOm8pCj4+PiAraW50IGludGVsX2d1Y193b3BjbV9pbml0KHN0cnVjdCBpbnRl bF9ndWMgKmd1YywgdTMyIGd1Y19md19zaXplLAo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCB1MzIgaHVjX2Z3X3NpemUpCj4+PiDCoCB7Cj4+PiAtwqDCoMKgIHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICppOTE1ID0gZ3VjX3RvX2k5MTUoZ3VjKTsKPj4+IC3CoMKgwqAgdTMyIHNpemUgPSBH VUNfV09QQ01fVE9QOwo+Pj4gK8KgwqDCoCB1MzIgcmVzZXJ2ZWQgPSBndWNfcmVzZXJ2ZWRfd29w Y21fc2l6ZShndWMpOwo+Pj4gK8KgwqDCoCB1MzIgb2Zmc2V0LCBzaXplLCB0b3A7Cj4+PiArwqDC oMKgIGludCBlcnI7Cj4+PiDCoCAtwqDCoMKgIC8qIE9uIEJYVCwgdGhlIHRvcCBvZiBXT1BDTSBp cyByZXNlcnZlZCBmb3IgUkM2IGNvbnRleHQgKi8KPj4+IC3CoMKgwqAgaWYgKElTX0dFTjlfTFAo aTkxNSkpCj4+PiAtwqDCoMKgwqDCoMKgwqAgc2l6ZSAtPSBCWFRfR1VDX1dPUENNX1JDNl9SRVNF UlZFRDsKPj4+ICvCoMKgwqAgaWYgKGd1Yy0+d29wY20udmFsaWQpCj4+PiArwqDCoMKgwqDCoMKg wqAgcmV0dXJuIDA7Cj4KPiBJcyB0aGVyZSBhIHNjZW5hcmlvIHdoZW4gdGhpcyBmdW5jdGlvbiB3 aWxsIGJlIGNhbGxlZCBtb3JlIHRoYW4gb25lPwpZb3UncmUgcmlnaHQuIHdlIG5lZWQgbm90IG5l ZWQgc3VjaCBhIGNoZWNrIGFueW1vcmUuCj4KPj4+ICsKPj4+ICvCoMKgwqAgaWYgKCFndWNfZndf c2l6ZSkKPj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVJTlZBTDsKPgo+IEdFTV9CVUdfT04g Pwo+Cj4+PiArCj4+PiArwqDCoMKgIGlmIChyZXNlcnZlZCA+PSBXT1BDTV9ERUZBVUxUX1NJWkUp Cj4+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FMkJJRzsKPgo+IEdFTV9CVUdfT04gPwpXaWxs IGdpdmUgdGhlIGNvbnRyb2wgYmFjayB0byB1Y19pbml0Lj8KPgo+Pj4gKwo+Pj4gK8KgwqDCoCBv ZmZzZXQgPSBodWNfZndfc2l6ZSArIFdPUENNX1JFU0VSVkVEX1NJWkU7Cj4KPiBXaGF0J3MgdGhl IGRpZmZlcmVuY2UgYmV0d2VlbiBndWNfcmVzZXJ2ZWRfd29wY21fc2l6ZSBhbmQgCj4gV09QQ01f UkVTRVJWRURfU0laRQo+CldPUENNX1JFU0VSVkVEX1NJWkUgaXMgdGhlIHJlc2VydmVkIHNpemUg aW4gTm9uLUd1QyBXT1BDTS4KPj4+ICvCoMKgwqAgZ3VjLT53b3BjbS5vZmZzZXQgPSBvZmZzZXQ7 Cj4+PiArwqDCoMKgIGd1Yy0+d29wY20uc2l6ZSA9IHNpemU7Cj4+PiArwqDCoMKgIGd1Yy0+d29w Y20udG9wID0gdG9wOwo+Pj4gKwo+Pj4gK8KgwqDCoCAvKiBDaGVjayBwbGF0Zm9ybSBzcGVjaWZp YyByZXN0cmljdGlvbnMgKi8KPj4+ICvCoMKgwqAgZXJyID0gZ3VjX3dvcGNtX2NoZWNrX2h3X3Jl c3RyaWN0aW9ucyhndWMpOwo+Cj4gbWF5YmUgeW91IHNob3VsZCBjaGVjayBIVyByZXN0cmljdGlv bnMgKmJlZm9yZSogaW5pdGlhbGl6aW5nIHRoZSAKPiBzdHJ1Y3R1cmU/Cj4KPiBlcnIgPSBjaGVj a19od19yZXN0cmljdGlvbnMoaTkxNSwgb2Zmc2V0LCBzaXplLCB0b3ApOwpBY3R1YWxseSwgSSB3 YXMgc3RydWdnbGluZyBvbiB0aGlzIGEgYml0LCBidXQgaXQncyBjbGVhcmVyIHRvIGhhdmUgdG8g CnZhbGlkIGJpdCBpbiB0aGlzCnN0cnVjdCBpbnN0ZWFkIG9mIG9ubHkgY2hlY2tpbmcgb2Zmc2V0 L3NpemUvdG9wLiBBbmQgbm93IHRoYXQgd2UgaGF2ZSAKdmFsaWQgYml0Cml0IHdvdWxkIGJlIGJl dHRlciB0byBpbml0IHRoZSBvdGhlciBmaWVsZHMgYW5kIHVzaW5nIGxlc3MgcGFyYW1ldGVycyAK Zm9yIHRoaXMgZnVuY3Rpb24/CgpSZWdhcmRzLAotSmFja2llCgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==