Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3D0896E13A for ; Wed, 20 Jan 2021 07:05:29 +0000 (UTC) From: "Gupta, Anshuman" Date: Wed, 20 Jan 2021 07:05:24 +0000 Message-ID: References: <20210118114810.478581-1-jigar.bhatt@intel.com> In-Reply-To: <20210118114810.478581-1-jigar.bhatt@intel.com> Content-Language: en-US MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/i915_pm_dc: Validate display enters to DC9 state List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Bhatt, Jigar" , "igt-dev@lists.freedesktop.org" List-ID: > -----Original Message----- > From: Bhatt, Jigar > Sent: Monday, January 18, 2021 5:18 PM > To: igt-dev@lists.freedesktop.org > Cc: Bhatt, Jigar ; Shankar, Uma > ; Gupta, Anshuman > > Subject: [PATCH i-g-t] tests/i915/i915_pm_dc: Validate display enters to > DC9 state I would name this patch as Add DC9 igt test > > From: jbhatt > > Signed-off-by: jbhatt > --- > tests/i915/i915_pm_dc.c | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c index > 30c6024..679ac94 100644 > --- a/tests/i915/i915_pm_dc.c > +++ b/tests/i915/i915_pm_dc.c > @@ -384,6 +384,25 @@ static void test_dc_state_dpms(data_t *data, int > dc_flag) > cleanup_dc_dpms(data); > } > > +static bool check_dc9(uint32_t debugfs_fd, int prev_dc5, int prev_dc6) > +{ > + char buf[4096]; > + char *str; > + igt_debugfs_simple_read(debugfs_fd, "i915_pm_req_res_info", buf, > sizeof(buf)); Please add a check to the return value by igt_debugfs_simple_read, in case debugfs is not Present skip the test. > + str = strstr(buf, "DC9 Ready = "); str = strstr(buf, "DC9 Ready = yes"); and assert on str would avoid below operation ? > + igt_assert_f((str&&strlen(str)>12&&str[12]=='y'&&strstr(str,"yes")), > "Not in DC9 ready\n"); Please use correct message DC9 is not ready, and add a comment below since we do not have DC9 Counter so we rely on dc5/dc6 counter reset to check if Display Engine was in DC9. > + return igt_wait((read_dc_counter(debugfs_fd, > +CHECK_DC5)>prev_dc5 || read_dc_counter(debugfs_fd, > +CHECK_DC6)>prev_dc6),3000,100); } static void test_dc9_dpms(data_t > +*data) { > + require_dc_counter(data->debugfs_fd, CHECK_DC5); > + require_dc_counter(data->debugfs_fd, CHECK_DC6); > + int dc5_prev=read_dc_counter(data->debugfs_fd, CHECK_DC5); > + int dc6_prev=read_dc_counter(data->debugfs_fd, CHECK_DC6); > + dpms_off(data); > + igt_assert_f(check_dc9(data->debugfs_fd,dc5_prev,dc6_prev),"\n > Not in DC9"); > + dpms_on(data); > +} > IGT_TEST_DESCRIPTION("These tests validate Display Power DC states"); > int main(int argc, char *argv[]) { @@ -449,6 +468,10 @@ int main(int argc, > char *argv[]) > test_dc_state_dpms(&data, CHECK_DC6); > } > > + igt_describe("This test validates display engine entry to DC9 state"); > + igt_subtest("dc9-dpms") { > + test_dc9_dpms(&data); > + } > igt_fixture { > free(data.pwr_dmn_info); > close(data.debugfs_fd); > -- > 2.8.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev