References: <1480466372-2396-1-git-send-email-selva.nair@...277...> <201611301858.uAUIwRPD071804@...2054...> From: Arne Schwabe Message-ID: Date: Wed, 30 Nov 2016 23:06:02 +0100 MIME-Version: 1.0 In-Reply-To: <201611301858.uAUIwRPD071804@...2054...> Subject: Re: [Openvpn-devel] [PATCH applied] Re: Force 'def1' method when --redirect-gateway is done through service List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Gert Doering , Selva Nair Cc: openvpn-devel@lists.sourceforge.net Am 30.11.16 um 19:58 schrieb Gert Doering: > ACK, thanks. > > The patch does what we agreed on in the trac ticket ("no user changes" > for the normal case, and "in the service pipe change, imply def1 if > no flags set"). This is very little extra code and easily checked, > while fixing this in other ways would need much more code - for a sort-of > historic approach to routing table handling (we really shouldn't be > *removing* other people's routes, and we don't do that for IPv6 either). > > Semi-ACK on the approach from Arne ("that's what we do on Android") :-) Slight correction. We actually set 0.0.0.0/0 on Android but Android *always* translates that into a 0.0.0.0/1 and a 128.0.0.0/1 rule. We could do the same and do the translation in the interactive service instead of OpenVPN itself. Arne