From: =?UTF-8?Q?Andr=c3=a9_Przywara?= Date: Fri, 8 Jan 2021 22:07:13 +0000 Subject: [PATCH v1] sunxi: board: Move USB ethernet initialization to board_late_init() In-Reply-To: <20201208154531.55150-1-andriy.shevchenko@linux.intel.com> References: <20201208154531.55150-1-andriy.shevchenko@linux.intel.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/12/2020 15:45, Andy Shevchenko wrote: Hi, > For the sake of consistency (*) and order of initialization, i.e. > after we have got the ethernet address, interrupt and timer initialized, > try to initialize USB ethernet gadget. > > *) for example, zynqmp uses same order. > > Signed-off-by: Andy Shevchenko Reviewed-by: Andre Przywara Tested-by: Andre Przywara I tried on: Pine64-LTS, Pine H64, OrangePi Zero, Banana Pi M1. Could do TFTP correctly. Also compared the MAC addresses before and after. I will queue this for the merge window, to get some more exposure. Cheers, Andre > --- > arch/arm/Kconfig | 1 + > board/sunxi/board.c | 5 +++++ > 2 files changed, 6 insertions(+) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 5903c093705a..3d9be8a7507e 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1045,6 +1045,7 @@ config ARCH_SUNXI > select SPL_USE_TINY_PRINTF > select USE_PREBOOT > select SYS_RELOC_GD_ENV_ADDR > + imply BOARD_LATE_INIT > imply CMD_DM > imply CMD_GPT > imply CMD_UBI if MTD_RAW_NAND > diff --git a/board/sunxi/board.c b/board/sunxi/board.c > index 708a27ed78e9..77e464718846 100644 > --- a/board/sunxi/board.c > +++ b/board/sunxi/board.c > @@ -890,6 +890,11 @@ int misc_init_r(void) > > setup_environment(gd->fdt_blob); > > + return 0; > +} > + > +int board_late_init(void) > +{ > #ifdef CONFIG_USB_ETHER > usb_ether_init(); > #endif >