Message-ID: Date: Mon, 8 Jul 2024 23:49:25 +0200 MIME-Version: 1.0 References: <20240708210912.566-1-chipitsine@...277...> <20240708210912.566-2-chipitsine@...277...> <5b9f85fd-dcd1-463a-bb0f-9cc3a9081116@...2181...> Content-Language: en-US From: Antonio Quartulli In-Reply-To: Subject: Re: [Openvpn-devel] [PATCH 1/5] src/openvpn/init.c: handle strdup failures List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit To: =?UTF-8?B?0JjQu9GM0Y8g0KjQuNC/0LjRhtC40L0=?= Cc: openvpn-devel@lists.sourceforge.net Hi, On 08/07/2024 23:44, Илья Шипицин wrote: >>> + msg( M_FATAL, "Failed allocate memory saved_pid_file_name"); >> >> patchset looks great, but (!!) there should be no space after the >> opening parenthesis.. > > I just followed code style already present in repo > > $ grep -r 'msg( M_FATAL' . > grep: ./.git/objects/pack/pack-d09f3eabac42224b1dc52ffb4f53d9af23bc5b7d.pack: > binary file matches > ./src/openvpn/auth_token.c: msg( M_FATAL, "Failed to get enough > randomness for " > ./src/openvpn/tun.c: msg( M_FATAL, "init_tun: problem > converting IPv6 ifconfig addresses %s and %s to binary", > ifconfig_ipv6_local_parm, ifconfig_ipv6_remote_parm ); > ./src/openvpn/tun.c: msg( M_FATAL, "cannot find unused tap device" ); > ./src/openvpn/tun.c: msg( M_FATAL, "TAP device name must be > '--dev tapNNNN'" ); Unfortunately those are unlucky leftovers that haven't been fixed yet: $ grep -r 'msg(M_FATAL' . |wc -l 286 $ grep -r 'msg( M_FATAL' . |wc -l 4 > > also, uncrustify GHA jobs agreed that it is no formatting violation doubly unfortunate as I think uncrustify can't force this or it gets confused somehow :( Cheers, -- Antonio Quartulli