Content-Type: multipart/mixed; boundary="===============5526497842018733756==" MIME-Version: 1.0 From: Jason Wang To: kbuild-all@lists.01.org Subject: Re: [PATCH 4/6] vhost_vdpa: support doorbell mapping via mmap Date: Tue, 02 Jun 2020 14:49:38 +0800 Message-ID: In-Reply-To: <20200602005007-mutt-send-email-mst@kernel.org> List-Id: --===============5526497842018733756== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 2020/6/2 =E4=B8=8B=E5=8D=8812:56, Michael S. Tsirkin wrote: > On Tue, Jun 02, 2020 at 03:22:49AM +0800, kbuild test robot wrote: >> Hi Jason, >> >> I love your patch! Yet something to improve: >> >> [auto build test ERROR on vhost/linux-next] >> [also build test ERROR on linus/master v5.7 next-20200529] >> [if your patch is applied to the wrong git tree, please drop us a note t= o help >> improve the system. BTW, we also suggest to use '--base' option to speci= fy the >> base tree in git format-patch, please seehttps://stackoverflow.com/a/374= 06982] >> >> url:https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-doorbell-ma= pping/20200531-070834 >> base:https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linu= x-next >> config: m68k-randconfig-r011-20200601 (attached as .config) >> compiler: m68k-linux-gcc (GCC) 9.3.0 >> reproduce (this is a W=3D1 build): >> wgethttps://raw.githubusercontent.com/intel/lkp-tests/master/sb= in/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # save the attached .config to linux build tree >> COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-9.3.0 make.cr= oss ARCH=3Dm68k >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kbuild test robot >> >> All errors (new ones prefixed by >>, old ones prefixed by <<): >> >> drivers/vhost/vdpa.c: In function 'vhost_vdpa_fault': >>>> drivers/vhost/vdpa.c:754:22: error: implicit declaration of function '= pgprot_noncached' [-Werror=3Dimplicit-function-declaration] >> 754 | vma->vm_page_prot =3D pgprot_noncached(vma->vm_page_prot); >> | ^~~~~~~~~~~~~~~~ >>>> drivers/vhost/vdpa.c:754:22: error: incompatible types when assigning = to type 'pgprot_t' {aka 'struct '} from type 'int' >> cc1: some warnings being treated as errors >> >> vim +/pgprot_noncached +754 drivers/vhost/vdpa.c >> >> 742 = >> 743 static vm_fault_t vhost_vdpa_fault(struct vm_fault *vmf) >> 744 { >> 745 struct vhost_vdpa *v =3D vmf->vma->vm_file->private_data; >> 746 struct vdpa_device *vdpa =3D v->vdpa; >> 747 const struct vdpa_config_ops *ops =3D vdpa->config; >> 748 struct vdpa_notification_area notify; >> 749 struct vm_area_struct *vma =3D vmf->vma; >> 750 u16 index =3D vma->vm_pgoff; >> 751 = >> 752 notify =3D ops->get_vq_notification(vdpa, index); >> 753 = >> > 754 vma->vm_page_prot =3D pgprot_noncached(vma->vm_page_prot); >> 755 if (remap_pfn_range(vma, vmf->address & PAGE_MASK, >> 756 notify.addr >> PAGE_SHIFT, PAGE_SIZE, >> 757 vma->vm_page_prot)) >> 758 return VM_FAULT_SIGBUS; >> 759 = >> 760 return VM_FAULT_NOPAGE; >> 761 } >> 762 = > Yes well, all this remapping clearly has no chance to work > on systems without CONFIG_MMU. It looks to me mmap can work according to Documentation/nommu-mmap.txt. = But I'm not sure it's worth to bother. Thanks > > > --===============5526497842018733756==--