From: "flichtenheld (Code Review)" Date: Wed, 17 Dec 2025 14:26:05 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., matthias.andree@...68..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="GfCyDcz/n9I="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: ssl_verify_openssl: Avoid conversion warning in x509_verify_cert_ku List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mandree , plaisthos , openvpn-devel --GfCyDcz/n9I= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: mandree, plaisthos. flichtenheld has posted comments on this change by flichtenheld. ( http://g= errit.openvpn.net/c/openvpn/+/1445?usp=3Demail ) Change subject: ssl_verify_openssl: Avoid conversion warning in x509_verify= _cert_ku ...................................................................... Patch Set 2: (3 comments) File src/openvpn/ssl_verify_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1445/comment/daf21b8d_ebd343a0?usp=3D= email : PS1, Line 678: x509_verify_cert_ku(X509 *x509, const unsigned *const expect= ed_ku, int expected_len) > expected_len might be an unsigned int or size_t to fix warnings below. Done http://gerrit.openvpn.net/c/openvpn/+/1445/comment/c6d817b4_b71d7230?usp=3D= email : PS1, Line 714: for (int i =3D 0; fFound !=3D SUCCESS && i < expected_le= n; i++) > If this triggers a signed/unsigned mismatch on the < - that's because the= iterator was a size_t and [=E2=80=A6] Done http://gerrit.openvpn.net/c/openvpn/+/1445/comment/f6912297_5457cc36?usp=3D= email : PS1, Line 725: for (int i =3D 0; i < expected_len && expected_ku[i]= ; i++) > If this triggers a signed/unsigned mismatch on the < - that's because the= iterator was a size_t and [=E2=80=A6] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1445?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia6c3f0395bd6cd67064fe77420d9df2b66763049 Gerrit-Change-Number: 1445 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: mandree Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: mandree Gerrit-Comment-Date: Wed, 17 Dec 2025 14:26:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: mandree --GfCyDcz/n9I= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: mandree, plaisthos.

View = Change

3 comments:

  • File src/openvpn/ssl_verify_openss= l.c:

    • P= atch Set #1, Line 678: = x509_verify_cert_ku(X509 *x509, const unsigned *const expected_ku, int expe= cted_len)

      expected_len might be an unsigned int or si= ze_t to fix warnings below.

      Done

    • Patch Set #1, Line 714: for (int i =3D 0; fFound !=3D SUCCESS && i < expected_= len; i++)

      If this triggers a signed/unsigned mismatch= on the < - that's because the iterator was a size_t and [=E2=80=A6= ]

      Done

    • Patch Set #1, Line 72= 5: for (int i = =3D 0; i < expected_len && expected_ku[i]; i++)

      If this triggers a signed/unsigned mismatch on the < - that's = because the iterator was a size_t and [=E2=80=A6]

      Done

To view, visit change 1445. To unsubscribe, or for help= writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia6c3f0395bd6cd67064fe77420d= 9df2b66763049
Gerrit-Change-Number: 1445
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: mandree <matthias.andree@...220...= ..68...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: mandree <matthias.andree@= ...68...>
Gerrit-Comment-Date: Wed, 17 Dec 2025 14:26:05= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: mandree <matthias.andr= ee@...68...>
= --GfCyDcz/n9I=--