Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iFEI3-0006RP-Ls for mharc-qemu-trivial@gnu.org; Tue, 01 Oct 2019 05:17:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34018) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFEHz-0006Py-IA for qemu-trivial@nongnu.org; Tue, 01 Oct 2019 05:17:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFEHx-0004ua-5I for qemu-trivial@nongnu.org; Tue, 01 Oct 2019 05:17:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55946) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iFEHw-0004u2-HX for qemu-trivial@nongnu.org; Tue, 01 Oct 2019 05:17:44 -0400 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8879B83F42 for ; Tue, 1 Oct 2019 09:17:43 +0000 (UTC) Received: by mail-wm1-f71.google.com with SMTP id f63so643868wma.7 for ; Tue, 01 Oct 2019 02:17:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3m+wOPB/Fkr6AYXJ+FLLgauwXMN+ekeAdaB8/8pXDp8=; b=E0blO8aZMrLwO9Vn7FeyJFYi9q73oAWn742NTH1XcdqwC4pjRno5OYwaX56vrvFSKy DYLnt5xzt0ytj0pS3DPpAPJG+cEqN9wpzSro14OYDqzgDaBgpKaJWikKCzhIIaXzXTPV L+Oj4eef50JEQlM4m1RtJ+RQvBjK4wX8QWrQGaYBl0DG8NTEyVoo+9fEdRyKJIxCeowb ThR8xPENXZ+tD2wD1W0Wxk1CVMxiRigJiF2OeXbXJOpwT0xxlc/T+I5Woc6KAJCGMj40 LZBUwNKpMYFXheBe/iPajnEC7ftUkFy80Vlbs7Pq9Dq0nSn5sEfXt/FS7HIoCzq9tCf6 MW0Q== X-Gm-Message-State: APjAAAX6gGRPsGHJEnIIrJzWverYjn0q+vv68FlaKufP/UqwsmG1azYp Gz7lW7NhjoxA3/w3noW/HkjzuMQXaL4hXPt38mi5uuK6Bt4/wMYqFmwqQx+FSQlPxGo8qJIvdVn JTihxdliYZICnVjNyCg== X-Received: by 2002:a05:600c:230d:: with SMTP id 13mr2938093wmo.114.1569921461726; Tue, 01 Oct 2019 02:17:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqzkcqWlJS7X/0FaFvdZuG9LZwHalBKRMfrHPzNttEc2gjLy9181xgM51CNQIOtFuaWqEh0D0w== X-Received: by 2002:a05:600c:230d:: with SMTP id 13mr2938078wmo.114.1569921461447; Tue, 01 Oct 2019 02:17:41 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:b903:6d6f:a447:e464? ([2001:b07:6468:f312:b903:6d6f:a447:e464]) by smtp.gmail.com with ESMTPSA id z3sm1859334wmi.30.2019.10.01.02.17.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Oct 2019 02:17:40 -0700 (PDT) Subject: Re: [PATCH] hw/isa: Introduce a CONFIG_ISA_SUPERIO switch for isa-superio.c To: Thomas Huth , qemu-devel@nongnu.org, "Michael S . Tsirkin" Cc: qemu-trivial@nongnu.org, Aurelien Jarno , Aleksandar Rikalo , Richard Henderson , Aleksandar Markovic , =?UTF-8?Q?Herv=c3=a9_Poussineau?= References: <20190930150436.18162-1-thuth@redhat.com> From: Paolo Bonzini Openpgp: preference=signencrypt Message-ID: Date: Tue, 1 Oct 2019 11:17:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190930150436.18162-1-thuth@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Oct 2019 09:17:49 -0000 On 30/09/19 17:04, Thomas Huth wrote: > Currently, isa-superio.c is always compiled as soon as CONFIG_ISA_BUS > is enabled. But there are also machines that have an ISA BUS without > any of the superio chips attached to it, so we should not compile > isa-superio.c in case we only compile a QEMU for such a machine. > Thus add a proper CONFIG_ISA_SUPERIO switch so that this file only gets > compiled when we really, really need it. > > Signed-off-by: Thomas Huth > --- > hw/isa/Kconfig | 10 +++++++--- > hw/isa/Makefile.objs | 2 +- > hw/mips/Kconfig | 1 + > 3 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig > index 6db0d7970c..98a289957e 100644 > --- a/hw/isa/Kconfig > +++ b/hw/isa/Kconfig > @@ -13,9 +13,13 @@ config I82378 > select MC146818RTC > select PCSPK > > -config PC87312 > +config ISA_SUPERIO > bool > select ISA_BUS > + > +config PC87312 > + bool > + select ISA_SUPERIO > select I8259 > select I8254 > select I8257 > @@ -34,14 +38,14 @@ config PIIX4 > > config VT82C686 > bool > - select ISA_BUS > + select ISA_SUPERIO > select ACPI_SMBUS > select SERIAL_ISA > select FDC > > config SMC37C669 > bool > - select ISA_BUS > + select ISA_SUPERIO > select SERIAL_ISA > select PARALLEL > select FDC > diff --git a/hw/isa/Makefile.objs b/hw/isa/Makefile.objs > index 9e106df186..ff97485504 100644 > --- a/hw/isa/Makefile.objs > +++ b/hw/isa/Makefile.objs > @@ -1,5 +1,5 @@ > common-obj-$(CONFIG_ISA_BUS) += isa-bus.o > -common-obj-$(CONFIG_ISA_BUS) += isa-superio.o > +common-obj-$(CONFIG_ISA_SUPERIO) += isa-superio.o > common-obj-$(CONFIG_APM) += apm.o > common-obj-$(CONFIG_I82378) += i82378.o > common-obj-$(CONFIG_PC87312) += pc87312.o > diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig > index 62aa01b29e..2c2adbc42a 100644 > --- a/hw/mips/Kconfig > +++ b/hw/mips/Kconfig > @@ -13,6 +13,7 @@ config R4K > > config MALTA > bool > + select ISA_SUPERIO > > config MIPSSIM > bool > Queued, thanks. Paolo