Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1p8nTy-0003nO-Ns for mharc-grub-devel@gnu.org; Fri, 23 Dec 2022 14:13:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8nTx-0003n8-AE for grub-devel@gnu.org; Fri, 23 Dec 2022 14:13:25 -0500 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p8nTv-0003XK-SM for grub-devel@gnu.org; Fri, 23 Dec 2022 14:13:25 -0500 Received: by mail-pg1-x534.google.com with SMTP id v3so3835323pgh.4 for ; Fri, 23 Dec 2022 11:13:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=fKB+yMXa18wBRloy2XIndEsKUuZgqHCkwi5VBvX9oZU=; b=jEiYH3IHt0m5L7SaV7yMFtUr0ovkeuG0T72SCMVXDKEu0aLUy9xc+UDvgCKHPLLLh3 GvQmMdwrTQrg1R3MMDq4cv3dGBXbpDqyfOvMtCmayu/cieVHl7f92l7IYKh0WIKVaBWy NtA7C4pOQj8vtEJ/tl9plRddigrrU9cv7CJ8x9OMSlOVnDb1foMmXTbXBE++su9mUE/h WxByoSjKJvebM/7qLhQN1FBWGOgFLcAgHiNe7M/kjhURBLm0hqjmHmUpQ9hrTcFE5t+n FLZFTwuXHZIS0/8q73L89YGABVgBLutWs2gBFgDrBf4sQSnnYhuzCs1qLd1V1f5zyIzR P6kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fKB+yMXa18wBRloy2XIndEsKUuZgqHCkwi5VBvX9oZU=; b=tTn2Y5nsiRspjkEQEVS4uBJ4uiR03cEuOwIR6hzVlqJZYuWjFqtIYPNaXkOwaDWeA2 3J1L3UqtA/AB2xKpHlNg9ZLJb+4UDJcL9o8Jt2vnxx5vvhJLgKwH/EWWDOxiSvYwWqB5 fBqHo6wwlwjzI0cU5hzyBBGw//CFmWLsCO7yviWRTpHEa08rna8i/nFRx9M6g+KcWx2C oXDvzQHTRvXQaXDwP0OU2IQcbxvkyRDJNa7LWiZ/+6B3Lg0+Fobss3gkkSsAyfBfD2D3 n6navGbJR0OLbRKw4Z4xUXW1L2ka2KuX15P7jkQg+k+u+yqMdq7oBYFF8vPuBaFc8Qe7 MqkA== X-Gm-Message-State: AFqh2kqW9LAAp5a7GdUUCG6U/ehgVjO1zc0j0PLuR4K99g8pYg4/D0XQ GATbBG4DBoLFq7hrWV52ye4= X-Google-Smtp-Source: AMrXdXvivK0ZgPe1Flfxeth2khqJbRQtFGKHh/NQ8ON/aSy08ldV0dM4bdETuIMmfo3VqUZcQE3mKw== X-Received: by 2002:a05:6a00:f04:b0:56b:f127:f21f with SMTP id cr4-20020a056a000f0400b0056bf127f21fmr10786784pfb.13.1671822802499; Fri, 23 Dec 2022 11:13:22 -0800 (PST) Received: from [0.0.0.0] (ec2-13-113-80-70.ap-northeast-1.compute.amazonaws.com. [13.113.80.70]) by smtp.gmail.com with ESMTPSA id u124-20020a626082000000b0057682f44f8bsm2784679pfb.220.2022.12.23.11.13.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Dec 2022 11:13:22 -0800 (PST) Message-ID: Date: Sat, 24 Dec 2022 03:13:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH v3 0/1] kern/dl: Add module version check From: Zhang Boyang To: Pete Batard , grub-devel@gnu.org Cc: development@efficientek.com, rharwood@redhat.com, scdbackup@gmx.net, didier@slint.fr, dkiper@net-space.pl References: <7c0fa62f-89eb-cfb5-8e99-bd9661ef6912@gmail.com> <1f92f33b-61cd-599d-a0b2-aa9824925f01@akeo.ie> <89d5fa09-8294-5493-1524-22f1c084eee9@gmail.com> <871969b8-cc0f-1014-cc49-dd632d09a8c9@gmail.com> Content-Language: en-US In-Reply-To: <871969b8-cc0f-1014-cc49-dd632d09a8c9@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::534; envelope-from=zhangboyang.id@gmail.com; helo=mail-pg1-x534.google.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-1.148, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2022 19:13:25 -0000 On 2022/12/24 00:44, Zhang Boyang wrote: > -      || grub_dl_check_version (mod, e) > +      || (1||grub_dl_check_version (mod, e)) Oh, there is a small error, it should be: - || grub_dl_check_version (mod, e) + || (0 && grub_dl_check_version (mod, e)) Best Regards, Zhang Boyang