From: "Souza, Jose" Subject: Re: [PATCH v4 2/5] drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink Date: Thu, 14 Jun 2018 23:46:48 +0000 Message-ID: References: <20180614203433.5602-1-jose.souza@intel.com> <20180614203433.5602-2-jose.souza@intel.com> <20180614210934.GW8374@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 343276E159 for ; Thu, 14 Jun 2018 23:46:50 +0000 (UTC) In-Reply-To: <20180614210934.GW8374@intel.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Vivi, Rodrigo" Cc: "intel-gfx@lists.freedesktop.org" , "Pandiyan, Dhinakaran" List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAyMDE4LTA2LTE0IGF0IDE0OjA5IC0wNzAwLCBSb2RyaWdvIFZpdmkgd3JvdGU6DQo+ IE9uIFRodSwgSnVuIDE0LCAyMDE4IGF0IDAxOjM0OjMwUE0gLTA3MDAsIEpvc8OpIFJvYmVydG8g ZGUgU291emENCj4gd3JvdGU6DQo+ID4gZURQIHNwZWMgc3RhdGVzIHRoYXQgc2luayBkZXZpY2Ug d2lsbCBkbyBhIHNob3J0IHB1bHNlIGluIEhQRA0KPiA+IGxpbmUgd2hlbiB0aGVyZSBpcyBhIFBT Ui9QU1IyIGVycm9yIHRoYXQgbmVlZHMgdG8gYmUgaGFuZGxlZCBieQ0KPiA+IHNvdXJjZSwgdGhp cyBpcyBoYW5kbGluZyB0aGUgZmlyc3QgYW5kIG1vc3Qgc2ltcGxlcyBlcnJvcjoNCj4gPiBEUF9Q U1JfU0lOS19JTlRFUk5BTF9FUlJPUi4NCj4gPiANCj4gPiBIZXJlIHRha2luZyB0aGUgc2FmZXN0 IGFwcHJvYWNoIGFuZCBkaXNhYmxpbmcgUFNSKGF0IGxlYXN0IHVudGlsDQo+ID4gdGhlIG5leHQg bW9kZXNldCksIHRvIGF2b2lkIG11bHRpcGxlIHJlbmRlcmluZyBpc3N1ZXMgZHVlIHRvDQo+ID4g YmFkIHBhbm5lbHMuDQo+ID4gDQo+ID4gdjQ6DQo+ID4gVXNpbmcgQ0FOX1BTUiBpbnN0ZWFkIG9m IEhBU19QU1IgaW4gaW50ZWxfcHNyX3Nob3J0X3B1bHNlDQo+ID4gDQo+ID4gdjM6DQo+ID4gZGlz YWJsaW5nIFBTUiBpbnN0ZWFkIG9mIGV4aXRpbmcgb24gZXJyb3INCj4gPiANCj4gPiBDYzogRGhp bmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+DQo+ID4gQ2M6 IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4NCj4gPiBTaWduZWQtb2ZmLWJ5 OiBKb3PDqSBSb2JlcnRvIGRlIFNvdXphIDxqb3NlLnNvdXphQGludGVsLmNvbT4NCj4gPiAtLS0N Cj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyAgfCAgMiArKw0KPiA+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCB8ICAxICsNCj4gPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcHNyLmMgfCA2MCArKysrKysrKysrKysrKysrKysrKysrKysrKw0KPiA+IC0t LS0tLQ0KPiA+ICAzIGZpbGVzIGNoYW5nZWQsIDUyIGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9u cygtKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cC5jDQo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jDQo+ID4gaW5kZXggNjc4 NzViMDBjOGRmLi4xOTU4NTUyM2U0Y2UgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHAuYw0KPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw LmMNCj4gPiBAQCAtNDQ3NCw2ICs0NDc0LDggQEAgaW50ZWxfZHBfc2hvcnRfcHVsc2Uoc3RydWN0 IGludGVsX2RwDQo+ID4gKmludGVsX2RwKQ0KPiA+ICAJaWYgKGludGVsX2RwX25lZWRzX2xpbmtf cmV0cmFpbihpbnRlbF9kcCkpDQo+ID4gIAkJcmV0dXJuIGZhbHNlOw0KPiA+ICANCj4gPiArCWlu dGVsX3Bzcl9zaG9ydF9wdWxzZShpbnRlbF9kcCk7DQo+ID4gKw0KPiA+ICAJaWYgKGludGVsX2Rw LT5jb21wbGlhbmNlLnRlc3RfdHlwZSA9PQ0KPiA+IERQX1RFU1RfTElOS19UUkFJTklORykgew0K PiA+ICAJCURSTV9ERUJVR19LTVMoIkxpbmsgVHJhaW5pbmcgQ29tcGxpYW5jZSBUZXN0DQo+ID4g cmVxdWVzdGVkXG4iKTsNCj4gPiAgCQkvKiBTZW5kIGEgSG90cGx1ZyBVZXZlbnQgdG8gdXNlcnNw YWNlIHRvIHN0YXJ0DQo+ID4gbW9kZXNldCAqLw0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcnYuaA0KPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHJ2LmgNCj4gPiBpbmRleCA4ODQwMTA4NzQ5YTUuLmJiNmZmZGIyODJmZCAxMDA2NDQNCj4gPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaA0KPiA+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rydi5oDQo+ID4gQEAgLTE5MjYsNiArMTkyNiw3IEBAIHZvaWQg aW50ZWxfcHNyX2NvbXB1dGVfY29uZmlnKHN0cnVjdCBpbnRlbF9kcA0KPiA+ICppbnRlbF9kcCwN Cj4gPiAgCQkJICAgICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUNCj4gPiAqY3J0Y19zdGF0ZSk7 DQo+ID4gIHZvaWQgaW50ZWxfcHNyX2lycV9jb250cm9sKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwgYm9vbA0KPiA+IGRlYnVnKTsNCj4gPiAgdm9pZCBpbnRlbF9wc3JfaXJxX2hh bmRsZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzINCj4gPiBwc3JfaWly KTsNCj4gPiArdm9pZCBpbnRlbF9wc3Jfc2hvcnRfcHVsc2Uoc3RydWN0IGludGVsX2RwICppbnRl bF9kcCk7DQo+ID4gIA0KPiA+ICAvKiBpbnRlbF9ydW50aW1lX3BtLmMgKi8NCj4gPiAgaW50IGlu dGVsX3Bvd2VyX2RvbWFpbnNfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqKTsNCj4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMNCj4gPiBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jDQo+ID4gaW5kZXggYmM2ZDU0ZjY3N2RjLi5hZjVm Y2ZkOThhNTMgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNy LmMNCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYw0KPiA+IEBAIC03 MjAsNiArNzIwLDIzIEBAIHN0YXRpYyB2b2lkIGhzd19wc3JfZGlzYWJsZShzdHJ1Y3QgaW50ZWxf ZHANCj4gPiAqaW50ZWxfZHApDQo+ID4gIAlwc3JfYXV4X2lvX3Bvd2VyX3B1dChpbnRlbF9kcCk7 DQo+ID4gIH0NCj4gPiAgDQo+ID4gK3N0YXRpYyB2b2lkIHBzcl9kaXNhYmxlKHN0cnVjdCBpbnRl bF9kcCAqaW50ZWxfZHApDQo+IA0KPiB3aGF0IGFib3V0IGludGVsX3Bzcl9kaXNhYmxlX3VubG9j a2VkKCk/DQoNCnVubG9ja2VkPyBzaG91bGRuJ3QgYmUgbG9ja2VkPw0KSSdtIG9rYXkgaW4gYWRk aW5nIHRoZSBzdWZmaXggYnV0IGl0IHdpbGwgYmUgZGlmZmVyZW50IHRoYW4gdGhlIG90aGVyDQpm dW5jdGlvbnMgaW4gdGhpcyBmaWxlLg0KDQo+IA0KPiA+ICt7DQo+ID4gKwlzdHJ1Y3QgaW50ZWxf ZGlnaXRhbF9wb3J0ICppbnRlbF9kaWdfcG9ydCA9DQo+ID4gZHBfdG9fZGlnX3BvcnQoaW50ZWxf ZHApOw0KPiA+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2RpZ19wb3J0LT5iYXNl LmJhc2UuZGV2Ow0KPiA+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9f aTkxNShkZXYpOw0KPiANCj4gYXNzZXJ0IGl0IGlzIGxvY2tlZCBoZXJlLi4uDQoNCkRvbmUNCg0K PiANCj4gPiArDQo+ID4gKwlpZiAoIWRldl9wcml2LT5wc3IuZW5hYmxlZCkNCj4gPiArCQlyZXR1 cm47DQo+ID4gKw0KPiA+ICsJZGV2X3ByaXYtPnBzci5kaXNhYmxlX3NvdXJjZShpbnRlbF9kcCk7 DQo+ID4gKw0KPiA+ICsJLyogRGlzYWJsZSBQU1Igb24gU2luayAqLw0KPiA+ICsJZHJtX2RwX2Rw Y2Rfd3JpdGViKCZpbnRlbF9kcC0+YXV4LCBEUF9QU1JfRU5fQ0ZHLCAwKTsNCj4gPiArDQo+ID4g KwlkZXZfcHJpdi0+cHNyLmVuYWJsZWQgPSBOVUxMOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICAvKioN Cj4gPiAgICogaW50ZWxfcHNyX2Rpc2FibGUgLSBEaXNhYmxlIFBTUg0KPiA+ICAgKiBAaW50ZWxf ZHA6IEludGVsIERQDQo+ID4gQEAgLTc0MSwxNyArNzU4LDcgQEAgdm9pZCBpbnRlbF9wc3JfZGlz YWJsZShzdHJ1Y3QgaW50ZWxfZHANCj4gPiAqaW50ZWxfZHAsDQo+ID4gIAkJcmV0dXJuOw0KPiA+ ICANCj4gPiAgCW11dGV4X2xvY2soJmRldl9wcml2LT5wc3IubG9jayk7DQo+ID4gLQlpZiAoIWRl dl9wcml2LT5wc3IuZW5hYmxlZCkgew0KPiA+IC0JCW11dGV4X3VubG9jaygmZGV2X3ByaXYtPnBz ci5sb2NrKTsNCj4gPiAtCQlyZXR1cm47DQo+ID4gLQl9DQo+ID4gLQ0KPiA+IC0JZGV2X3ByaXYt PnBzci5kaXNhYmxlX3NvdXJjZShpbnRlbF9kcCk7DQo+ID4gLQ0KPiA+IC0JLyogRGlzYWJsZSBQ U1Igb24gU2luayAqLw0KPiA+IC0JZHJtX2RwX2RwY2Rfd3JpdGViKCZpbnRlbF9kcC0+YXV4LCBE UF9QU1JfRU5fQ0ZHLCAwKTsNCj4gPiAtDQo+ID4gLQlkZXZfcHJpdi0+cHNyLmVuYWJsZWQgPSBO VUxMOw0KPiA+ICsJcHNyX2Rpc2FibGUoaW50ZWxfZHApOw0KPiA+ICAJbXV0ZXhfdW5sb2NrKCZk ZXZfcHJpdi0+cHNyLmxvY2spOw0KPiA+ICB9DQo+ID4gIA0KPiA+IEBAIC05OTIsMyArOTk5LDM0 IEBAIHZvaWQgaW50ZWxfcHNyX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUNCj4gPiAqZGV2 X3ByaXYpDQo+ID4gIAlkZXZfcHJpdi0+cHNyLnNldHVwX3ZzYyA9IGhzd19wc3Jfc2V0dXBfdnNj Ow0KPiA+ICANCj4gPiAgfQ0KPiA+ICsNCj4gPiArdm9pZCBpbnRlbF9wc3Jfc2hvcnRfcHVsc2Uo c3RydWN0IGludGVsX2RwICppbnRlbF9kcCkNCj4gPiArew0KPiA+ICsJc3RydWN0IGludGVsX2Rp Z2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQgPQ0KPiA+IGRwX3RvX2RpZ19wb3J0KGludGVsX2Rw KTsNCj4gPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9kaWdfcG9ydC0+YmFzZS5i YXNlLmRldjsNCj4gPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5 MTUoZGV2KTsNCj4gPiArCXN0cnVjdCBpOTE1X3BzciAqcHNyID0gJmRldl9wcml2LT5wc3I7DQo+ ID4gKwl1aW50OF90IHZhbDsNCj4gPiArDQo+ID4gKwlpZiAoIUNBTl9QU1IoZGV2X3ByaXYpIHx8 ICFpbnRlbF9kcF9pc19lZHAoaW50ZWxfZHApKQ0KPiA+ICsJCXJldHVybjsNCj4gPiArDQo+ID4g KwltdXRleF9sb2NrKCZwc3ItPmxvY2spOw0KPiA+ICsNCj4gPiArCWlmIChwc3ItPmVuYWJsZWQg IT0gaW50ZWxfZHApDQo+ID4gKwkJZ290byBleGl0Ow0KPiA+ICsNCj4gPiArCWlmIChkcm1fZHBf ZHBjZF9yZWFkYigmaW50ZWxfZHAtPmF1eCwgRFBfUFNSX1NUQVRVUywgJnZhbCkNCj4gPiAhPSAx KSB7DQo+ID4gKwkJRFJNX0VSUk9SKCJQU1JfU1RBVFVTIGRwY2QgcmVhZCBmYWlsZWRcbiIpOw0K PiA+ICsJCWdvdG8gZXhpdDsNCj4gPiArCX0NCj4gPiArDQo+ID4gKwlpZiAoKHZhbCAmIERQX1BT Ul9TSU5LX1NUQVRFX01BU0spID09DQo+ID4gRFBfUFNSX1NJTktfSU5URVJOQUxfRVJST1IpIHsN Cj4gPiArCQlEUk1fREVCVUdfS01TKCJQU1Igc2luayBpbnRlcm5hbCBlcnJvciwgZGlzYWJsaW5n DQo+ID4gUFNSXG4iKTsNCj4gPiArCQlwc3JfZGlzYWJsZShpbnRlbF9kcCk7DQo+ID4gKwl9DQo+ ID4gKw0KPiA+ICsJLyogVE9ETzogaGFuZGxlIG90aGVyIFBTUi9QU1IyIGVycm9ycyAqLw0KPiA+ ICtleGl0Og0KPiA+ICsJbXV0ZXhfdW5sb2NrKCZwc3ItPmxvY2spOw0KPiA+ICt9DQo+ID4gLS0g DQo+ID4gMi4xNy4xDQo+ID4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=