Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kG0Bc-0003rz-Qc for mharc-qemu-trivial@gnu.org; Wed, 09 Sep 2020 09:30:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kG0BZ-0003nh-Ma; Wed, 09 Sep 2020 09:30:53 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:52795) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kG0BX-0005dL-SK; Wed, 09 Sep 2020 09:30:53 -0400 Received: from [192.168.100.1] ([82.252.148.206]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.103]) with ESMTPSA (Nemesis) id 1MNwXA-1jri2h3ADY-00OG8a; Wed, 09 Sep 2020 15:30:47 +0200 Subject: Re: [PATCH 2/2] hw/gpio/max7310: Replace disabled printf() by qemu_log_mask(UNIMP) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Peter Maydell , qemu-arm@nongnu.org, Andrzej Zaborowski References: <20200901104234.92159-1-f4bug@amsat.org> <20200901104234.92159-3-f4bug@amsat.org> From: Laurent Vivier Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: Date: Wed, 9 Sep 2020 15:30:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200901104234.92159-3-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:f30uoKL3byF7T+7ybgEjjlErwyvlXNo1LHlZCuRj+cx3QIB1A/C T1BKgJttLdPqJzwx/gVNwxMnxUITmuq42TSecD6v2exlZGOByQSFfHTOg5DnZ6oh3Hkj2F9 wJrQfqrawbaaRVDbGcoIRMHyATZKQC1mAmEvwZjSWcvORdNErWpqVwHgwgFefAOfBq3He4y QQzqfok1TKLRo2ra4+NTQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:wvFvDnsiVE8=:QZhKIzB2qDu0Y+cB57K8Vp nEyslDAHPPEJmpEBlJmyeCLJMtOZ3unWes07ErMfINvg2xFRXPjoTzZ0tObpLvo2Nl8/zD3SA YKrT1xX8Ebsgpy9qiaqjv4fQRaaqYS3CS7sinTFD9RdSkAGfLsRezAOxeAYcRtgHOJ42GBaOF mKK+JsO/CDGwB+XL2JFi2hPwhMeOQafEjICzPEeUaIeb8QbO6K/ucU9fLjNjkawzHFfmoe6fq VGLB/pUOaXXRVQ67M6+cAer85UKvoFKUzY/KFJbkzbzUGEsaIhEaaipEZRr3KgrxriBpnvB0S WzOtQYjVt+JtzvhiQHZFaJ/zU+p7jkAauYA2vvKFz3HFS55mNIHcHWOTaWguJ/3pZgyHkrAbw MLmEWUilo8I5vvp9aJ7/YeblAjx3b41S+Xl0aeHmhtjMxsCuEypIPJNyZ6+8zRA7QDd+923C7 /JReix25rT8B2nBeXK3L5et6T+63e/f6HvWvStIt7mVHAOVLzX+837BJqyeweZJRZOOfR3r9e jfFVlQspXfbcRsVhSd86NWvQrxoEj8WppJi/FapMrGu9pSCS9vqdYQk2qaRABEB5JDP2lXKlJ U46twBBPUt8MEIixi8WP3WQ5ESuGYtLAkqZEZgnc7UHHNiqKuVJ22VzRJni6BcTPrYQsv+lSV FBg6GWM5qR1bNZ3Jx0mGfGJUlxi/RBa2Ap1NW/+hkhqhjVFWTh1W0lpuDCQPwa1bH8j+co8Xp PIssm/MtzwPOEyoB0pAPT/sB91kWGM5uOJqOjqgvulnJjbAdZ1jKaYUnJvEJoX2h4SLqBYGdo oHsvDQ+yQYujbitJ+Up1zeJAvnLQlo1B7Va82I3cvGT//mGMMm8TAoTmXLvc0mib6VA5Tfh Received-SPF: none client-ip=212.227.126.131; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/09 09:27:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -54 X-Spam_score: -5.5 X-Spam_bar: ----- X-Spam_report: (-5.5 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-3.576, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Sep 2020 13:30:54 -0000 Le 01/09/2020 à 12:42, Philippe Mathieu-Daudé a écrit : > Replace disabled printf() by qemu_log_mask(UNIMP). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/gpio/max7310.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/hw/gpio/max7310.c b/hw/gpio/max7310.c > index 7f5de189acf..c58a1996418 100644 > --- a/hw/gpio/max7310.c > +++ b/hw/gpio/max7310.c > @@ -11,6 +11,7 @@ > #include "hw/i2c/i2c.h" > #include "hw/irq.h" > #include "migration/vmstate.h" > +#include "qemu/log.h" > #include "qemu/module.h" > > #define TYPE_MAX7310 "max7310" > @@ -69,9 +70,8 @@ static uint8_t max7310_rx(I2CSlave *i2c) > return 0xff; > > default: > -#ifdef VERBOSE > - printf("%s: unknown register %02x\n", __func__, s->command); > -#endif > + qemu_log_mask(LOG_UNIMP, "%s: Unsupported register 0x02%" PRIx8 "\n", > + __func__, s->command); > break; > } > return 0xff; > @@ -123,9 +123,8 @@ static int max7310_tx(I2CSlave *i2c, uint8_t data) > case 0x00: /* Input port - ignore writes */ > break; > default: > -#ifdef VERBOSE > - printf("%s: unknown register %02x\n", __func__, s->command); > -#endif > + qemu_log_mask(LOG_UNIMP, "%s: Unsupported register 0x02%" PRIx8 "\n", > + __func__, s->command); > return 1; > } > > Applied to my trivial-patches branch. Thanks, Laurent