From: Markus Elfring Date: Sun, 27 Oct 2019 06:55:15 +0000 Subject: Re: [PATCH] media: aspeed-video: Fix memory leaks in aspeed_video_probe Message-Id: List-Id: References: <20191026042519.29446-1-navid.emamdoost@gmail.com> In-Reply-To: <20191026042519.29446-1-navid.emamdoost@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Navid Emamdoost , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-media@vger.kernel.org, openbmc@lists.ozlabs.org Cc: kernel-janitors@vger.kernel.org, Andrew Jeffery , Kangjie Lu , Eddie James , LKML , Navid Emamdoost , Joel Stanley , Stephen McCamant , Mauro Carvalho Chehab … > +++ b/drivers/media/platform/aspeed-video.c > @@ -1663,18 +1663,24 @@ static int aspeed_video_probe(struct platform_device *pdev) … > +free_video: > + kfree(video); … I am curious if there is a need for such a memory release at another place. How do you think about to add this function call also to the implementation of the function “aspeed_video_remove”? Regards, Markus