From: Daniele Ceraolo Spurio Subject: Re: [PATCH 3/5] drm/i915/guc: Simplify intel_guc_load() Date: Fri, 16 Dec 2016 10:26:32 -0800 Message-ID: References: <20161215154708.31521-1-arkadiusz.hiler@intel.com> <20161215154708.31521-4-arkadiusz.hiler@intel.com> <20161216111602.GB27156@ahiler-desk.igk.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA8376EC19 for ; Fri, 16 Dec 2016 18:26:48 +0000 (UTC) In-Reply-To: <20161216111602.GB27156@ahiler-desk.igk.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Arkadiusz Hiler Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org PHNuaXA+Cgo+Pj4gKwo+Pj4gK2ZhaWw6Cj4+PiArCS8qCj4+PiArCSAqIFdlJ3ZlIGZhaWxlZCB0 byBsb2FkIHRoZSBmaXJtd2FyZSA6KAo+Pj4gKwkgKgo+Pj4gKwkgKiBEZWNpZGUgd2hldGhlciB0 byBkaXNhYmxlIEd1QyBzdWJtaXNzaW9uIGFuZCBmYWxsIGJhY2sgdG8KPj4+ICsJICogZXhlY2xp c3QgbW9kZSwgYW5kIHdoZXRoZXIgdG8gaGlkZSB0aGUgZXJyb3IgYnkgcmV0dXJuaW5nCj4+PiAr CSAqIHplcm8gb3IgdG8gcmV0dXJuIC1FSU8sIHdoaWNoIHRoZSBjYWxsZXIgd2lsbCB0cmVhdCBh cyBhCj4+PiArCSAqIG5vbmZhdGFsIGVycm9yIChpLmUuIGl0IGRvZXNuJ3QgcHJldmVudCBkcml2 ZXIgbG9hZCwgYnV0Cj4+PiArCSAqIG1hcmtzIHRoZSBHUFUgYXMgd2VkZ2VkIHVudGlsIHJlc2V0 KS4KPj4+ICsJICovCj4+PiArCWlmIChpOTE1LmVuYWJsZV9ndWNfbG9hZGluZyA+IDEgfHwgaTkx NS5lbmFibGVfZ3VjX3N1Ym1pc3Npb24gPiAxKQo+Pj4gKwkJcmV0ID0gLUVJTzsKPj4+ICsJZWxz ZQo+Pj4gKwkJcmV0ID0gMDsKPj4+ICsKPj4+ICsJaWYgKGk5MTUuZW5hYmxlX2d1Y19zdWJtaXNz aW9uKSB7Cj4+PiArCQlpOTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbiA9IDA7Cj4+PiArCQlEUk1f SU5GTygiR3VDIHN1Ym1pc3Npb24gd2l0aG91dCBmaXJtd2FyZSBub3Qgc3VwcG9ydGVkXG4iKTsK Pj4+ICsJCURSTV9OT1RFKCJGYWxsaW5nIGJhY2sgZnJvbSBHdUMgc3VibWlzc2lvbiB0byBleGVj bGlzdCBtb2RlXG4iKTsKPj4KPj4gSWYgaTkxNS5lbmFibGVfZ3VjX3N1Ym1pc3Npb24gPiAxIHdl IHdpbGwgbWFyayB0aGUgR1BVIGFzIHdlZGdlZCBzbyBpdCBtaWdodAo+PiBiZSB3b3J0aCByZXRh aW5pbmcgYW4gZXJyb3IgbGV2ZWwgbWVzc2FnZSBoZXJlIGluIHRoYXQgc2NlbmFyaW8uCj4KPiBJ ZiB3ZSBhcmUgd2VkZ2luZyB0aGUgR1BVIHlvdSBkbyBub3QgcmVhbGx5IGNhcmUgYWJvdXQgdGhl IGZhbGxiYWNrLCBzbwo+IHRoZXJlcyBubyByZWFsIHVzZSBpbiBoYXZpbmcgdGhhdCBwcm9tb3Rl ZCArIHRob3NlIGFyZSB0aGUgb3JpZ2luYWwKPiBsZXZlbHMgdGhhdCB3ZXJlIGFscmVhZHkgaGVy ZS4KPgo+IEFueXdheSwgaXQgc2VlbXMgbGlrZSB0aGUgYGVuYWJsZV9ndWNfKiA+IDFgIGFyZSBs aWtlbHkgdG8gYmUgZ29uZS4gSSd2ZQo+IGRpc2N1c3NlZCB0aGF0IG9uIElSQyB5ZXN0ZXJkYXkg YW5kIG5vIG9uZSBzZWVtcyB0byByZWFsbHkgcmVtZW1iZXIgd2h5Cj4gd2UndmUgZ290IGl0IGlu IHRoZSBmaXJzdCBwbGFjZS4KPgo+IEFudXNoYSBwb3N0ZWQgc2ltaWxhciBjb25jZXJuIGhlcmUg d2l0aCBoZXIgSHVDIHNlcmllcyBhcyB3ZWxsLgo+CgpKdXN0IHRvIGNsYXJpZnkgKGJlY2F1c2Ug YXMgeW91IHNhaWQgdGhlIGNhc2Ugd2lsbCBwcm9iYWJseSBnbyBhd2F5KSwgCndoYXQgSSBtZWFu dCB3YXMgYW4gZXh0cmEgbG9nIGZvciB0aGUgPiAxIGNhc2UgbGlrZSB3ZSBoYWQgaW4gdGhlIApv cmlnaW5hbCBjb2RlLCBpLmU6CgoJRFJNX0VSUk9SKCJHdUMgaW5pdCBmYWlsZWQ6ICVkXG4iLCBy ZXQpOwoKYXMgb3RoZXJ3aXNlIHdlIHdvdWxkIGhhdmUgZGVjbGFyZWQgdGhlIEdQVSB3ZWRnZWQg d2l0aG91dCBwcmludGluZyBhbnkgCmVycm9yLWxldmVsIG1lc3NhZ2UgdG8gZXhwbGFpbiB3aHku CgpEYW5pZWxlCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=