From: Florian Fainelli Subject: Re: [PATCH v2 4/4] net: dsa: vsc73xx: Assert reset if iCPU is enabled Date: Thu, 4 Jul 2019 13:27:18 -0700 Message-ID: References: <20190703171924.31801-1-paweldembicki@gmail.com> <20190703171924.31801-5-paweldembicki@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190703171924.31801-5-paweldembicki@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org To: Pawel Dembicki Cc: linus.walleij@linaro.org, Andrew Lunn , Vivien Didelot , "David S. Miller" , Rob Herring , Mark Rutland , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On 7/3/2019 10:19 AM, Pawel Dembicki wrote: > Driver allow to use devices with disabled iCPU only. > > Some devices have pre-initialised iCPU by bootloader. > That state make switch unmanaged. This patch force reset > if device is in unmanaged state. In the result chip lost > internal firmware from RAM and it can be managed. > > Signed-off-by: Pawel Dembicki > --- [snip] > @@ -1158,6 +1143,19 @@ int vsc73xx_probe(struct vsc73xx *vsc) > msleep(20); > > ret = vsc73xx_detect(vsc); > + if (ret == -EAGAIN) { > + dev_err(vsc->dev, > + "Chip seams to be out of control. Assert reset and try again.\n"); > + gpiod_set_value_cansleep(vsc->reset, 1); s/seams/seems/ With that fixed: Reviewed-by: Florian Fainelli -- Florian