Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85197C7619A for ; Wed, 12 Apr 2023 18:12:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B807210E28B; Wed, 12 Apr 2023 18:12:51 +0000 (UTC) Received: from mailbackend.panix.com (mailbackend.panix.com [166.84.1.89]) by gabe.freedesktop.org (Postfix) with ESMTPS id 93DC110E0F1 for ; Wed, 12 Apr 2023 18:12:49 +0000 (UTC) Received: from mail.panix.com (localhost [127.0.0.1]) by mailbackend.panix.com (Postfix) with ESMTPA id 4PxW5q4BRMz47j8; Wed, 12 Apr 2023 14:12:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=panix.com; s=panix; t=1681323167; bh=DvXrenb9Kgk8Kq1FPp3NAzT+K5TJB88dBKyeYXg0qUE=; h=In-Reply-To:References:Date:Subject:From:To:Cc; b=Ev4IV7kaTaSnTFw5fwQIMzThRKaAuB3VYooO0MwC9OxuawXKoaJywqR7JYgIrZW5S JY0RWMxMiMz5J32Mkp9KkxH32QjDocoLh3g1vXldMTCXnS/QiahFpWoYCo7rD96sSE +bLeaEp2FQz22WestWfImV7vx2o8YLRsfg0susfM= X-Panix-Received: from 166.84.1.2 (SquirrelMail authenticated user pa@panix.com) by mail.panix.com with HTTP; Wed, 12 Apr 2023 14:12:47 -0400 Message-ID: In-Reply-To: <87jzyhror0.fsf@minerva.mail-host-address-is-not-set> References: <20230412150225.3757223-1-javierm@redhat.com> <2e07f818ccdff7023a060e732d7c4ef6.squirrel@mail.panix.com> <87jzyhror0.fsf@minerva.mail-host-address-is-not-set> Date: Wed, 12 Apr 2023 14:12:47 -0400 Subject: Re: [PATCH] firmware/sysfb: Fix wrong stride when bits-per-pixel is calculated From: "Pierre Asselin" To: "Javier Martinez Canillas" User-Agent: SquirrelMail/1.4.23-p1 MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jocelyn Falempe , Pierre Asselin , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Hans de Goede , Thomas Zimmermann , Ard Biesheuvel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > Interesting. So you don't have the simplefb output that you had before ? I do now, after a 'make clean' and "make bzImage'. In between, I had tried CONFIG_SYSFB_SIMPLEFB=n . That "works", by falling back to vesafb in every case. I restored the .config before testing the patch, but there must have been leftover dregs in the build tree. 1024x768x32 is garbled, others are good whether simplefb or vesafb. --PA