Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79B5AE7E638 for ; Tue, 26 Sep 2023 14:26:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E9E9286DA8; Tue, 26 Sep 2023 16:26:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="HC7kEMQH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B0ED186DB8; Tue, 26 Sep 2023 16:26:04 +0200 (CEST) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 37E8886DA2 for ; Tue, 26 Sep 2023 16:26:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=afd@ti.com Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 38QEPx2i124464; Tue, 26 Sep 2023 09:25:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1695738359; bh=kWMgNoRVAD5SwnrPuZFgvd6CSYzSMUfICXndAekhubw=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=HC7kEMQH3vs1zzk9QlnJku0F2/b8YCbTpLpODLsaHFzU0DXg9Jhf47+KrSgkRzQVD 2MQ1c+fhHSKKJPYM7vcbrCXMKTVVeNxhc+yZgKLWQYeHfFFe2+SV8Tk9WlohOcPE3H gFb+xZIZY4eZz4zCPLi2hyw993eVGmqzT/fv+jYc= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 38QEPxvG002962 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 26 Sep 2023 09:25:59 -0500 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 26 Sep 2023 09:25:59 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 26 Sep 2023 09:25:59 -0500 Received: from [10.250.38.120] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 38QEPwRc013086; Tue, 26 Sep 2023 09:25:58 -0500 Message-ID: Date: Tue, 26 Sep 2023 09:25:58 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RFC PATCH v2 0/8] ATF and OP-TEE Firewalling for K3 devices. Content-Language: en-US To: Manorit Chawdhry , Simon Glass , Alper Nebi Yasak , Neha Malcom Francis , Vignesh Raghavendra CC: , Udit Kumar , Praneeth Bajjuri , Kamlesh Gurudasani , Nishanth Menon References: <20230926-binman-firewalling-v2-0-b1a084ec634d@ti.com> From: Andrew Davis In-Reply-To: <20230926-binman-firewalling-v2-0-b1a084ec634d@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 9/26/23 2:58 AM, Manorit Chawdhry wrote: > K3 devices have firewalls that are used to prevent illegal accesses to > memory regions that are deemed secure. The series prevents the illegal > accesses to ATF and OP-TEE regions that are present in different K3 > devices. > > AM62AX and AM64X are currently in hold due to some firewall > configurations that our System Controller (TIFS) needs to handle. > > Signed-off-by: Manorit Chawdhry > --- You have mixed tabs and spaces in the .dtsi patches. Andrew > Changes in v2: > > Andrew: > - Make the firewall DTS more readable with CONSTANTS > > Neha: > - Move GetHexOctet to dtoc for common usage > - Update the documentation in ti-secure > - s/indentifier/identifier/ > - Add firewall binman test > > - Remove slave firewall multiple background regions > ( Single firewall region works fine ) > - Add a check in the subnodes to check for the node.name 'firewall' > - Change firewall indexing with id and region number so that it is easy > to purge out firewalls and we don't need to redo the numbering. > - Add information for all the firewalls. > - Link to v1: https://lore.kernel.org/u-boot/20230905-binman-firewalling-v1-0-3894520bff8a@ti.com/ > > --- > Manorit Chawdhry (8): > dtoc: openssl: Add GetHexOctet method > binman: ti-secure: Add support for firewalling entities > binman: ftest: Add test for ti-secure firewall node > binman: k3: add k3-security.h and include it in k3-binman.dtsi > binman: j721e: Add firewall configurations for atf > binman: am62x: Add firewalling configurations > binman: j721s2: Add firewall configurations > binman: j7200: Add firewall configurations > > arch/arm/dts/k3-am625-sk-binman.dtsi | 49 +++++++ > arch/arm/dts/k3-binman.dtsi | 2 + > arch/arm/dts/k3-j7200-binman.dtsi | 137 ++++++++++++++++++ > arch/arm/dts/k3-j721e-binman.dtsi | 183 ++++++++++++++++++++++++ > arch/arm/dts/k3-j721s2-binman.dtsi | 206 +++++++++++++++++++++++++++ > arch/arm/dts/k3-security.h | 58 ++++++++ > tools/binman/btool/openssl.py | 16 ++- > tools/binman/etype/ti_secure.py | 85 +++++++++++ > tools/binman/etype/x509_cert.py | 3 +- > tools/binman/ftest.py | 12 ++ > tools/binman/test/311_ti_secure_firewall.dts | 28 ++++ > tools/dtoc/fdt_util.py | 20 +++ > 12 files changed, 796 insertions(+), 3 deletions(-) > --- > base-commit: 2fe4b54556ea6271237b35de68dc458bfceab94c > change-id: 20230724-binman-firewalling-65ecdb23ec0a > > Best regards,