From: "cron2 (Code Review)" Date: Thu, 8 Jan 2026 15:52:09 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="AYmziNP4s7M="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Fix building test_tls_crypt with cmocka 2.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --AYmziNP4s7M= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1460?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Fix building test_tls_crypt with cmocka 2.0 ...................................................................... Fix building test_tls_crypt with cmocka 2.0 This was missed in commit 6db186e0b1d9783ea96e8a945a47fd23b45e4778 since we only built with cmocka 2.0 on macOS and that doesn't build test_tls_crypt. Now that we build with cmocka 2.0 also on Debian Sid we noticed the additional issues. Change-Id: Ibc964c13724316ca96276ba6b7d34dbbfcf52064 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1460 Message-Id: <20260108154248.21706-1-gert@...1296...> Signed-off-by: Gert Doering --- M tests/unit_tests/openvpn/test_tls_crypt.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/60/1460/2 diff --git a/tests/unit_tests/openvpn/test_tls_crypt.c b/tests/unit_tests/o= penvpn/test_tls_crypt.c index 4a80a4c..730841e 100644 --- a/tests/unit_tests/openvpn/test_tls_crypt.c +++ b/tests/unit_tests/openvpn/test_tls_crypt.c @@ -110,8 +110,8 @@ __wrap_buffer_write_file(const char *filename, const struct buffer *buf) { const char *pem =3D BSTR(buf); - check_expected(filename); - check_expected(pem); + check_expected_ptr(filename); + check_expected_ptr(pem); return mock_type(bool); } @@ -119,7 +119,7 @@ struct buffer __wrap_buffer_read_from_file(const char *filename, struct gc_arena *gc) { - check_expected(filename); + check_expected_ptr(filename); const char *pem_str =3D mock_ptr_type(const char *); struct buffer ret =3D alloc_buf_gc(strlen(pem_str) + 1, gc); -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1460?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ibc964c13724316ca96276ba6b7d34dbbfcf52064 Gerrit-Change-Number: 1460 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --AYmziNP4s7M= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #2 to the change originally created by flichtenhel= d.

View Change

The following approvals got outdated and were remove= d: Code-Review+2 by cron2

Fix building test_tls_crypt with cm=
ocka 2.0

This was missed in commit
6db186e0b1d9783ea96e8a945a47fd= 23b45e4778 since we
only built with cmocka 2.0 on macOS and that doesn&#= 39;t
build test_tls_crypt.

Now that we build with cmocka 2.0 also= on Debian Sid
we noticed the additional issues.

Change-Id: Ibc96= 4c13724316ca96276ba6b7d34dbbfcf52064
Signed-off-by: Frank Lichtenheld &l= t;frank@...2641...>
Acked-by: Gert Doering <gert@...1296...>Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1460
Message-Id: <= ;20260108154248.21706-1-gert@...1296...>
Signed-off-by: Gert Doering = <gert@...1296...>
---
M tests/unit_tests/openvpn/test_tls_crypt= .c
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/60/1460/=
2
diff --git a/tests/unit_tests/openvpn/test_tls_crypt.c b/tests/un=
it_tests/openvpn/test_tls_crypt.c
index 4a80a4c..730841e 10= 0644
--- a/tests/unit_tests/openvpn/test_tls_crypt.c=
+++ b/tests/unit_tests/openvpn/test_tls_crypt.c
@= @ -110,8 +110,8 @@
__wrap_buffer_write_file(const char *fi= lename, const struct buffer *buf)
{
c= onst char *pem =3D BSTR(buf);
- check_expected(filename);
- check_expected(pem);
+ check_expected_ptr(filename);
+ check_expected_ptr(pem);
<= span>
return mock_type(bool);
}
@@ -119,7 +119,7 @@
struct buffer
__wrap_buffer_read_from_file(const char *filename, struct gc_arena *gc= )

{
- = check_expected(filename);
+ check_expected_ptr(filename);

const char *pem_str =3D mock_ptr_type(const char *);
struct buffer ret =3D alloc_buf_gc(strlen(pem_str) + 1, gc);

To view, visit change 1460. To unsubscribe, or for = help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ibc964c13724316ca96276ba6b7d= 34dbbfcf52064
Gerrit-Change-Number: 1460
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --AYmziNP4s7M=--