From: Daniele Ceraolo Spurio Subject: Re: [PATCH 5/8] drm/i915/icl: Add reset control register changes Date: Fri, 16 Mar 2018 13:28:25 -0700 Message-ID: References: <20180316121456.11577-1-mika.kuoppala@linux.intel.com> <20180316121456.11577-5-mika.kuoppala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1FC7B6EBF1 for ; Fri, 16 Mar 2018 20:28:27 +0000 (UTC) In-Reply-To: <20180316121456.11577-5-mika.kuoppala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org CgpPbiAxNi8wMy8xOCAwNToxNCwgTWlrYSBLdW9wcGFsYSB3cm90ZToKPiBGcm9tOiBNaWNoZWwg VGhpZXJyeSA8bWljaGVsLnRoaWVycnlAaW50ZWwuY29tPgo+IAo+IFRoZSBiaXRzIHVzZWQgdG8g cmVzZXQgdGhlIGRpZmZlcmVudCBlbmdpbmVzL2RvbWFpbnMgaGF2ZSBjaGFuZ2VkIGluCj4gR0VO MTEsIHRoaXMgcGF0Y2ggbWFwcyB0aGUgcmVzZXQgZW5naW5lIG1hc2sgYml0cyB3aXRoIHRoZSBu ZXcgYml0cwo+IGluIHRoZSByZXNldCBjb250cm9sIHJlZ2lzdGVyLgo+IAo+IHYyOiBVc2Ugc2hp ZnQtbGVmdCBpbnN0ZWFkIG9mIEJJVCBtYWNybyB0byBtYXRjaCB0aGUgZmlsZSBzdHlsZSAoUGF1 bG8pLgo+IHYzOiBSZXVzZSBnZW44X3Jlc2V0X2VuZ2luZXMgKERhbmllbGUpLgo+IHY0OiBEbyBu b3QgY2FsbCBpbnRlbF91bmNvcmVfZm9yY2V3YWtlX3Jlc2V0IGFmdGVyIHJlc2V0LCB3ZSBtYXkg YmUKPiB1c2luZyB0aGUgZm9yY2V3YWtlIHRvIHJlYWQgcHJvdGVjdGVkIHJlZ2lzdGVycyBlbHNl d2hlcmUgYW5kIHRob3NlCj4gcmVzdWx0cyBtYXkgYmUgY2xvYmJlcmVkIGJ5IHRoZSBjb25jdXJy ZW50IGRyb3BwaW5nIG9mIGZvcmNld2FrZS4KPiAKPiBic3BlYzogMTkyMTIKPiBDYzogT3NjYXIg TWF0ZW8gPG9zY2FyLm1hdGVvQGludGVsLmNvbT4KPiBDYzogQW50b25pbyBBcmdlbnppYW5vIDxh bnRvbmlvLmFyZ2Vuemlhbm9AaW50ZWwuY29tPgo+IENjOiBQYXVsbyBaYW5vbmkgPHBhdWxvLnIu emFub25pQGludGVsLmNvbT4KPiBDYzogRGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFuaWVsZS5j ZXJhb2xvc3B1cmlvQGludGVsLmNvbT4KPiBBY2tlZC1ieTogRGFuaWVsZSBDZXJhb2xvIFNwdXJp byA8ZGFuaWVsZS5jZXJhb2xvc3B1cmlvQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBNaWNo ZWwgVGhpZXJyeSA8bWljaGVsLnRoaWVycnlAaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9yZWcuaCAgICAgfCAxMSArKysrKysrKwo+ICAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMgfCA1MyArKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKy0tCj4gICAyIGZpbGVzIGNoYW5nZWQsIDYyIGluc2VydGlvbnMoKyksIDIgZGVsZXRp b25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gaW5kZXggOWVhYWE5NjI4N2VjLi5m M2NjNzc2OTAxMjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcu aAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiBAQCAtMzAxLDYgKzMw MSwxNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaTkxNV9tbWlvX3JlZ192YWxpZChpOTE1X3JlZ190 IHJlZykKPiAgICNkZWZpbmUgIEdFTjZfR1JET01fVkVDUwkJKDEgPDwgNCkKPiAgICNkZWZpbmUg IEdFTjlfR1JET01fR1VDCQkJKDEgPDwgNSkKPiAgICNkZWZpbmUgIEdFTjhfR1JET01fTUVESUEy CQkoMSA8PCA3KQo+ICsvKiBHRU4xMSBjaGFuZ2VkIGFsbCBiaXQgZGVmcyBleGNlcHQgZm9yIEZV TEwgJiBSRU5ERVIgKi8KPiArI2RlZmluZSAgR0VOMTFfR1JET01fRlVMTAkJR0VONl9HUkRPTV9G VUxMCj4gKyNkZWZpbmUgIEdFTjExX0dSRE9NX1JFTkRFUgkJR0VONl9HUkRPTV9SRU5ERVIKPiAr I2RlZmluZSAgR0VOMTFfR1JET01fQkxUCQkoMSA8PCAyKQo+ICsjZGVmaW5lICBHRU4xMV9HUkRP TV9HVUMJCSgxIDw8IDMpCj4gKyNkZWZpbmUgIEdFTjExX0dSRE9NX01FRElBCQkoMSA8PCA1KQo+ ICsjZGVmaW5lICBHRU4xMV9HUkRPTV9NRURJQTIJCSgxIDw8IDYpCj4gKyNkZWZpbmUgIEdFTjEx X0dSRE9NX01FRElBMwkJKDEgPDwgNykKPiArI2RlZmluZSAgR0VOMTFfR1JET01fTUVESUE0CQko MSA8PCA4KQo+ICsjZGVmaW5lICBHRU4xMV9HUkRPTV9WRUNTCQkoMSA8PCAxMykKPiArI2RlZmlu ZSAgR0VOMTFfR1JET01fVkVDUzIJCSgxIDw8IDE0KQo+ICAgCj4gICAjZGVmaW5lIFJJTkdfUFBf RElSX0JBU0UoZW5naW5lKQlfTU1JTygoZW5naW5lKS0+bW1pb19iYXNlKzB4MjI4KQo+ICAgI2Rl ZmluZSBSSU5HX1BQX0RJUl9CQVNFX1JFQUQoZW5naW5lKQlfTU1JTygoZW5naW5lKS0+bW1pb19i YXNlKzB4NTE4KQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNv cmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4gaW5kZXggNGM2MTZk MDc0YTk3Li5jYWJiZjBlNjgyZTcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfdW5jb3JlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUu Ywo+IEBAIC0xOTA5LDYgKzE5MDksNTAgQEAgc3RhdGljIGludCBnZW42X3Jlc2V0X2VuZ2luZXMo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCXJldHVybiBnZW42X2h3X2Rv bWFpbl9yZXNldChkZXZfcHJpdiwgaHdfbWFzayk7Cj4gICB9Cj4gICAKPiArLyoqCj4gKyAqIGdl bjExX3Jlc2V0X2VuZ2luZXMgLSByZXNldCBpbmRpdmlkdWFsIGVuZ2luZXMKPiArICogQGRldl9w cml2OiBpOTE1IGRldmljZQo+ICsgKiBAZW5naW5lX21hc2s6IG1hc2sgb2YgaW50ZWxfcmluZ19m bGFnKCkgZW5naW5lcyBvciBBTExfRU5HSU5FUyBmb3IgZnVsbCByZXNldAo+ICsgKgo+ICsgKiBU aGlzIGZ1bmN0aW9uIHdpbGwgcmVzZXQgdGhlIGluZGl2aWR1YWwgZW5naW5lcyB0aGF0IGFyZSBz ZXQgaW4gZW5naW5lX21hc2suCj4gKyAqIElmIHlvdSBwcm92aWRlIEFMTF9FTkdJTkVTIGFzIG1h c2ssIGZ1bGwgZ2xvYmFsIGRvbWFpbiByZXNldCB3aWxsIGJlIGlzc3VlZC4KPiArICoKPiArICog Tm90ZTogSXQgaXMgcmVzcG9uc2liaWxpdHkgb2YgdGhlIGNhbGxlciB0byBoYW5kbGUgdGhlIGRp ZmZlcmVuY2UgYmV0d2Vlbgo+ICsgKiBhc2tpbmcgZnVsbCBkb21haW4gcmVzZXQgdmVyc3VzIHJl c2V0IGZvciBhbGwgYXZhaWxhYmxlIGluZGl2aWR1YWwgZW5naW5lcy4KPiArICoKPiArICogUmV0 dXJucyAwIG9uIHN1Y2Nlc3MsIG5vbnplcm8gb24gZXJyb3IuCj4gKyAqLwo+ICtzdGF0aWMgaW50 IGdlbjExX3Jlc2V0X2VuZ2luZXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ ICsJCQkgICAgICAgdW5zaWduZWQgZW5naW5lX21hc2spCj4gK3sKPiArCXN0cnVjdCBpbnRlbF9l bmdpbmVfY3MgKmVuZ2luZTsKPiArCWNvbnN0IHUzMiBod19lbmdpbmVfbWFza1tJOTE1X05VTV9F TkdJTkVTXSA9IHsKPiArCQlbUkNTXSA9IEdFTjExX0dSRE9NX1JFTkRFUiwKPiArCQlbQkNTXSA9 IEdFTjExX0dSRE9NX0JMVCwKPiArCQlbVkNTXSA9IEdFTjExX0dSRE9NX01FRElBLAo+ICsJCVtW Q1MyXSA9IEdFTjExX0dSRE9NX01FRElBMiwKPiArCQlbVkNTM10gPSBHRU4xMV9HUkRPTV9NRURJ QTMsCj4gKwkJW1ZDUzRdID0gR0VOMTFfR1JET01fTUVESUE0LAo+ICsJCVtWRUNTXSA9IEdFTjEx X0dSRE9NX1ZFQ1MsCj4gKwkJW1ZFQ1MyXSA9IEdFTjExX0dSRE9NX1ZFQ1MyLAo+ICsJfTsKCkp1 c3QgYSB0aG91Z2h0LCBidXQgc2luY2UgdGhpcyBmdW5jdGlvbiBpcyBhIGNvcHkgb2YgZ2VuNl9y ZXNldF9lbmdpbmVzIAp3aXRoIHRoZSBvbmx5IGRpZmZlcmVuY2UgYmVpbmcgdGhlIGFycmF5IChH RU4xMV9HUkRPTV9GVUxMIGlzIGFsc28gdGhlIApzYW1lIGFzIEdFTjZfR1JET01fRlVMTCksIHdv dWxkIGl0IG1ha2Ugc2Vuc2UgdG8ganVzdCBhZGQgdGhlIGFycmF5IHRvIAp0aGUgZ2VuNiBmdW5j dGlvbj8gZS5nLjoKCgljb25zdCB1MzIgZ2VuNl9od19lbmdpbmVfbWFza1tdID0gewoJLi4uLgoJ fQoJY29uc3QgdTMyIGdlbjExX2h3X2VuZ2luZV9tYXNrW10gPSB7CgkuLi4uCgl9CgoJY29uc3Qg dTMyICpod19lbmdpbmVfbWFzayA9IElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEgPwoJCWdlbjEx X2h3X2VuZ2luZV9tYXNrIDogZ2VuNl9od19lbmdpbmVfbWFzazsKCgpNeSBBY2sgc3RpbGwgc3Rh bmRzIHJlZ2FyZGxlc3MgYW5kIEkgYWxzbyBhZ3JlZSB3aXRoIHJlbmFtaW5nIHRoZSAKZGVmaW5l cyB0byBiZSBjbG9zZXIgdG8gdGhlIHNwZWNzLgoKRGFuaWVsZQoKPiArCXUzMiBod19tYXNrOwo+ ICsKPiArCUJVSUxEX0JVR19PTihWRUNTMiArIDEgIT0gSTkxNV9OVU1fRU5HSU5FUyk7Cj4gKwo+ ICsJaWYgKGVuZ2luZV9tYXNrID09IEFMTF9FTkdJTkVTKSB7Cj4gKwkJaHdfbWFzayA9IEdFTjEx X0dSRE9NX0ZVTEw7Cj4gKwl9IGVsc2Ugewo+ICsJCXVuc2lnbmVkIGludCB0bXA7Cj4gKwo+ICsJ CWh3X21hc2sgPSAwOwo+ICsJCWZvcl9lYWNoX2VuZ2luZV9tYXNrZWQoZW5naW5lLCBkZXZfcHJp diwgZW5naW5lX21hc2ssIHRtcCkKPiArCQkJaHdfbWFzayB8PSBod19lbmdpbmVfbWFza1tlbmdp bmUtPmlkXTsKPiArCX0KPiArCj4gKwlyZXR1cm4gZ2VuNl9od19kb21haW5fcmVzZXQoZGV2X3By aXYsIGh3X21hc2spOwo+ICt9Cj4gKwo+ICAgLyoqCj4gICAgKiBfX2ludGVsX3dhaXRfZm9yX3Jl Z2lzdGVyX2Z3IC0gd2FpdCB1bnRpbCByZWdpc3RlciBtYXRjaGVzIGV4cGVjdGVkIHN0YXRlCj4g ICAgKiBAZGV2X3ByaXY6IHRoZSBpOTE1IGRldmljZQo+IEBAIC0yMDU2LDcgKzIxMDAsMTAgQEAg c3RhdGljIGludCBnZW44X3Jlc2V0X2VuZ2luZXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2LAo+ICAgCQlpZiAoZ2VuOF9yZXNldF9lbmdpbmVfc3RhcnQoZW5naW5lKSkKPiAgIAkJ CWdvdG8gbm90X3JlYWR5Owo+ICAgCj4gLQlyZXR1cm4gZ2VuNl9yZXNldF9lbmdpbmVzKGRldl9w cml2LCBlbmdpbmVfbWFzayk7Cj4gKwlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMSkKPiAr CQlyZXR1cm4gZ2VuMTFfcmVzZXRfZW5naW5lcyhkZXZfcHJpdiwgZW5naW5lX21hc2spOwo+ICsJ ZWxzZQo+ICsJCXJldHVybiBnZW42X3Jlc2V0X2VuZ2luZXMoZGV2X3ByaXYsIGVuZ2luZV9tYXNr KTsKPiAgIAo+ICAgbm90X3JlYWR5Ogo+ICAgCWZvcl9lYWNoX2VuZ2luZV9tYXNrZWQoZW5naW5l LCBkZXZfcHJpdiwgZW5naW5lX21hc2ssIHRtcCkKPiBAQCAtMjE0MSwxMiArMjE4OCwxNCBAQCBi b29sIGludGVsX2hhc19yZXNldF9lbmdpbmUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KQo+ICAgCj4gICBpbnQgaW50ZWxfcmVzZXRfZ3VjKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdikKPiAgIHsKPiArCXUzMiBndWNfZG9tYWluID0gSU5URUxfR0VOKGRldl9wcml2 KSA+PSAxMSA/IEdFTjExX0dSRE9NX0dVQyA6Cj4gKwkJCQkJCSAgICAgR0VOOV9HUkRPTV9HVUM7 Cj4gICAJaW50IHJldDsKPiAgIAo+ICAgCUdFTV9CVUdfT04oIUhBU19HVUMoZGV2X3ByaXYpKTsK PiAgIAo+ICAgCWludGVsX3VuY29yZV9mb3JjZXdha2VfZ2V0KGRldl9wcml2LCBGT1JDRVdBS0Vf QUxMKTsKPiAtCXJldCA9IGdlbjZfaHdfZG9tYWluX3Jlc2V0KGRldl9wcml2LCBHRU45X0dSRE9N X0dVQyk7Cj4gKwlyZXQgPSBnZW42X2h3X2RvbWFpbl9yZXNldChkZXZfcHJpdiwgZ3VjX2RvbWFp bik7Cj4gICAJaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9wdXQoZGV2X3ByaXYsIEZPUkNFV0FLRV9B TEwpOwo+ICAgCj4gICAJcmV0dXJuIHJldDsKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==