From: "plaisthos (Code Review)"
Date: Sat, 4 Jan 2025 22:44:21 +0000
In-Reply-To:
References:
Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net,
frank@...2641..., max@...2606...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="28Oa0qw1LhU="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: Do not attempt to
decrypt packets anymore after 2**36 failed decryptions
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: MaxF , flichtenheld , openvpn-devel
--28Oa0qw1LhU=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: MaxF, flichtenheld.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/843?usp=3Demail )
Change subject: Do not attempt to decrypt packets anymore after 2**36 faile=
d decryptions
......................................................................
Patch Set 3:
(4 comments)
File src/openvpn/crypto.h:
http://gerrit.openvpn.net/c/openvpn/+/843/comment/6408b1af_041def26 :
PS2, Line 667: We
> Incomplete
Acknowledged
http://gerrit.openvpn.net/c/openvpn/+/843/comment/21fe7587_f0d0de4b :
PS2, Line 672: TLS 1.3
> Should be DTLS
Acknowledged
http://gerrit.openvpn.net/c/openvpn/+/843/comment/a39b0e44_3b6d137a :
PS2, Line 672: 2**36
> I don't know. I thought you did consider larger packets in the OpenVPN RF=
C.
I commented that we accept this since chacha with > 16k is probably super r=
are.
File src/openvpn/crypto.c:
http://gerrit.openvpn.net/c/openvpn/+/843/comment/33de160f_e3170849 :
PS2, Line 426:
> Extra whitespace
Acknowledged
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/843?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I81440ac28a1ad553652e201234e5ddfe03a8c190
Gerrit-Change-Number: 843
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos
Gerrit-Reviewer: MaxF
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: flichtenheld
Gerrit-Attention: MaxF
Gerrit-Comment-Date: Sat, 04 Jan 2025 22:44:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos
Comment-In-Reply-To: MaxF
Gerrit-MessageType: comment
--28Oa0qw1LhU=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: MaxF, flichtenheld.