From: Keir Fraser Subject: Re: Re: Panic in ipt_do_table with 2.6.16.13-xen Date: Tue, 23 May 2006 22:15:58 +0100 Message-ID: References: <4468BE70.7030802@tektonic.net> <4468D613.20309@trash.net> <44691669.4080903@tektonic.net> <4469D84F.8080709@tektonic.net> <446D0A0D.5090608@tektonic.net> <446D0E6D.2080600@tektonic.net> <446D151D.6030307@tektonic.net> <4470A6CD.5010501@trash.net> <4471CB54.401@tektonic.net> <4471CE19.5070802@trash.net> Mime-Version: 1.0 (Apple Message framework v624) Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Cc: "xen-devel@lists.xensource.com" , Netfilter Development Mailinglist , James Morris , Matt Ayres , Linux Kernel Mailing List Return-path: In-Reply-To: <4471CE19.5070802@trash.net> To: Patrick McHardy List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com List-Id: netfilter-devel.vger.kernel.org On 22 May 2006, at 15:43, Patrick McHardy wrote: > Maybe this helps: there is not too much the Xen code could be doing > wrong here. If I read your crash correctly it happend in the FORWARD > chain, which could mean that the outgoing device (probably the Xen > virtual network driver) has some bugs, but iptables really only cares > about the names at this point, which practically can't be bogus. > The only other thing I can imagine is that something is wrong with > the per-CPU copy of the ruleset, i.e. either smp_processor_id is > returning garbage or for_each_possible_cpu misses a CPU during > initialization. I have no idea if Xen really does touch this code, > but other than that I don't really see what it could break. Having looked at disassembly, the fault happens when accessing e->ip.invflags in ip_packet_match() inlined inside ipt_do_table(). e = private->entries[smp_processor_id()] + private->hook_entry[NF_IP_FORWARD] smp_processor_id() should be 0 (since the oops appears to occur on cpu0) and presumably all the ipt_entry structures are static once set up. Since this crash happens on a common path in ipt_do_table(), and since it happens only after the system has been up a while (I believe?), it rather looks as though something has either corrupted a pointer or unmapped memory from under iptables' feet. -- Keir