Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD9B2C433F5 for ; Thu, 12 May 2022 21:20:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354140AbiELVUX (ORCPT ); Thu, 12 May 2022 17:20:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358431AbiELVUW (ORCPT ); Thu, 12 May 2022 17:20:22 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 168C71E6544 for ; Thu, 12 May 2022 14:20:21 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 7A2ED2223A; Thu, 12 May 2022 23:20:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1652390419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DdkAgOkMo9UuARDTQ/Hna+ji6Wc4dZYlMDxuzMdHWEE=; b=GRQ+sEPqE/JIvJIgN2dWOGG4jXQZs49aD8j2KOkhARbz2iUXjyJMZCghX4W2P19vBn3PAo BdmpYFFWgtr0AyLr88ak6PCffpHN40Ti0WDqE9rjhBAVY7PxSW1RNq8am32I0gdHICYvfW LO68ofPK7ki/Of+XEPyfjlifKoTBDeg= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 12 May 2022 23:20:18 +0200 From: Michael Walle To: Jakub Kicinski Cc: alexandru.ardelean@analog.com, alvaro.karsz@solid-run.com, davem@davemloft.net, edumazet@google.com, josua@solid-run.com, krzysztof.kozlowski+dt@linaro.org, michael.hennerich@analog.com, netdev@vger.kernel.org, pabeni@redhat.com, robh+dt@kernel.org Subject: Re: [PATCH v4 1/3] dt-bindings: net: adin: document phy clock In-Reply-To: <20220511124241.7880ef52@kernel.org> References: <20220510133928.6a0710dd@kernel.org> <20220511125855.3708961-1-michael@walle.cc> <20220511091136.34dade9b@kernel.org> <20220511124241.7880ef52@kernel.org> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Am 2022-05-11 21:42, schrieb Jakub Kicinski: > On Wed, 11 May 2022 19:10:36 +0200 Michael Walle wrote: >> Am 2022-05-11 18:11, schrieb Jakub Kicinski: >> > On Wed, 11 May 2022 14:58:55 +0200 Michael Walle wrote: >> >> FWIW, the recovered clock only works if there is a link. AFAIR on the >> >> AR8031 you can have the free-running one enabled even if there is no >> >> link, which might sometimes be useful. >> > >> > Is that true for all PHYs? I've seen "larger" devices mention holdover >> > or some other form of automatic fallback in the DPLL if input clock is >> > lost. >> >> I certainly can't speak of 'all' PHYs, who can ;) But how is the >> switchover for example? hitless? will there be a brief period of >> no clock at all? >> >> The point I wanted to add is that the user should have the choice or >> at least you should clearly mention that. If you drop the suffix and >> just >> use "25mhz" is that now the recovered one or the free-running one. And >> why is that one preferred over the other? Eg. if I were a designer for >> a >> cheapo board and I'd need a 125MHz clock and want to save some bucks >> for the 125MHz osc and the PHY could supply one, I'd use the >> free-running mode. Just to avoid any surprises with a switchover >> or whatever. > > It's pure speculation on my side. I don't even know if PHYs use > the recovered clock to clock its output towards the MAC or that's > a different clock domain. > > My concern is that people will start to use DT to configure SyncE which > is entirely a runtime-controllable thing, and doesn't belong. Hence > my preference to hide the recovered vs free-running detail if we can > pick one that makes most sense for now. I see. That makes sense, but then wouldn't it make more sense to pick the (simple) free-running one? As for SyncE you'd need the recovered clock. > Again, if you feel strongly that the current design is indeed needed > to configure pure SOC<>PHY / MAC<>PHY clocking, just send a review tag > and I'll apply :) I just wanted to add my two cents :) I'm fine with either one. >> > I thought that's the case here, too: >> >> I read "reference" as being the 25MHz (maybe when the PHY is in 10Mbit >> mode? I didn't read the datasheet) because the first mode is called >> 25mhz-reference. So it might be switching between 25MHz and 125MHz? >> I don't know. > > I couldn't grok that from the datasheet. Anyway, it'd be good to make > it clearer that the second sentence refers to the "adaptive" mode and > not the behavior of the recovered clock when lock is lost. Just put > (adaptive) in the sentence somewhere. Mh, there is not much there, whatever "heartbeat clock" means. -michael