Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87557EB64DD for ; Wed, 2 Aug 2023 03:09:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 15AF586C82; Wed, 2 Aug 2023 05:09:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="LKiI0q6d"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 040E286C81; Wed, 2 Aug 2023 05:09:07 +0200 (CEST) Received: from mail-yw1-x1130.google.com (mail-yw1-x1130.google.com [IPv6:2607:f8b0:4864:20::1130]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4C1E586C82 for ; Wed, 2 Aug 2023 05:09:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=inindev@gmail.com Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-583d63ca1e9so70780777b3.1 for ; Tue, 01 Aug 2023 20:09:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690945743; x=1691550543; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=29jxY0Drft8h4u1Wz2TMyQ8/RvZiqcPeywARqj/Yzuo=; b=LKiI0q6dq359TTK4pUlqkYCEwNc6R/RD0c1vdk3ucidkPvRMxL8Ku0RB6rMLmOxhVd 7Lm4+03MDNdIpEEa5EIR0HXF5NpV0p35FW+3nvR+74bcM9wNlyfofpBPfb6qgzF7lmg1 TSbKti7I63d92tYhH4vNytJRDt85Y2+qTF7nHNtWVkH1hf9tO7YF3+bTB5YNbKj2WxGq 25c3ht2sp1K6nXDe8L7Kym5RsesdW+k2yeyyKc20ZsWO/OVS0eXC1oMws4eVstZjCwU5 3BF6bbCEAm1jTVS6z0nea24ngDQbGblaQpSqNcQFH/RcYwvaVCmyCWH8E8Mld2QOG+oh UBjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690945743; x=1691550543; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=29jxY0Drft8h4u1Wz2TMyQ8/RvZiqcPeywARqj/Yzuo=; b=eaqsxHB81vt/BK7Pcbjfo/h6ECXh+oNlemk361dSQrDG83U04O49zNdkXXhOTC7ozx rmN+xbKQYjHfAbyLvLw4ZFrgfV7qEw0chGu8tfT/PrCAN7h5GjZN4lMmMyXB/RqfZnVl O1jxBeUCAy8jFGuR2Q1QLAxRIf7nH+70SG1tBXK0C75V2Qfe94aheFd7P1spZJAlmMJJ L+SAPf91HjueKf8qPVYiVUZpVueoec8FlAFiMivjXk4KL9dqyZ7zvY4Vns1rn9fhSwok kUNxkqK47GrX0nFwmRlrYh1R5QEr5lPi/1S8vG2pCsitO2rPi5HZ+KJNzVbcSgLfRs+2 PyCg== X-Gm-Message-State: ABy/qLbnohgcxRqI3lC4JcyTj/8cYSqjwngrrW7JImmJDsNJONtKaZrR Jizw+6wKzndb8/ZpBNHcmeo= X-Google-Smtp-Source: APBJJlG/q73FAezq6Fcnz/Nh9nT4UlLqV75ty/wYpK1r5ZsTfQ07UHQ3UzSErt/ys9O22UPhUt1Ptg== X-Received: by 2002:a81:74c1:0:b0:583:8c64:930 with SMTP id p184-20020a8174c1000000b005838c640930mr17009633ywc.47.1690945742745; Tue, 01 Aug 2023 20:09:02 -0700 (PDT) Received: from [192.168.121.234] ([192.34.165.40]) by smtp.gmail.com with ESMTPSA id y188-20020a0dd6c5000000b00586108dd8f5sm2376815ywd.18.2023.08.01.20.09.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Aug 2023 20:09:02 -0700 (PDT) Message-ID: Date: Tue, 1 Aug 2023 23:09:01 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 0/6] rockchip: rk3568: Fix use of PCIe bifurcation Content-Language: en-US To: Jonas Karlman , Kever Yang , Simon Glass , Philipp Tomsich Cc: Eugen Hristev , Jon Lin , u-boot@lists.denx.de References: <20230801212511.2123575-1-jonas@kwiboo.se> From: John Clark In-Reply-To: <20230801212511.2123575-1-jonas@kwiboo.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean It appears that you had a transmission problem with this patch as I am missing 1/6, 4/6, and 6/6. I am pretty sure these are from your repo here: https://github.com/Kwiboo/u-boot-rockchip/tree/rk35xx-pcie-bifurcation-v1 (1/6) pci: pcie_dw_rockchip: Configure number of lanes and link width speed https://github.com/Kwiboo/u-boot-rockchip/commit/2b3f591aec3abe69adc9bbc723d98550ecce3614 (2/6) phy: rockchip: snps-pcie3: Refactor to use clk_bulk API https://github.com/Kwiboo/u-boot-rockchip/commit/e6c561d1e00b92e1d4c98f9ce581385d601dbc4c (3/6) phy: rockchip: snps-pcie3: Refactor to use a phy_init ops https://github.com/Kwiboo/u-boot-rockchip/commit/627648f509f149ac9b0ade84c2a863e62b15d0a7 (4/6) phy: rockchip: snps-pcie3: Add bifurcation support for RK3568 https://github.com/Kwiboo/u-boot-rockchip/commit/a8d3342b986df42191793e2d0f72df2f41e8adff (5/6) phy: rockchip: snps-pcie3: Add support for RK3588 https://github.com/Kwiboo/u-boot-rockchip/commit/031df04ac14b3ddaba7f3be07f9a78898b73d0a5 (6/6) rockchip: rk3568-radxa-e25: Enable pcie3x1 node https://github.com/Kwiboo/u-boot-rockchip/commit/4439243b10731067baf64ea6bff84ac0519fe6d7 These work for me and detect a Nanopi R5S NVMe.  Can you resend this patchset so I can definitively confirm?  It would be great if this can be fixed in 2023.10. Thanks, John Clark On 8/1/23 5:25 PM, Jonas Karlman wrote: > This series add support for use of PCIe bifurcation on RK3568, and as a > bonus support for the RK3588 PHY is also included. With PCIe bifurcation > supported it is possible to enable PCIe on more RK3568 boards, e.g. on > NanoPi R5C and NanoPi R5S. This series only include fixing the mini PCIe > slot on Radxa E25. > > Most parts of this series was imported almost 1:1 from mainline linux. > > Patch 1 fixes configuration of number of lanes in pcie_dw_rockchip. > Patch 2-3 refactor the snps-pcie3 phy driver. > Patch 4 add bifurcation support for RK3568. > Patch 5 add support for RK3588. > Patch 6 enables the mini PCIe slot on Radxa E25. > > The RK3588 PHY part was tested on a ROCK 5B together with device tree > files picked from Sebastian Reichel's rk3588 branch at [1]. > > Patches in this series is also aviliable at [2]. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-misc.git/tree/?h=rk3588 > [2] https://github.com/Kwiboo/u-boot-rockchip/commits/rk35xx-pcie-bifurcation-v1 > > Jonas Karlman (6): > pci: pcie_dw_rockchip: Configure number of lanes and link width speed > phy: rockchip: snps-pcie3: Refactor to use clk_bulk API > phy: rockchip: snps-pcie3: Refactor to use a phy_init ops > phy: rockchip: snps-pcie3: Add bifurcation support for RK3568 > phy: rockchip: snps-pcie3: Add support for RK3588 > rockchip: rk3568-radxa-e25: Enable pcie3x1 node > > arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi | 11 +- > configs/radxa-e25-rk3568_defconfig | 1 - > drivers/pci/pcie_dw_rockchip.c | 58 ++++- > .../phy/rockchip/phy-rockchip-snps-pcie3.c | 230 ++++++++++++++---- > 4 files changed, 235 insertions(+), 65 deletions(-) >