From: "Koenig, Christian" Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr Date: Fri, 8 Nov 2019 09:07:30 +0000 Message-ID: References: <1573122349-22080-1-git-send-email-Emily.Deng@amd.com> <9de32e5b-69a2-f43f-629f-fef3c30bf5a1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Content-ID: <4C999FE3AADE6D42858DD1DFFEE10C8B-asWib9pRmPqcE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Deng, Emily" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" QW0gMDguMTEuMTkgdW0gMDk6NTIgc2NocmllYiBEZW5nLCBFbWlseToNCj4gUGluZy4uLi4uDQoN CllvdSBuZWVkIHRvIGdpdmUgbWUgYXQgbGVhc3QgZW5vdWdoIHRpbWUgdG8gd2FrZSB1cCA6KQ0K DQo+DQo+DQo+IEJlc3Qgd2lzaGVzDQo+IEVtaWx5IERlbmcNCj4NCj4NCj4NCj4+IC0tLS0tT3Jp Z2luYWwgTWVzc2FnZS0tLS0tDQo+PiBGcm9tOiBhbWQtZ2Z4IDxhbWQtZ2Z4LWJvdW5jZXNAbGlz dHMuZnJlZWRlc2t0b3Aub3JnPiBPbiBCZWhhbGYgT2YgRGVuZywNCj4+IEVtaWx5DQo+PiBTZW50 OiBGcmlkYXksIE5vdmVtYmVyIDgsIDIwMTkgMTA6NTYgQU0NCj4+IFRvOiBLb2VuaWcsIENocmlz dGlhbiA8Q2hyaXN0aWFuLktvZW5pZ0BhbWQuY29tPjsgYW1kLQ0KPj4gZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZw0KPj4gU3ViamVjdDogUkU6IFtQQVRDSF0gZHJtL2FtZGdwdTogRml4IHRoZSBu dWxsIHBvaW50ZXIgaXNzdWUgZm9yIHRkcg0KPj4NCj4+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2Ut LS0tLQ0KPj4+IEZyb206IENocmlzdGlhbiBLw7ZuaWcgPGNrb2VuaWcubGVpY2h0enVtZXJrZW5A Z21haWwuY29tPg0KPj4+IFNlbnQ6IFRodXJzZGF5LCBOb3ZlbWJlciA3LCAyMDE5IDc6MjggUE0N Cj4+PiBUbzogRGVuZywgRW1pbHkgPEVtaWx5LkRlbmdAYW1kLmNvbT47IGFtZC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnDQo+Pj4gU3ViamVjdDogUmU6IFtQQVRDSF0gZHJtL2FtZGdwdTogRml4 IHRoZSBudWxsIHBvaW50ZXIgaXNzdWUgZm9yIHRkcg0KPj4+DQo+Pj4gQW0gMDcuMTEuMTkgdW0g MTE6MjUgc2NocmllYiBFbWlseSBEZW5nOg0KPj4+PiBXaGVuIHRoZSBqb2IgaXMgYWxyZWFkeSBz aWduYWxlZCwgdGhlIHNfZmVuY2UgaXMgZnJlZWQuIFRoZW4gaXQgd2lsbA0KPj4+PiBoYXMgbnVs bCBwb2ludGVyIGluIGFtZGdwdV9kZXZpY2VfZ3B1X3JlY292ZXIuDQo+Pj4gTkFLLCB0aGUgc19m ZW5jZSBpcyBvbmx5IHNldCB0byBOVUxMIHdoZW4gdGhlIGpvYiBpcyBkZXN0cm95ZWQuIFNlZQ0K Pj4+IGRybV9zY2hlZF9qb2JfY2xlYW51cCgpLg0KPj4gSSBrbm93IGl0IGlzIHNldCB0byBOVUxM IGluIGRybV9zY2hlZF9qb2JfY2xlYW51cC4gQnV0IGluIG9uZSBjYXNlLCB3aGVuIGl0DQo+PiBl bnRlciBpbnRvIHRoZSBhbWRncHVfZGV2aWNlX2dwdV9yZWNvdmVyLCBpdCBhbHJlYWR5IGluDQo+ PiBkcm1fc2NoZWRfam9iX2NsZWFudXAsIGFuZCBhdCB0aGlzIHRpbWUsIGl0IHdpbGwgZ28gdG8g ZnJlZSBqb2IuIEJ1dCB0aGUNCj4+IGFtZGdwdV9kZXZpY2VfZ3B1X3JlY292ZXIgc29tZXRpbWVz IGlzIGZhc3Rlci4gQXQgdGhhdCB0aW1lLCBqb2IgaXMgbm90DQo+PiBmcmVlZCwgYnV0IHNfZmVu Y2UgaXMgYWxyZWFkeSBOVUxMLg0KDQpObywgdGhhdCBjYXNlIGNhbid0IGhhcHBlbi4gU2VlIGhl cmU6DQoNCj4gwqDCoMKgwqDCoMKgwqAgZHJtX3NjaGVkX2pvYl9jbGVhbnVwKHNfam9iKTsNCj4N Cj4gwqDCoMKgwqDCoMKgwqAgYW1kZ3B1X3JpbmdfcHJpb3JpdHlfcHV0KHJpbmcsIHNfam9iLT5z X3ByaW9yaXR5KTsNCj4gwqDCoMKgwqDCoMKgwqAgZG1hX2ZlbmNlX3B1dChqb2ItPmZlbmNlKTsN Cj4gwqDCoMKgwqDCoMKgwqAgYW1kZ3B1X3N5bmNfZnJlZSgmam9iLT5zeW5jKTsNCj4gwqDCoMKg wqDCoMKgwqAgYW1kZ3B1X3N5bmNfZnJlZSgmam9iLT5zY2hlZF9zeW5jKTsNCj4gwqDCoMKgwqDC oMKgwqAga2ZyZWUoam9iKTsNCg0KVGhlIGpvYiBpdHNlbGYgaXMgZnJlZWQgdXAgZGlyZWN0bHkg YWZ0ZXIgZnJlZWluZyB0aGUgcmVmZXJlbmNlIHRvIHRoZSANCnNfZmVuY2UuDQoNClNvIHlvdSBh cmUganVzdCBwYXBlcmluZyBvdmVyIGEgbXVjaCBiaWdnZXIgcHJvYmxlbSBoZXJlLiBUaGlzIHBh dGNoIGlzIA0KYSBjbGVhciBOQUsuDQoNClJlZ2FyZHMsDQpDaHJpc3RpYW4uDQoNCj4+PiBXaGVu IHlvdSBzZWUgYSBqb2Igd2l0aG91dCBhbiBzX2ZlbmNlIHRoZW4gdGhhdCBtZWFucyB0aGUgcHJv YmxlbSBpcw0KPj4+IHNvbWV3aGVyZSBlbHNlLg0KPj4+DQo+Pj4gUmVnYXJkcywNCj4+PiBDaHJp c3RpYW4uDQo+Pj4NCj4+Pj4gU2lnbmVkLW9mZi1ieTogRW1pbHkgRGVuZyA8RW1pbHkuRGVuZ0Bh bWQuY29tPg0KPj4+PiAtLS0NCj4+Pj4gICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X2RldmljZS5jIHwgIDIgKy0NCj4+Pj4gICAgZHJpdmVycy9ncHUvZHJtL3NjaGVkdWxlci9z Y2hlZF9tYWluLmMgICAgIHwgMTEgKysrKysrLS0tLS0NCj4+Pj4gICAgMiBmaWxlcyBjaGFuZ2Vk LCA3IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pDQo+Pj4+DQo+Pj4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMNCj4+Pj4gYi9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMNCj4+Pj4gaW5kZXggZTZjZTk0 OS4uNWE4ZjA4ZSAxMDA2NDQNCj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv YW1kZ3B1X2RldmljZS5jDQo+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft ZGdwdV9kZXZpY2UuYw0KPj4+PiBAQCAtNDA3NSw3ICs0MDc1LDcgQEAgaW50IGFtZGdwdV9kZXZp Y2VfZ3B1X3JlY292ZXIoc3RydWN0DQo+Pj4gYW1kZ3B1X2RldmljZSAqYWRldiwNCj4+Pj4gICAg CSAqDQo+Pj4+ICAgIAkgKiBqb2ItPmJhc2UgaG9sZHMgYSByZWZlcmVuY2UgdG8gcGFyZW50IGZl bmNlDQo+Pj4+ICAgIAkgKi8NCj4+Pj4gLQlpZiAoam9iICYmIGpvYi0+YmFzZS5zX2ZlbmNlLT5w YXJlbnQgJiYNCj4+Pj4gKwlpZiAoam9iICYmIGpvYi0+YmFzZS5zX2ZlbmNlICYmIGpvYi0+YmFz ZS5zX2ZlbmNlLT5wYXJlbnQgJiYNCj4+Pj4gICAgCSAgICBkbWFfZmVuY2VfaXNfc2lnbmFsZWQo am9iLT5iYXNlLnNfZmVuY2UtPnBhcmVudCkpDQo+Pj4+ICAgIAkJam9iX3NpZ25hbGVkID0gdHJ1 ZTsNCj4+Pj4NCj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9zY2hlZHVsZXIvc2No ZWRfbWFpbi5jDQo+Pj4+IGIvZHJpdmVycy9ncHUvZHJtL3NjaGVkdWxlci9zY2hlZF9tYWluLmMN Cj4+Pj4gaW5kZXggMzE4MDljYS4uNTZjYzEwZSAxMDA2NDQNCj4+Pj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL3NjaGVkdWxlci9zY2hlZF9tYWluLmMNCj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L3NjaGVkdWxlci9zY2hlZF9tYWluLmMNCj4+Pj4gQEAgLTMzNCw4ICszMzQsOCBAQCB2b2lkIGRy bV9zY2hlZF9pbmNyZWFzZV9rYXJtYShzdHJ1Y3QNCj4+PiBkcm1fc2NoZWRfam9iDQo+Pj4+ICpi YWQpDQo+Pj4+DQo+Pj4+ICAgIAkJCXNwaW5fbG9jaygmcnEtPmxvY2spOw0KPj4+PiAgICAJCQls aXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUoZW50aXR5LCB0bXAsICZycS0+ZW50aXRpZXMsDQo+Pj4g bGlzdCkgew0KPj4+PiAtCQkJCWlmIChiYWQtPnNfZmVuY2UtPnNjaGVkdWxlZC5jb250ZXh0ID09 DQo+Pj4+IC0JCQkJICAgIGVudGl0eS0+ZmVuY2VfY29udGV4dCkgew0KPj4+PiArCQkJCWlmIChi YWQtPnNfZmVuY2UgJiYgKGJhZC0+c19mZW5jZS0NCj4+Pj4gc2NoZWR1bGVkLmNvbnRleHQgPT0N Cj4+Pj4gKwkJCQkgICAgZW50aXR5LT5mZW5jZV9jb250ZXh0KSkgew0KPj4+PiAgICAJCQkJCWlm IChhdG9taWNfcmVhZCgmYmFkLT5rYXJtYSkgPg0KPj4+PiAgICAJCQkJCSAgICBiYWQtPnNjaGVk LT5oYW5nX2xpbWl0KQ0KPj4+PiAgICAJCQkJCQlpZiAoZW50aXR5LT5ndWlsdHkpDQo+Pj4+IEBA IC0zNzYsNyArMzc2LDcgQEAgdm9pZCBkcm1fc2NoZWRfc3RvcChzdHJ1Y3QgZHJtX2dwdV9zY2hl ZHVsZXINCj4+PiAqc2NoZWQsIHN0cnVjdCBkcm1fc2NoZWRfam9iICpiYWQpDQo+Pj4+ICAgIAkg KiBUaGlzIGl0ZXJhdGlvbiBpcyB0aHJlYWQgc2FmZSBhcyBzY2hlZCB0aHJlYWQgaXMgc3RvcHBl ZC4NCj4+Pj4gICAgCSAqLw0KPj4+PiAgICAJbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlX3JldmVy c2Uoc19qb2IsIHRtcCwgJnNjaGVkLQ0KPj4+PiByaW5nX21pcnJvcl9saXN0LCBub2RlKSB7DQo+ Pj4+IC0JCWlmIChzX2pvYi0+c19mZW5jZS0+cGFyZW50ICYmDQo+Pj4+ICsJCWlmIChzX2pvYi0+ c19mZW5jZSAmJiBzX2pvYi0+c19mZW5jZS0+cGFyZW50ICYmDQo+Pj4+ICAgIAkJICAgIGRtYV9m ZW5jZV9yZW1vdmVfY2FsbGJhY2soc19qb2ItPnNfZmVuY2UtPnBhcmVudCwNCj4+Pj4gICAgCQkJ CQkgICAgICAmc19qb2ItPmNiKSkgew0KPj4+PiAgICAJCQlhdG9taWNfZGVjKCZzY2hlZC0+aHdf cnFfY291bnQpOyBAQCAtMzk1LDcNCj4+ICszOTUsOCBAQCB2b2lkDQo+Pj4+IGRybV9zY2hlZF9z dG9wKHN0cnVjdCBkcm1fZ3B1X3NjaGVkdWxlcg0KPj4+ICpzY2hlZCwgc3RydWN0IGRybV9zY2hl ZF9qb2IgKmJhZCkNCj4+Pj4gICAgCQkJICoNCj4+Pj4gICAgCQkJICogSm9iIGlzIHN0aWxsIGFs aXZlIHNvIGZlbmNlIHJlZmNvdW50IGF0IGxlYXN0IDENCj4+Pj4gICAgCQkJICovDQo+Pj4+IC0J CQlkbWFfZmVuY2Vfd2FpdCgmc19qb2ItPnNfZmVuY2UtPmZpbmlzaGVkLCBmYWxzZSk7DQo+Pj4+ ICsJCQlpZiAoc19qb2ItPnNfZmVuY2UpDQo+Pj4+ICsJCQkJZG1hX2ZlbmNlX3dhaXQoJnNfam9i LT5zX2ZlbmNlLT5maW5pc2hlZCwNCj4+PiBmYWxzZSk7DQo+Pj4+ICAgIAkJCS8qDQo+Pj4+ICAg IAkJCSAqIFdlIG11c3Qga2VlcCBiYWQgam9iIGFsaXZlIGZvciBsYXRlciB1c2UgZHVyaW5nIEBA DQo+Pj4gLTQzOCw3DQo+Pj4+ICs0MzksNyBAQCB2b2lkIGRybV9zY2hlZF9zdGFydChzdHJ1Y3Qg ZHJtX2dwdV9zY2hlZHVsZXIgKnNjaGVkLCBib29sDQo+Pj4gZnVsbF9yZWNvdmVyeSkNCj4+Pj4g ICAgCSAqIEdQVSByZWNvdmVycyBjYW4ndCBydW4gaW4gcGFyYWxsZWwuDQo+Pj4+ICAgIAkgKi8N Cj4+Pj4gICAgCWxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZShzX2pvYiwgdG1wLCAmc2NoZWQtPnJp bmdfbWlycm9yX2xpc3QsDQo+Pj4+IG5vZGUpDQo+Pj4gew0KPj4+PiAtCQlzdHJ1Y3QgZG1hX2Zl bmNlICpmZW5jZSA9IHNfam9iLT5zX2ZlbmNlLT5wYXJlbnQ7DQo+Pj4+ICsJCXN0cnVjdCBkbWFf ZmVuY2UgKmZlbmNlID0gc19qb2ItPnNfZmVuY2UgPyBzX2pvYi0+c19mZW5jZS0NCj4+Pj4gcGFy ZW50IDoNCj4+Pj4gK05VTEw7DQo+Pj4+DQo+Pj4+ICAgIAkJYXRvbWljX2luYygmc2NoZWQtPmh3 X3JxX2NvdW50KTsNCj4+Pj4NCj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fDQo+PiBhbWQtZ2Z4IG1haWxpbmcgbGlzdA0KPj4gYW1kLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcNCj4+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vYW1kLWdmeA0KDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1n Zng=