Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2055C761A6 for ; Thu, 30 Mar 2023 11:43:33 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8D04E1F1; Thu, 30 Mar 2023 13:42:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8D04E1F1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1680176611; bh=aTonF+bWWDyHhYl4mUlkksCTBQHQGLsUDjjhjtUNpQc=; h=Date:Subject:To:References:From:In-Reply-To:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=hiJ/mKmKzq8hfwSDHUlh26+Z6OP+1PNuKiOv8YyHzOvTwEVkMvtBZogWLPFbgahv9 KrszyWkwj5aIBdmB3hDuShFwv2AgEXZmLa7SOrGRI7/xk5MID+1lEqmDcXkwlQ9D3y RJnb4vFCq4QGvFFVni1JHYMcy2cRoriQC8d188SA= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 4E4D4F80272; Thu, 30 Mar 2023 13:42:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6B919F80272; Thu, 30 Mar 2023 13:42:14 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8079DF8024E for ; Thu, 30 Mar 2023 13:42:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8079DF8024E Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=etmLwV/x DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680176529; x=1711712529; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=aTonF+bWWDyHhYl4mUlkksCTBQHQGLsUDjjhjtUNpQc=; b=etmLwV/xiAaLwbeLnA7PudSawQZliZUKJ+5IHlk3q1vb23XJVmoZUmp/ gnnFPk6/uwv95KMh3e+m/bTcZ6x75xViF13X1kxwSUQ9z/paVtBcz5Gy7 gv5HKb3sTI0vRQrbOtMff+NmsZ6qv2CA5JgahN+zsZArTKODB04B5eu3v fTrD+NX/A9P6+d4R+F7W4YN91UA6Ty9UEt8kaBRq5nO60cQEBHOgiaZXO /dNd8RXlK393yEZk2lVNhJwSjf3rN9bKLtPsxVJRWyq8R7bKAhl2Ko/0C MORNV6yVdxeCnodBTIXKFoCEte2PsN6/ze5wljoVEkBfOEfya+PSBpXpj w==; X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="341159361" X-IronPort-AV: E=Sophos;i="5.98,303,1673942400"; d="scan'208";a="341159361" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2023 04:42:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="687204996" X-IronPort-AV: E=Sophos;i="5.98,303,1673942400"; d="scan'208";a="687204996" Received: from aslawinx-mobl.ger.corp.intel.com (HELO [10.99.16.144]) ([10.99.16.144]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2023 04:42:04 -0700 Message-ID: Date: Thu, 30 Mar 2023 13:42:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 08/18] ASoC: SOF: Intel: hda-mlink: introduce helpers for 'extended links' PM To: Pierre-Louis Bossart , Peter Ujfalusi , lgirdwood@gmail.com, broonie@kernel.org, tiwai@suse.de, perex@perex.cz References: <20230327112931.23411-1-peter.ujfalusi@linux.intel.com> <20230327112931.23411-9-peter.ujfalusi@linux.intel.com> Content-Language: en-US From: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: LRCXW34EAMYZXYYXAXLUVOTPDWEVRFD6 X-Message-ID-Hash: LRCXW34EAMYZXYYXAXLUVOTPDWEVRFD6 X-MailFrom: amadeuszx.slawinski@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, rander.wang@intel.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/28/2023 3:24 PM, Pierre-Louis Bossart wrote: > > > >>> +static int check_power_active(u32 __iomem *lctl, int sublink, bool >>> enable) >> >> Should last argument be named 'active' instead of 'enable'? It would >> make more sense to me. > > Naming is the hardest part, eh? > I don't disagree ;) > I am not super happy with 'active', since the 'not-active' part is not > very clear: it's not suspended, it's really powered-off/disabled. > > I also didn't want to introduce a power state, since again it's on or > off and we don't want to introduce the Dx concepts here. > > If I had to revisit this, my preference would be: > > static int check_sublink_power(u32 __iomem *lctl, int sublink, bool enabled) Yes that reads better to me.