From: Pierre-Louis Bossart Subject: Re: [PATCH] ASoC: Intel: boards: add dmic format constraint Date: Tue, 18 Jun 2019 08:56:10 +0200 Message-ID: References: <1560836926-27055-1-git-send-email-mac.chiang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7EEE9F80CC4 for ; Tue, 18 Jun 2019 08:56:11 +0200 (CEST) In-Reply-To: <1560836926-27055-1-git-send-email-mac.chiang@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: mac.chiang@intel.com, alsa-devel@alsa-project.org Cc: harshapriya.n@intel.com, broonie@kernel.org, yong.zhi@intel.com List-Id: alsa-devel@alsa-project.org On 6/18/19 7:48 AM, mac.chiang@intel.com wrote: > From: Mac Chiang > > platform dmic recording fixup 16bits Which platforms is this needed for? IIRC this machine driver is shared with SOF-based solutions - which typically sets DMIC configs with topology - and I'd like to make sure there's no impact. Thanks! > > Signed-off-by: Mac Chiang > --- > sound/soc/intel/boards/bxt_da7219_max98357a.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sound/soc/intel/boards/bxt_da7219_max98357a.c b/sound/soc/intel/boards/bxt_da7219_max98357a.c > index 5cadb7f..ac06408 100644 > --- a/sound/soc/intel/boards/bxt_da7219_max98357a.c > +++ b/sound/soc/intel/boards/bxt_da7219_max98357a.c > @@ -330,6 +330,9 @@ static int broxton_dmic_startup(struct snd_pcm_substream *substream) > snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS, > &constraints_channels_quad); > > + runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE; > + snd_pcm_hw_constraint_msbits(runtime, 0, 16, 16); > + > return snd_pcm_hw_constraint_list(substream->runtime, 0, > SNDRV_PCM_HW_PARAM_RATE, &constraints_rates); > } >