From: "cron2 (Code Review)" Date: Tue, 28 Apr 2026 13:01:55 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="VsfmLrXiT3o="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: configure: Remove --enable-strict List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --VsfmLrXiT3o= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1590?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: configure: Remove --enable-strict ...................................................................... configure: Remove --enable-strict Both -Wsign-compare (via -Wextra) and -Wuninitalized (via -Wall) are enabled by default. So this does not do anything anymore. While here also remove rest of --enable-strict-options which was mostly removed in commit 2104ea62430e4d203f2cd998e053f4192798b9f1 Change-Id: I53e7b984980cb1e2b3f68e80358b61c9e1045725 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1590 Message-Id: <20260427174757.4075-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 752.html Signed-off-by: Gert Doering --- M CMakeLists.txt M configure.ac 2 files changed, 1 insertion(+), 19 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/90/1590/2 diff --git a/CMakeLists.txt b/CMakeLists.txt index 72e349c..715d02c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -112,7 +112,7 @@ add_link_options("$<$:/CETCOMPAT>") endif() else () - add_compile_options(-Wall -Wuninitialized) + add_compile_options(-Wall) check_and_add_compiler_flag(-Wno-stringop-truncation NoStringOpTruncat= ion) check_and_add_compiler_flag(-Wstrict-prototypes StrictPrototypes) check_and_add_compiler_flag(-Wold-style-definition OldStyleDefinition) diff --git a/configure.ac b/configure.ac index 1fd44f3..e19d651 100644 --- a/configure.ac +++ b/configure.ac @@ -203,13 +203,6 @@ ) AC_ARG_ENABLE( - [strict], - [AS_HELP_STRING([--enable-strict], [enable strict compiler warnings (debu= gging option) @<:@default=3Dno@:>@])], - , - [enable_strict=3D"no"] -) - -AC_ARG_ENABLE( [pedantic], [AS_HELP_STRING([--enable-pedantic], [enable pedantic compiler warnings, = will not generate a working executable (debugging option) @<:@default=3Dno@= :>@])], , @@ -224,13 +217,6 @@ ) AC_ARG_ENABLE( - [strict-options], - [AS_HELP_STRING([--enable-strict-options], [enable strict options check b= etween peers (debugging option) @<:@default=3Dno@:>@])], - , - [enable_strict_options=3D"no"] -) - -AC_ARG_ENABLE( [selinux], [AS_HELP_STRING([--enable-selinux], [enable SELinux support @<:@default= =3Dno@:>@])], , @@ -1270,13 +1256,9 @@ fi if test "${enable_pedantic}" =3D "yes"; then - enable_strict=3D"yes" CFLAGS=3D"${CFLAGS} -pedantic" AC_DEFINE([PEDANTIC], [1], [Enable pedantic mode]) fi -if test "${enable_strict}" =3D "yes"; then - CFLAGS=3D"${CFLAGS} -Wsign-compare -Wuninitialized" -fi if test "${enable_werror}" =3D "yes"; then CFLAGS=3D"${CFLAGS} -Werror" fi -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1590?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I53e7b984980cb1e2b3f68e80358b61c9e1045725 Gerrit-Change-Number: 1590 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --VsfmLrXiT3o= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #2 to the change originally created by flichtenhel= d.

View Change

The following approvals got outdated and were remove= d: Code-Review+2 by cron2

configure: Remove --enable-strict
Both -Wsign-compare (via -Wextra) and -Wuninitalized (via
-Wall) a= re enabled by default. So this does not do anything
anymore.

Whil= e here also remove rest of --enable-strict-options which
was mostly remo= ved in commit
2104ea62430e4d203f2cd998e053f4192798b9f1

Change-Id:= I53e7b984980cb1e2b3f68e80358b61c9e1045725
Signed-off-by: Frank Lichtenh= eld <frank@...2641...>
Acked-by: Gert Doering <gert@...1296...&= gt;
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1590
Message-I= d: <20260427174757.4075-1-gert@...1296...>
URL: https://www.mail-a= rchive.com/openvpn-devel@lists.sourceforge.net/msg36752.html
Signed-off-= by: Gert Doering <gert@...1296...>
---
M CMakeLists.txt
M co= nfigure.ac
2 files changed, 1 insertion(+), 19 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes=
/90/1590/2
diff --git a/CMakeLists.txt b/CMakeLists.txt
<= span>index 72e349c..715d02c 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -112,7 +112,7 @@
add_link_options("$<$<CONFIG:Release>:/CE= TCOMPAT>")
endif()
else ()
- add_compile_options(= -Wall -Wuninitialized)
- [strict],
- [AS_HELP_STRING([--enable-strict], [enable= strict compiler warnings (debugging option) @<:@default=3Dno@:>@])],=
- ,
- [enable_strict=3D"no"]=
-)
-
-AC_ARG_ENABLE(
[pedantic],
[AS_HE= LP_STRING([--enable-pedantic], [enable pedantic compiler warnings, will not= generate a working executable (debugging option) @<:@default=3Dno@:>= @])],
,
@@ -224,13 +217,6 @@
)


AC_ARG_ENABLE(
- [strict-options],
- [AS_HELP_STRING([--enable-strict-options],= [enable strict options check between peers (debugging option) @<:@defau= lt=3Dno@:>@])],
- ,<= /span>
- [enable_strict_option= s=3D"no"]
-)<= /span>
-
-AC_ARG_ENABLE(
[selinux],=
[AS_HELP_STRING([--enable-selinux], [enable SELinux supp= ort @<:@default=3Dno@:>@])],
,
@@ -= 1270,13 +1256,9 @@
fi

i= f test "${enable_pedantic}" =3D "yes"; then
<= span style=3D"color: hsl(0, 100%, 40%);">- enable_strict=3D"yes"<= /span>
CFLAGS=3D"${CFLAGS} -pedantic"
= AC_DEFINE([PEDANTIC], [1], [Enable pedantic mode])
fi
-if test "${enable_s= trict}" =3D "yes"; then
- CFLAGS=3D"${CFLAGS} -Wsign-compare -Wuninitialized&q= uot;
-fi
if test "${enable_werror}" =3D "yes"; then
CFLAGS=3D"${CFLAGS} -Werror"
fi<= br>

To view, visit change 1590. To unsubscribe, or for= help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I53e7b984980cb1e2b3f68e80358= b61c9e1045725
Gerrit-Change-Number: 1590
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --VsfmLrXiT3o=--