Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49DF6C4708C for ; Fri, 28 May 2021 12:54:27 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99423613C9 for ; Fri, 28 May 2021 12:54:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99423613C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 41B1482F0A; Fri, 28 May 2021 14:54:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="m6mbWcoN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9992D82F0C; Fri, 28 May 2021 14:54:24 +0200 (CEST) Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 34A4182EFE for ; Fri, 28 May 2021 14:54:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=patrice.chotard@foss.st.com Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14SCqLDP014397; Fri, 28 May 2021 14:54:20 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=Z1ODv9csSisyVm1fpnYUXlO7W/gBwSFtcLtGXS/Zh+U=; b=m6mbWcoNIFwkZDe53q/1AgEY9gLv8N6mqzvT7OG8OwUHeSD3Wi7G5zgCu/ViDXtr+1e8 VRoB6de8KwgWi/225dnfTjt0sihpsxrghQe5CCRKEG66qYgg/VSmVLxPrQNG9jQ/yvPp RRirZXTOBwYZeV0xbdVt9Tpm4nEinkJbB3pBUn67ugrQn0y/SNhtnv1GmNSZKBPSbDJK nSVHm2/EWZSsWaprmHkscXQD24zIkq4GuRXWKlcVIl2I/TqhLrTPnb8YEoDFb6jOKD9I DuQqkCerBF6wuRmTHqGc/mniFhIb2Z1xTvGMFZAiOZdfUAxYDK6+P+xGWFjv5e6eMu1v EA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 38u03c08b5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 May 2021 14:54:20 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 235FF10002A; Fri, 28 May 2021 14:54:20 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 186A52291B2; Fri, 28 May 2021 14:54:20 +0200 (CEST) Received: from lmecxl0573.lme.st.com (10.75.127.44) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 28 May 2021 14:54:19 +0200 Subject: Re: [PATCH 07/10] stm32mp: stm32prog: use get_cpu_dev for GetID command To: Patrick Delaunay , CC: Patrick Delaunay , Simon Glass , U-Boot STM32 References: <20210518131213.20343-1-patrick.delaunay@foss.st.com> <20210518151206.7.I874b9d67ab66c4a1b44c880721f697effa226c5b@changeid> From: Patrice CHOTARD Message-ID: Date: Fri, 28 May 2021 14:54:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210518151206.7.I874b9d67ab66c4a1b44c880721f697effa226c5b@changeid> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-28_04:2021-05-27, 2021-05-28 signatures=0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Hi Patrick On 5/18/21 3:12 PM, Patrick Delaunay wrote: > Use get_cpu_dev() in uart getID command and remove the defines > DEVICE_ID_BYTE1 and 2 defines. > > This patch prepare the support for new SOC family. > > Signed-off-by: Patrick Delaunay > --- > > arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog_serial.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog_serial.c b/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog_serial.c > index 2550ae6a2b..7de62668fe 100644 > --- a/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog_serial.c > +++ b/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog_serial.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -19,8 +20,7 @@ > /* - configuration part -----------------------------*/ > #define USART_BL_VERSION 0x40 /* USART bootloader version V4.0*/ > #define UBOOT_BL_VERSION 0x03 /* bootloader version V0.3*/ > -#define DEVICE_ID_BYTE1 0x05 /* MSB byte of device ID*/ > -#define DEVICE_ID_BYTE2 0x00 /* LSB byte of device ID*/ > + > #define USART_RAM_BUFFER_SIZE 256 /* Size of USART_RAM_Buf buffer*/ > > /* - Commands -----------------------------*/ > @@ -436,10 +436,12 @@ static void get_version_command(struct stm32prog_data *data) > */ > static void get_id_command(struct stm32prog_data *data) > { > + u32 cpu = get_cpu_dev(); > + > /* Send Device IDCode */ > stm32prog_serial_putc(0x1); > - stm32prog_serial_putc(DEVICE_ID_BYTE1); > - stm32prog_serial_putc(DEVICE_ID_BYTE2); > + stm32prog_serial_putc((cpu >> 8) & 0xFF); > + stm32prog_serial_putc(cpu & 0xFF); > stm32prog_serial_result(ACK_BYTE); > } > > Reviewed-by: Patrice Chotard Thanks Patrice