From: Patrick DELAUNAY Date: Fri, 17 Jan 2020 15:19:01 +0000 Subject: [PATCH 3/5] ARM: stm32: Fill in missing loadaddr In-Reply-To: <0cac484a-89b0-2a2e-bfb9-0d50729817ad@denx.de> References: <20200110002839.97868-1-marex@denx.de> <20200110002839.97868-3-marex@denx.de> <843278e2052247248b3f68b8229bd4f7@SFHDAG6NODE3.st.com> <0cac484a-89b0-2a2e-bfb9-0d50729817ad@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, > From: Marek Vasut > Sent: mercredi 15 janvier 2020 10:51 > > On 1/13/20 10:06 AM, Patrick DELAUNAY wrote: > > Hi Marek, > > > >> From: Marek Vasut > >> Sent: vendredi 10 janvier 2020 01:29 > >> > >> Since CONFIG_LOADADDR is not set, the default value of $loadaddr > >> variable is not set in the environment either. Set the default load > >> address to 256 MiB from the start of DRAM. > >> > >> Signed-off-by: Marek Vasut > >> Cc: Patrick Delaunay > >> Cc: Patrice Chotard > >> --- > >> include/configs/stm32mp1.h | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/include/configs/stm32mp1.h b/include/configs/stm32mp1.h > >> index > >> 655833428e..b23dd38794 100644 > >> --- a/include/configs/stm32mp1.h > >> +++ b/include/configs/stm32mp1.h > >> @@ -36,6 +36,7 @@ > >> * Needed by "loadb" > >> */ > >> #define CONFIG_SYS_LOAD_ADDR > STM32_DDR_BASE > >> +#define CONFIG_LOADADDR 0xd0000000 > > > > A offset a 256 MiB is really huge... > > And I don't sure that will fit all the commands (bootm with zImage as > > it is xpecting to be placed in the first 128 MiB of RAM) and all the > > products (with lower memory) > > > > I propose to have the same value for the 2 defines which define the > > default loadaddr with 32MB offset (same value that kernel_addr_r). > > That's OK. I take the patch with thte proposed offset = 32MB. /* - * Needed by "loadb" + * default load address used for command tftp, bootm , loadb, ... */ -#define CONFIG_SYS_LOAD_ADDR STM32_DDR_BASE +#define CONFIG_LOADADDR 0xc2000000 +#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR Applied to u-boot-stm32/master, thanks! Regards Patrick