Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DEC0FA3742 for ; Mon, 31 Oct 2022 12:56:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 489C684F79; Mon, 31 Oct 2022 13:56:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="N0u358VX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CD4A084FAC; Mon, 31 Oct 2022 13:56:11 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0511D84F75 for ; Mon, 31 Oct 2022 13:56:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rogerq@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 29507611F5; Mon, 31 Oct 2022 12:56:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3F44C433C1; Mon, 31 Oct 2022 12:56:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667220966; bh=yVrQSnEAiHk9t+XQEcqhGkSdkWFXK6w+DqLaGZN/87s=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=N0u358VXfsXwAdq4sAYgBkEY8YDRwzit9cTw1keI/4fdWKN/KVeJ/FpFZmTqNtUrP 6TBXWX8C0Hl7pMS7dr2CPSCpDmsbxCrFkFWAeTkfP8SpGegRy2vZrsIbkod8Nro0Xq 7UV0nRIAforQMn36iyl6PfTImDQqoBMgDG3gfYe6pjWgeIstcpSPXPgxdVv1aUmbO0 /j1ufLB4/uOMIT3cprjkPFmNprNktIGDrFjFRUPhj3Kcns/S/srkEmt8oNkXnlDb06 lfJVft06Ds7P0Nb6lMTHF36iwsXcLhJLJmaWorzf4YUXhuMgmzVQ1oBwMWUdJS3O1S uZVUawgi/3wGA== Message-ID: Date: Mon, 31 Oct 2022 14:56:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: Binman entry 'u-boot-any' not found in list Content-Language: en-US To: Neha Malcom Francis , Simon Glass , Fabio Estevam Cc: alpernebiyasak@gmail.com, Oliver Graute , u-boot@lists.denx.de, Vignesh Raghavendra References: <62e5028f-d02b-9346-c87f-832e81db81d2@ti.com> From: Roger Quadros In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Neha, On 31/10/2022 05:40, Neha Malcom Francis wrote: > Hi Simon, > > On 30/10/22 07:13, Simon Glass wrote: >> Hi Neha, >> >> On Fri, 28 Oct 2022 at 04:58, Fabio Estevam wrote: >>> >>> [Adding Alper - binmam maintainer and Oliver, who faced the same issue on imx8] >>> >>> On Fri, Oct 28, 2022 at 7:56 AM Neha Malcom Francis wrote: >>>> >>>> Hi! >>>> >>>> U-Boot build for J721E with binman enabled on the latest tip of the >>>> master branch throws an error when I try to use u-boot-spl-nodtb entry >>>> in my dtsi. >>>> >>>> What I'm trying to do is, to show I've made a small example >>>> (https://github.com/nehamalcom/u-boot/commit/f53dc83944f7774008afbb24fff42904862e9efe) >>>> that is: >>>> >>>> &binman { >>>>          foo { >>>>                  filename = "foo.bin"; >>>>                  u-boot-spl-nodtb { >>>>                  }; >>>>          }; >>>> }; >>>> >>>> which throws the error >>>> (https://gist.github.com/nehamalcom/4d855db7e4d5bd03aa29099b0e915e53): >>>> >>>> binman: Section '/binman/foo': Symbol '_binman_u_boot_any_prop_image_pos' >>>>      in entry '/binman/foo/u-boot-spl-nodtb': Entry 'u-boot-any' not >>>> found in list (u-boot-spl-nodtb,main-section) >>>> >>>> >>>> This can be traced to the WriteSymbols() in etype/u_boot_spl_nodtb.py. >>>> On commenting out this function since it's not necessary in our >>>> use-case, the build was successful >>>> (https://github.com/nehamalcom/u-boot/commit/5666721860e1d2f759440a00c4aee8b6e89b54b3) >>>> >>>> Why is binman not picking up on the "any" and choosing u-boot-spl-nodtb >>>> from the list? >> >> You might need this patch? >> >> https://patchwork.ozlabs.org/project/uboot/patch/20221021002320.1169603-5-sjg@chromium.org/ > > Even after applying this patch, the entry is not working for me. Probably because that patch doesn't deal with CONFIG_SPL case, only CONFIG_TPL and CONFIG_VPL? Can you please try to do the same for CONFIG_SPL? e.g. #ifdef CONFIG_SPL binman_sym_declare(ulong, u_boot_spl, image_pos); binman_sym_declare(ulong, u_boot_spl, size); #endif cheers, -roger