Return-Path: Received: from foss.arm.com ([217.140.110.172]:38208 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727667AbfICOeq (ORCPT ); Tue, 3 Sep 2019 10:34:46 -0400 Subject: Re: [PATCH v2 1/8] arm64: compat: vdso: Expose BUILD_VDSO32 From: Vincenzo Frascino References: <20190830135902.20861-1-vincenzo.frascino@arm.com> <20190830135902.20861-2-vincenzo.frascino@arm.com> Message-ID: Date: Tue, 3 Sep 2019 15:36:16 +0100 MIME-Version: 1.0 In-Reply-To: <20190830135902.20861-2-vincenzo.frascino@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: catalin.marinas@arm.com, 0x7f454c46@gmail.com, salyzyn@android.com, paul.burton@mips.com, luto@kernel.org, tglx@linutronix.de, will@kernel.org Message-ID: <20190903143616.Y7CuM2A80lQUv07IzJQnKwNZXwr7pP0WHnNkoL0lAVU@z> Hi Catalin and Will, On 8/30/19 2:58 PM, Vincenzo Frascino wrote: > clock_gettime32 and clock_getres_time32 should be compiled only with the > 32 bit vdso library. > > Expose BUILD_VDSO32 when arm64 compat is compiled, to provide an > indication to the generic library to include these symbols. > > Cc: Catalin Marinas > Cc: Will Deacon > Signed-off-by: Vincenzo Frascino > Acked-by: Catalin Marinas > --- > arch/arm64/include/asm/vdso/compat_gettimeofday.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/include/asm/vdso/compat_gettimeofday.h b/arch/arm64/include/asm/vdso/compat_gettimeofday.h > index c50ee1b7d5cd..fe7afe0f1a3d 100644 > --- a/arch/arm64/include/asm/vdso/compat_gettimeofday.h > +++ b/arch/arm64/include/asm/vdso/compat_gettimeofday.h > @@ -17,6 +17,7 @@ > #define VDSO_HAS_CLOCK_GETRES 1 > > #define VDSO_HAS_32BIT_FALLBACK 1 > +#define BUILD_VDSO32 1 > > static __always_inline > int gettimeofday_fallback(struct __kernel_old_timeval *_tv, > This patch is independent from the rest and touches only arch code. Can it go in via the arm64 tree? -- Regards, Vincenzo