Message-ID: <c0bc969f-d2d3-4d48-bc6d-00dd299bd7be@intel.com>
Date: Wed, 4 Jun 2025 15:36:25 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [ANN] pylint and shellcheck
To: Simon Horman <horms@kernel.org>, Jakub Kicinski <kuba@kernel.org>
CC: <netdev@vger.kernel.org>
References: <20250603120639.3587f469@kernel.org>
 <20250604072740.GB1675772@horms.kernel.org>
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Content-Language: en-US
In-Reply-To: <20250604072740.GB1675772@horms.kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWRTL1NuVG9BSm9tQUhNSnMwNjhDNHhUN0lzcTU3QlpqQzdNcTJwTlk1dVVB?=
 =?utf-8?B?eFl2ckVPdjBqRitaSGw1MUsrQkdjd2NXNWFHdDJGWFJNcGJraTBHeWY3SXZN?=
 =?utf-8?B?VlE3SGlSUGxiRDJ3WGVxSElGSnR4aDY0MnpJN2xFQ2t5L3lvaXhjSkV0Qjlo?=
 =?utf-8?B?K1cwTGhldUhFSUhTbS9JMXhXamkxQURRalp0QXA4YzF2dDdyT2ZIZkdSbUhH?=
 =?utf-8?B?dzVSaUpLVUtGVVd6dDRnZG9uelBhQm5YNHVqdDhXU1hxT2R2QkxlL3dPU0Jv?=
 =?utf-8?B?VUJRL292ay9oQjRRTFByT3RHZ09QTXJqVklURGtEeGxWNzUrd0R3TzNNZUpy?=
 =?utf-8?B?YnZrdDR1eC9ad0JiV1hMcjNPV1FFWEoxc0NyQWh4MWM0djVDOEwrTE03b1Rx?=
 =?utf-8?B?S3B3VDJGS0VRYUhYQUZVNlNSRnFibGY5MkJ1RkM0c1RNcTRtSnBVWGlBVnF6?=
 =?utf-8?B?RC8rQytOVXRwbWJwZmNPUHNIREF0UkdvS0ZYQmhOTVVDU0REVUZQOWtJZnMx?=
 =?utf-8?B?MExJQ2tTcjFvemZuYUg5T0pwNVJPNHdpcVlYUmE5bTIxQm5HRWhBVFYyYWZP?=
 =?utf-8?B?Nm5URDNaQWxaTU9ReU11UEw1RmN2VFdzZXZJdVRXOHEyZmV6ZTVwT0FmNHNP?=
 =?utf-8?B?M01VTHZDYjBjL3N6NVZWSkNDSXhPT0hBQklrVkppN1U1aFNQZm5tcXNKSjNN?=
 =?utf-8?B?SUl3Und1ZEFzRldkZzBMSkFtdDlwYUMxRDFqeVFQNzlaMHBHNWpEMUl4R0RN?=
 =?utf-8?B?cmdjWUlpR2ErQXhSNW9wa0xkTDNYQ3ZraGZENC9BdmJ1N0xONUhMaGkyZFNw?=
 =?utf-8?B?WUY1Zkx6NnRiZitSbDQ3azAxR1BhOHJ2bElsRmlWV0swUWllYnduUUVYUGNp?=
 =?utf-8?B?cWppeGpLY2FaRm45RSs0V29LT2VXRFFMNzRUYTZIKzUxMVNxajNPdjJpdCs5?=
 =?utf-8?B?eWs0SEw2WkZJS0h1N2FWN2hMWm1iMnNPaVdwUjQ2OHJ4QjJaWUFRbXZVL1JN?=
 =?utf-8?B?eGV6cGNFWWJjK3FLbjExdjVIQVNOTXgrNGpTUHA3SXZ1S3kwdVJLb05NWGR5?=
 =?utf-8?B?U2dXU0toazRPcU1jZ3cvQ2wzZENid3EzTDJEQlpRSlhCbDZaSUpLeGcvaElL?=
 =?utf-8?B?WUpsamgxanBmOEJOa0lIaWl5eUJlaU1mbGkvOUFjc3RhWUxhOGV0YktoMGlF?=
 =?utf-8?B?bStXVnpmTFlUOWZQSHhIaHlwNVFHV25sbVc1UWs5cFo5TkVrTUk3VVhUOGdZ?=
 =?utf-8?B?MXJha0FOMGFXNjFPRkQ3a3dXQjZuWkkwYkNCVnUrc2pGSTlaNW1PcFlFTlRj?=
 =?utf-8?B?M2JTV09KZlptOVdRaXhOQm5zM0U2OVc3bmM5OGl2YjQ1U3lUR04vcU9TWFpp?=
 =?utf-8?B?OVVidi9mcC8yK3g0a0RPaGhnUnV1bkxDM3N3bGhJb055TFFHMkUyWTRVK3l2?=
 =?utf-8?B?UHM0WktuTUw5cVUyTGViZ2E4a05Ydit5S002N0M2WUx5NlRjczcycHRxNWpE?=
 =?utf-8?B?dmwrbWZBcTFvU0o0YjZ5ZEU4UU9XM2g2anNyWjJ3MmhqWlJTZ0hQOFNIUFdh?=
 =?utf-8?B?ZCtyc3FqQkJKMW5YMzRwU1ByMm82R2J0UlZCb1lkMVV0Qk5qYXV5V1hrQXho?=
 =?utf-8?B?SC8vRzJmZTQvWE5od1BVTTM5ZU1LTDVQWEloN1JWNEJYcHNaMnY1NWowMDNQ?=
 =?utf-8?B?aU8yVGhqQmY5YlBseVU3c1F2ZHRBZTF6VTdqcFFaM0dPWGdOKzhzbmtTYXdI?=
 =?utf-8?B?bzFHS3NvKzM1T0V0VWhOcFp2WG83K1d5OFM3Y1dEMmhYY0J5VUx3U1NraE9E?=
 =?utf-8?B?alc5d0tXVmhxQVN5R1AvVFp1ODE0cFFVNlZlSE1NRUtyRjd2WXNnZHNyZFYz?=
 =?utf-8?B?VHJUbEFUcW9VSXFxRVZUZUc4TG1pbEE2ZzkvWDNjYWNWOFJ5emJNTWhIK0tT?=
 =?utf-8?B?QSt1TzBRYXEra2FNdDdyQ1kvUTRKMWZwNXhaL2xWK1huWHdrR29GdjViQ1hp?=
 =?utf-8?B?Ukk3V0M1N1B1dVdyaWJGVlBBM0srWkRPQ0haTE9EbG54bGI5QmpWWG5MOG5n?=
 =?utf-8?B?UUVZdmNrSkFQNVN3d1pyckNyVTlDSjlpTVdWLzBZZTdZSW5rR3Y0M3FLTXV3?=
 =?utf-8?B?ZkxIanU3OC9RQXRiZGdlc3lpTTBtNEl4WXVnUmhIRVNDSGtiVEsrQ2s3Q0xN?=
 =?utf-8?B?Z1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 023ee4cb-b143-4c43-7371-08dda36ccf8a
X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2025 13:36:29.2190
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MRDw7n4TyDqGw7cScBFNF4gSGSetNuatufhtp5h5X25DQkbxdTagEp3e6JqULbtlI84f2iZqBd3V+LCt2N43glV8VzYF5l0+pxj69lh4jao=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPF1FCD3EAF0
X-OriginatorOrg: intel.com

On 6/4/25 09:27, Simon Horman wrote:
> On Tue, Jun 03, 2025 at 12:06:39PM -0700, Jakub Kicinski wrote:
>> Hi!
>>
>> It's merge window time so I have a bit of time to catch up on random
>> things. I added shellcheck, yamllint and pylint:
>> https://github.com/linux-netdev/nipa/commit/c0fe53ae533d19c19d2e00955403fb57c3679084
>> https://github.com/linux-netdev/nipa/commit/255ee0295a096ee7096bebd9d640388acc590da0
>> https://github.com/linux-netdev/nipa/commit/54e060c9094e33bffe356b5d3e25853e22235d49
>> to the netdev patchwork checks.
>>
>> They will likely be pretty noisy so please take them with a grain of
>> salt (pretty much like checkpatch). Using the NIPA scripts from the
>> commits above could be useful to find the delta of new warnings, since
>> there will be quite a few existing ones.
>>
>> I suspect as we get more experience we will find the warning types to
>> disable, and we will drive the number of existing errors down to make
>> checking for new ones less of a pain. As I said, for now please don't
>> take these checks failing at face value.
> 
> Thanks Jakub,
> 
> I agree this is a good step.
> 
> Anecdotally, my feeling from running shellcheck over patches for a little
> while now is that the feedback it gives mainly relates to stricter coding
> practices which aren't generally followed. And yet the scripts seem to run
> reliably in the environments they are intended to run in.
> 
> So I'll be interested to see if we end up go for some mix of disabling
> warnings and updating (creating!) our preferred coding style for shell
> scripts.
> 
> </2c>
> 

other than quoting rules (shellcheck knows/assumes less than a human
could) I find all other shellcheck warnings to be a good thing to avoid
in all codebases (mixed level of bash familiarity of participants)