Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEFFCC25B79 for ; Fri, 24 May 2024 07:25:18 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.729116.1134251 (Exim 4.92) (envelope-from ) id 1sAPIa-000071-Kz; Fri, 24 May 2024 07:25:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 729116.1134251; Fri, 24 May 2024 07:25:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sAPIa-00006u-Hd; Fri, 24 May 2024 07:25:08 +0000 Received: by outflank-mailman (input) for mailman id 729116; Fri, 24 May 2024 07:25:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sAPIZ-00006o-AF for xen-devel@lists.xenproject.org; Fri, 24 May 2024 07:25:07 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be5a7a0f-199e-11ef-90a1-e314d9c70b13; Fri, 24 May 2024 09:25:06 +0200 (CEST) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a621cb07d8fso372331266b.2 for ; Fri, 24 May 2024 00:25:06 -0700 (PDT) Received: from [192.168.219.221] ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a626cda48e6sm83299966b.203.2024.05.24.00.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 May 2024 00:25:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be5a7a0f-199e-11ef-90a1-e314d9c70b13 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716535506; x=1717140306; darn=lists.xenproject.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=BCcRSzFZVY8kb90HA4XASBL0rwstT/aWeoSawvquxcg=; b=nd/3/EaBmE0B8SoWBJ4evHNR1ZwEJo+VZ1fCR74H2/fowUnnDca2L+rJL9pPg6G4us JnddakAfUoCPbqKLvzppxrgVnoYKnI74r46O18Zfa9yy7f7vzEZZttCI0jnEtF3aIBnD x9nsZ+uWjMmEPFLprk6GnNTcDXTuaXvSS+rguLQcx4SiDGFKoKvUkTVh3QN3hpFygGeN AdokYWVT/ZLRgJemONRtFBOoEBfax++bxwruVpGNmHXLZOchErBi03eigubUiDYDc9kY GFExXZsPPlRt9cYVF6qx62Iy3xd0TkN+fWGtWyKcy5V9Lz3qGL2h0/6vCtgYHMSJrqqw 3vCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716535506; x=1717140306; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BCcRSzFZVY8kb90HA4XASBL0rwstT/aWeoSawvquxcg=; b=NA8lM9FistrNvI0gg8LJelfTJvlGlJFMezQicmiZNl876DaqzPoNMmwv46mYrQVBAN l+30N59/TcR8vYV+duqini0UsjZhW+Pqk3wMVk3LDkgIFSNtRYPyDe1ZRxqcZ+lBqy2w +LfqKP4J0GCrAtoxk4IYL89ejRgk4OWLO9fmsnsRaFpHrIaP5Cg6/BCOv2mAy98zSIKp acVijquGNIh+ySK83yEVrq85Vg8HA65VVL6Oz/M/MVRbF8WOAUIDTeyp10GGzsw0MqMo LjamrndqEj60VIy9kWtCoHyqdtFMBQ3UG3HtjvK0eWxRhhcHH9qGkr4976oHY0mIx6Zy XW8Q== X-Forwarded-Encrypted: i=1; AJvYcCW/9Sep1TyaZjyrbl9Dp2RTChzOUoXgYf8j/Ia8rxdvuXG1hnJzT4Va4cFj6XBU1/All47ZwwBKbw+RIlPCFWIyGu4Qfx0M3mAG9rYwkhA= X-Gm-Message-State: AOJu0Yxhx4KN7Jk6pMLkl1a0JZhmxnOKCJgWgu5ckvgtY+1EUmt5XYgd GRPjZbt1IeqIczUJ/XBqEbKSwziel3OQHAIlYhWL5++CpRADxZbS X-Google-Smtp-Source: AGHT+IGEuLDZavc2AIrUowkQrU9JJVHgyGwRxyWxMjmJHQO5cPlBWFvUqg+GyeEdqhQRXSxjuzXzHQ== X-Received: by 2002:a17:906:91d1:b0:a5a:8a63:9fee with SMTP id a640c23a62f3a-a626407b93amr102098166b.3.1716535505024; Fri, 24 May 2024 00:25:05 -0700 (PDT) Message-ID: Subject: Re: [PATCH v10 02/14] xen: introduce generic non-atomic test_*bit() From: "Oleksii K." To: Jan Beulich , Julien Grall Cc: Roger Pau =?ISO-8859-1?Q?Monn=E9?= , Ross Lagerwall , Stefano Stabellini , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Shawn Anastasio , xen-devel@lists.xenproject.org Date: Fri, 24 May 2024 09:25:03 +0200 In-Reply-To: References: <219df9d840a183fc55de02aff011c0972a68587c.1715952103.git.oleksii.kurochko@gmail.com> <1554d534-7998-4ad4-9218-579b2568b744@xen.org> <9f02d973c2520d36ee33d01b871378de16ede4d0.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.1 (3.52.1-1.fc40) MIME-Version: 1.0 On Fri, 2024-05-24 at 08:48 +0200, Jan Beulich wrote: > On 23.05.2024 18:40, Oleksii K. wrote: > > On Thu, 2024-05-23 at 15:33 +0100, Julien Grall wrote: > > > On 23/05/2024 15:11, Oleksii K. wrote: > > > > On Thu, 2024-05-23 at 14:00 +0100, Julien Grall wrote: > > > > > On 17/05/2024 14:54, Oleksii Kurochko wrote: > > > > > > diff --git a/xen/arch/arm/arm64/livepatch.c > > > > > > b/xen/arch/arm/arm64/livepatch.c > > > > > > index df2cebedde..4bc8ed9be5 100644 > > > > > > --- a/xen/arch/arm/arm64/livepatch.c > > > > > > +++ b/xen/arch/arm/arm64/livepatch.c > > > > > > @@ -10,7 +10,6 @@ > > > > > > =C2=A0=C2=A0 #include > > > > > > =C2=A0=C2=A0 #include > > > > > > =C2=A0=C2=A0=20 > > > > > > -#include > > > > >=20 > > > > > It is a bit unclear how this change is related to the patch. > > > > > Can > > > > > you > > > > > explain in the commit message? > > > > Probably it doesn't need anymore. I will double check and if > > > > this > > > > change is not needed, I will just drop it in the next patch > > > > version. > > > >=20 > > > > >=20 > > > > > > =C2=A0=C2=A0 #include > > > > > > =C2=A0=C2=A0 #include > > > > > > =C2=A0=C2=A0 #include > > > > > > diff --git a/xen/arch/arm/include/asm/bitops.h > > > > > > b/xen/arch/arm/include/asm/bitops.h > > > > > > index 5104334e48..8e16335e76 100644 > > > > > > --- a/xen/arch/arm/include/asm/bitops.h > > > > > > +++ b/xen/arch/arm/include/asm/bitops.h > > > > > > @@ -22,9 +22,6 @@ > > > > > > =C2=A0=C2=A0 #define __set_bit(n,p)=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 set_bit(n,p) > > > > > > =C2=A0=C2=A0 #define __clear_bit(n,p)=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 clear_bit(n,p) > > > > > > =C2=A0=C2=A0=20 > > > > > > -#define BITOP_BITS_PER_WORD=C2=A0=C2=A0=C2=A0=C2=A0 32 > > > > > > -#define BITOP_MASK(nr)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 (1UL << ((nr) % > > > > > > BITOP_BITS_PER_WORD)) > > > > > > -#define BITOP_WORD(nr)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 ((nr) / > > > > > > BITOP_BITS_PER_WORD) > > > > > > =C2=A0=C2=A0 #define BITS_PER_BYTE=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 8 > > > > >=20 > > > > > OOI, any reason BITS_PER_BYTE has not been moved as well? I > > > > > don't > > > > > expect > > > > > the value to change across arch. > > > > I can move it to generic one header too in the next patch > > > > version. > > > >=20 > > > > >=20 > > > > > [...] > > > > >=20 > > > > > > diff --git a/xen/include/xen/bitops.h > > > > > > b/xen/include/xen/bitops.h > > > > > > index f14ad0d33a..6eeeff0117 100644 > > > > > > --- a/xen/include/xen/bitops.h > > > > > > +++ b/xen/include/xen/bitops.h > > > > > > @@ -65,10 +65,141 @@ static inline int > > > > > > generic_flsl(unsigned > > > > > > long > > > > > > x) > > > > > > =C2=A0=C2=A0=C2=A0 * scope > > > > > > =C2=A0=C2=A0=C2=A0 */ > > > > > > =C2=A0=C2=A0=20 > > > > > > +#define BITOP_BITS_PER_WORD 32 > > > > > > +typedef uint32_t bitop_uint_t; > > > > > > + > > > > > > +#define BITOP_MASK(nr)=C2=A0 ((bitop_uint_t)1 << ((nr) % > > > > > > BITOP_BITS_PER_WORD)) > > > > > > + > > > > > > +#define BITOP_WORD(nr)=C2=A0 ((nr) / BITOP_BITS_PER_WORD) > > > > > > + > > > > > > +extern void __bitop_bad_size(void); > > > > > > + > > > > > > +#define bitop_bad_size(addr) (sizeof(*(addr)) < > > > > > > sizeof(bitop_uint_t)) > > > > > > + > > > > > > =C2=A0=C2=A0 /* --------------------- Please tidy above here --= ------ > > > > > > ---- > > > > > > ----- > > > > > > ---- */ > > > > > > =C2=A0=C2=A0=20 > > > > > > =C2=A0=C2=A0 #include > > > > > > =C2=A0=C2=A0=20 > > > > > > +/** > > > > > > + * generic__test_and_set_bit - Set a bit and return its > > > > > > old > > > > > > value > > > > > > + * @nr: Bit to set > > > > > > + * @addr: Address to count from > > > > > > + * > > > > > > + * This operation is non-atomic and can be reordered. > > > > > > + * If two examples of this operation race, one can appear > > > > > > to > > > > > > succeed > > > > > > + * but actually fail.=C2=A0 You must protect multiple accesses > > > > > > with > > > > > > a > > > > > > lock. > > > > > > + */ > > > > >=20 > > > > > Sorry for only mentioning this on v10. I think this comment > > > > > should be > > > > > duplicated (or moved to) on top of test_bit() because this is > > > > > what > > > > > everyone will use. This will avoid the developper to follow > > > > > the > > > > > function > > > > > calls and only notice the x86 version which says "This > > > > > function > > > > > is > > > > > atomic and may not be reordered." and would be wrong for all > > > > > the > > > > > other arch. > > > > It makes sense to add this comment on top of test_bit(), but I > > > > am > > > > curious if it is needed to mention that for x86 arch_test_bit() > > > > "is > > > > atomic and may not be reordered": > > >=20 > > > I would say no because any developper modifying common code can't > > > relying it. > > >=20 > > > >=20 > > > > =C2=A0 * This operation is non-atomic and can be reordered. ( > > > > Exception: > > > > for > > > > * x86 arch_test_bit() is atomic and may not be reordered ) > > > > =C2=A0 * If two examples of this operation race, one can appear to > > > > succeed > > > > =C2=A0 * but actually fail.=C2=A0 You must protect multiple accesse= s with > > > > a > > > > lock. > > > > =C2=A0 */ > > > >=20 > > > > >=20 > > > > > > +static always_inline bool > > > > > > +generic__test_and_set_bit(int nr, volatile void *addr) > > > > > > +{ > > > > > > +=C2=A0=C2=A0=C2=A0 bitop_uint_t mask =3D BITOP_MASK(nr); > > > > > > +=C2=A0=C2=A0=C2=A0 volatile bitop_uint_t *p =3D (volatile bito= p_uint_t > > > > > > *)addr + > > > > > > BITOP_WORD(nr); > > > > > > +=C2=A0=C2=A0=C2=A0 bitop_uint_t old =3D *p; > > > > > > + > > > > > > +=C2=A0=C2=A0=C2=A0 *p =3D old | mask; > > > > > > +=C2=A0=C2=A0=C2=A0 return (old & mask); > > > > > > +} > > > > > > + > > > > > > +/** > > > > > > + * generic__test_and_clear_bit - Clear a bit and return > > > > > > its > > > > > > old > > > > > > value > > > > > > + * @nr: Bit to clear > > > > > > + * @addr: Address to count from > > > > > > + * > > > > > > + * This operation is non-atomic and can be reordered. > > > > > > + * If two examples of this operation race, one can appear > > > > > > to > > > > > > succeed > > > > > > + * but actually fail.=C2=A0 You must protect multiple accesses > > > > > > with > > > > > > a > > > > > > lock. > > > > > > + */ > > > > >=20 > > > > > Same applies here and ... > > > > >=20 > > > > > > +static always_inline bool > > > > > > +generic__test_and_clear_bit(int nr, volatile void *addr) > > > > > > +{ > > > > > > +=C2=A0=C2=A0=C2=A0 bitop_uint_t mask =3D BITOP_MASK(nr); > > > > > > +=C2=A0=C2=A0=C2=A0 volatile bitop_uint_t *p =3D (volatile bito= p_uint_t > > > > > > *)addr + > > > > > > BITOP_WORD(nr); > > > > > > +=C2=A0=C2=A0=C2=A0 bitop_uint_t old =3D *p; > > > > > > + > > > > > > +=C2=A0=C2=A0=C2=A0 *p =3D old & ~mask; > > > > > > +=C2=A0=C2=A0=C2=A0 return (old & mask); > > > > > > +} > > > > > > + > > > > > > +/* WARNING: non atomic and it can be reordered! */ > > > > >=20 > > > > > ... here. > > > > >=20 > > > > > > +static always_inline bool > > > > > > +generic__test_and_change_bit(int nr, volatile void *addr) > > > > > > +{ > > > > > > +=C2=A0=C2=A0=C2=A0 bitop_uint_t mask =3D BITOP_MASK(nr); > > > > > > +=C2=A0=C2=A0=C2=A0 volatile bitop_uint_t *p =3D (volatile bito= p_uint_t > > > > > > *)addr + > > > > > > BITOP_WORD(nr); > > > > > > +=C2=A0=C2=A0=C2=A0 bitop_uint_t old =3D *p; > > > > > > + > > > > > > +=C2=A0=C2=A0=C2=A0 *p =3D old ^ mask; > > > > > > +=C2=A0=C2=A0=C2=A0 return (old & mask); > > > > > > +} > > > > > > +/** > > > > > > + * generic_test_bit - Determine whether a bit is set > > > > > > + * @nr: bit number to test > > > > > > + * @addr: Address to start counting from > > > > > > + */ > > > > > > +static always_inline bool generic_test_bit(int nr, const > > > > > > volatile > > > > > > void *addr) > > > > > > +{ > > > > > > +=C2=A0=C2=A0=C2=A0 bitop_uint_t mask =3D BITOP_MASK(nr); > > > > > > +=C2=A0=C2=A0=C2=A0 const volatile bitop_uint_t *p =3D > > > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 (const volatile bitop_uint_t > > > > > > *)addr + > > > > > > BITOP_WORD(nr); > > > > > > + > > > > > > +=C2=A0=C2=A0=C2=A0 return (*p & mask); > > > > > > +} > > > > > > + > > > > > > +static always_inline bool > > > > > > +__test_and_set_bit(int nr, volatile void *addr) > > > > > > +{ > > > > > > +#ifndef arch__test_and_set_bit > > > > > > +#define arch__test_and_set_bit generic__test_and_set_bit > > > > > > +#endif > > > > > > + > > > > > > +=C2=A0=C2=A0=C2=A0 return arch__test_and_set_bit(nr, addr); > > > > > > +} > > > > >=20 > > > > > NIT: It is a bit too late to change this one. But I have to > > > > > admit, I > > > > > don't understand the purpose of the static inline when you > > > > > could > > > > > have > > > > > simply call... > > > > >=20 > > > > > > +#define __test_and_set_bit(nr, addr) ({=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ > > > > > > +=C2=A0=C2=A0=C2=A0 if ( bitop_bad_size(addr) ) __bitop_bad_siz= e(); \ > > > > > > +=C2=A0=C2=A0=C2=A0 __test_and_set_bit(nr, addr);=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 \ > > > > >=20 > > > > > ... __arch__test_and_set_bit here. > > > > I just wanted to be in sync with other non-atomic test*_bit() > > > > operations and Andrew's patch series ( xen/bitops: Reduce the > > > > mess, > > > > starting with ffs() ). > > >=20 > > > I looked at Andrew series and I can't seem to find an example > > > where > > > he=20 > > > uses both the macro + static inline. He seems only use a static > > > inline. > > > Do you have any pointer? > > >=20 > > > But by any chance are you referring to the pattern on x86? If so, > > > I=20 > > > would really like to understand what's the benefits of > > > introducing a > > > a=20 > > > one-liner static inline which is "shadowed" by a macro... > > Yes, I was referring to the x86 pattern. > >=20 > > I tried to find the reason in the commit but couldn't: > > https://lists.xenproject.org/archives/html/xen-changelog/2008-03/msg000= 97.html > >=20 > > For some reason, I also couldn't find the mailing list thread for > > this. > >=20 > > Perhaps Jan could help here, based on the commit message he might > > have > > a suggestion. >=20 > There's a lot of apparently unrelated context left, so I'm trying to > guess > on what the actual question is, from the old change you're pointing > at: With >=20 > #define __test_and_set_bit(nr, addr) ({=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ > =C2=A0=C2=A0 if ( bitop_bad_size(addr) ) __bitop_bad_size(); \ > =C2=A0=C2=A0 __test_and_set_bit(nr, addr);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 \ >=20 > why do we have that wrapping macro? If that's indeed the question, > then may > I suggest you consider what would happen to the sizeof() in > bitop_bad_size() > if the invocation was moved to the inline function, taking pointer- > to-void? >=20 > However, I can't relate that old change to the question I think > Julien > raised (invoking __test_and_set_bit() vs arch__test_and_set_bit()), > so > perhaps I'm missing something. If I understand the question correctly then the question is why do we need static inline function. Can't we just do the following: #ifndef arch_test_bit #define arch_test_bit generic_test_bit #endif #define test_bit(nr, addr) ({ \ if ( bitop_bad_size(addr) ) __bitop_bad_size(); \ arch_test_bit(nr, addr); \ }) ~ Oleksii