From: "stipa (Code Review)" Date: Wed, 17 Jan 2024 09:23:58 +0000 In-Reply-To: References: Reply-To: lstipakov@...277..., arne-openvpn@...1227..., heiko@...515..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="ydrEB34s4YQ="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: cmake: symlink whole build dir not just .json file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: d12fk Cc: plaisthos , flichtenheld , openvpn-devel --ydrEB34s4YQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/501?usp=3Demail ) Change subject: cmake: symlink whole build dir not just .json file ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I have built and tested Windows part, so someone may want to look at autoto= ols. Looks good: - by default, nothing has changed - when ENABLE_COMPILE_COMMANDS is set and VS is running under Administrat= or, "build" symlink is created - when ENABLE_COMPILE_COMMANDS is set and VS is not running under Adminis= trator, build fails as expected because Windows doesn't allow to create sym= links for normal users -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/501?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib1a5c788269949d8de95d1da2cb0c32a65bf13f2 Gerrit-Change-Number: 501 Gerrit-PatchSet: 1 Gerrit-Owner: d12fk Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: d12fk Gerrit-Comment-Date: Wed, 17 Jan 2024 09:23:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --ydrEB34s4YQ= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: d12fk, flichtenheld, plaisthos. <= /p>

Patch set 1:Code-Review +1=

Vi= ew Change

1 comment:

  • Patchset:

    • Patch Set #1:

      I have built and tested Windows part, so someo= ne may want to look at autotools.

      Looks good:

      - by default, nothi= ng has changed
      - when ENABLE_COMPILE_COMMANDS is set and VS is running= under Administrator, "build" symlink is created
      - when ENAB= LE_COMPILE_COMMANDS is set and VS is not running under Administrator, build= fails as expected because Windows doesn't allow to create symlinks for= normal users

To view, visit change 501. To unsubscr= ibe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib1a5c788269949d8de95d1da2cb= 0c32a65bf13f2
Gerrit-Change-Number: 501
Gerrit-PatchSet: 1
Gerrit-Owner: d12fk <heiko@...515...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-Reviewer: stipa <lstipakov@...277...= >
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: d12fk <heiko@...515...>= ;
Gerrit-Comment-Date: Wed, 17 Jan 2024 09:23:58= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--ydrEB34s4YQ=--