Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 259E3C433DB for ; Thu, 14 Jan 2021 10:32:30 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE41523A40 for ; Thu, 14 Jan 2021 10:32:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE41523A40 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 72D651676; Thu, 14 Jan 2021 11:31:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 72D651676 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1610620346; bh=WT6qMTMukSBB3ktGuONKvrc352mBhY6UYWb3osGGVEc=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=W9WYEFjUYiFf2ed7kMwY1vQCA5dG0LLJ5XFYbU9U3nsyYPfKPeGVYsj4PBhGXu14b KH0chAcKv5R4QaT9bpZz+ZaOVV97Q1y0mR7W8PABYnrbIh1LwPU0mLpOKkwYa+K2YP 0+lFtefSx2hzJz+Ce3pfOZnebpJWXstjyGs5CA5M= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id ECE5BF80134; Thu, 14 Jan 2021 11:31:35 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D28D4F8025E; Thu, 14 Jan 2021 11:31:22 +0100 (CET) Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C0863F80118 for ; Thu, 14 Jan 2021 11:31:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C0863F80118 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="GoeswMA8" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 10EAR9QX031652; Thu, 14 Jan 2021 04:31:12 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=PODMain02222019; bh=7EbSzPs1PWHZQ4mjZAxZUcYIFc5DWtSabTvzQh1Wk1E=; b=GoeswMA8NIb9lEwq4mTPP6NCghn5BJKb2bPQ1C8Dgu0itz5MxQWaptmjLeaj+mOkFil4 uZj9RHkiBSENhRZg/6SfOaR5k7QFwNnUaoI6OjNegaq+CjzgOm0idBEIVJibyF0n7vS3 N0D7Nn1Ao1nBwrNKjTc8eeM5M6/CJze+PvYHfEbReBxDJb+Q9CJzx+Xxjv8CxKB6Fo8g jzx0DmZswOv02wKfskVvSii2lbOKl6rFZAUn0nPaNHmZswexL63b6F5KyfAgTY8bhJ2N hra9mmcQpcYDhPWwsnmdJZJ5s6D+nGgfSM0Ie2C5YVHjBD8zI9CnDqHqWd1uNtklgWoZ zg== Received: from ediex01.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 35y9srx4fm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 14 Jan 2021 04:31:12 -0600 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Thu, 14 Jan 2021 10:31:11 +0000 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.1913.5 via Frontend Transport; Thu, 14 Jan 2021 10:31:11 +0000 Received: from [10.0.2.15] (AUSNPC0LSNW1.ad.cirrus.com [198.61.64.57]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id ACE8645; Thu, 14 Jan 2021 10:31:10 +0000 (UTC) Subject: Re: [PATCH v4 2/6] dt-bindings: audio-graph-card: Add plls and sysclks properties To: Rob Herring References: <20210108160501.7638-1-rf@opensource.cirrus.com> <20210108160501.7638-3-rf@opensource.cirrus.com> <20210113152225.GA2334778@robh.at.kernel.org> From: Richard Fitzgerald Message-ID: Date: Thu, 14 Jan 2021 10:31:10 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210113152225.GA2334778@robh.at.kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 priorityscore=1501 phishscore=0 spamscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 mlxlogscore=999 impostorscore=0 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101140059 Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, f.fainelli@gmail.com, kuninori.morimoto.gx@renesas.com, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, broonie@kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, nsaenzjulienne@suse.de X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 13/01/2021 15:22, Rob Herring wrote: > On Fri, Jan 08, 2021 at 04:04:57PM +0000, Richard Fitzgerald wrote: >> The audio-graph-card driver has properties for configuring the clocking >> for DAIs within a component, but is missing properties for setting >> up the PLLs and sysclks of the component. >> >> This patch adds the two new properties 'plls' and 'sysclks' so that the >> audio-graph-driver can fully configure the component clocking. > > I'm not sure this makes sense to be generic, but if so, we already have > the clock binding and should use (and possibly extend) that. > > This appears to all be configuration of clocks within the codec, so > these properties belong in the codec or cpu nodes. > audio-graph-card doesn't have codec or cpu nodes. Those were in simple-card but are replaced in audio-graph-card by a simple phandle array forming a graph. I could assume that all clock settings apply to the codec and that there is only ever one codec in an audio-graph-card configuration. >> Signed-off-by: Richard Fitzgerald >> --- >> .../bindings/sound/audio-graph.yaml | 46 +++++++++++++++++++ >> 1 file changed, 46 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/audio-graph.yaml b/Documentation/devicetree/bindings/sound/audio-graph.yaml >> index 4b46794e5153..9e0819205a17 100644 >> --- a/Documentation/devicetree/bindings/sound/audio-graph.yaml >> +++ b/Documentation/devicetree/bindings/sound/audio-graph.yaml >> @@ -39,6 +39,52 @@ properties: >> mic-det-gpio: >> maxItems: 1 >> >> + plls: >> + description: | >> + A list of component pll settings. There are 4 cells per PLL setting: >> + - phandle to the node of the codec or cpu component, >> + - component PLL id, >> + - component clock source id, >> + - frequency (in Hz) of the PLL output clock. > > assigned-clocks binding can set frequencies and parent clocks. > > 'pll' is too specific to the implementation. You may want to configure > the freq and parent of something that's not a pll. > >> + The PLL id and clock source id are specific to the particular component >> + so see the relevant component driver for the ids. Typically the >> + clock source id indicates the pin the source clock is connected to. >> + The same phandle can appear in multiple entries so that several plls >> + can be set in the same component. >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + >> + plls-clocks: >> + $ref: /schemas/types.yaml#/definitions/non-unique-string-array >> + description: | >> + A list of clock names giving the source clock for each setting >> + in the plls property. >> + >> + sysclks: >> + description: | >> + A list of component sysclk settings. There are 4 cells per sysclk >> + setting: >> + - phandle to the node of the codec or cpu component, >> + - component sysclk id, >> + - component clock source id, >> + - direction of the clock: 0 if the clock is an input to the component, >> + 1 if it is an output. > > A clock provider and consumer would provide the direction. > >> + The sysclk id and clock source id are specific to the particular >> + component so see the relevant component driver for the ids. Typically >> + the clock source id indicates the pin the source clock is connected to. >> + The same phandle can appear in multiple entries so that several sysclks >> + can be set in the same component. >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + >> + sysclks-clocks: >> + $ref: /schemas/types.yaml#/definitions/non-unique-string-array >> + description: | >> + A list of clock names giving the source clock for each setting >> + in the sysclks property. >> + >> +dependencies: >> + plls: [ plls-clocks ] >> + sysclks: [ sysclks-clocks ] >> + >> required: >> - dais >> >> -- >> 2.20.1 >>