Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1181EC433C1 for ; Sat, 20 Mar 2021 16:59:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DEB6361940 for ; Sat, 20 Mar 2021 16:59:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229769AbhCTQ6t (ORCPT ); Sat, 20 Mar 2021 12:58:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbhCTQ6W (ORCPT ); Sat, 20 Mar 2021 12:58:22 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1C8FC061574 for ; Sat, 20 Mar 2021 09:58:21 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id B884F1F45E6C Message-ID: Subject: Re: [PATCH] media: rkvdec: Remove of_match_ptr() From: Ezequiel Garcia To: Fabio Estevam , hverkuil@xs4all.nl Cc: boris.brezillon@collabora.com, linux-media@vger.kernel.org, kernel test robot Date: Sat, 20 Mar 2021 13:58:03 -0300 In-Reply-To: <20210320122152.203446-1-festevam@gmail.com> References: <20210320122152.203446-1-festevam@gmail.com> Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.2-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Sat, 2021-03-20 at 09:21 -0300, Fabio Estevam wrote: > When building with CONFIG_OF not set, the following clang > build warning is seen: > > > > drivers/staging/media/rkvdec/rkvdec.c:967:34: warning: unused variable 'of_rkvdec_match' [-Wunused-const-variable] > > Fix the warning by removing the unnecessary of_match_ptr(). > > Reported-by: kernel test robot > Fixes: cd33c830448b ("media: rkvdec: Add the rkvdec driver") > Signed-off-by: Fabio Estevam > --- >  drivers/staging/media/rkvdec/rkvdec.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c > index 225eeca73356..0ff013c1fc38 100644 > --- a/drivers/staging/media/rkvdec/rkvdec.c > +++ b/drivers/staging/media/rkvdec/rkvdec.c > @@ -1092,7 +1092,7 @@ static struct platform_driver rkvdec_driver = { >         .remove = rkvdec_remove, >         .driver = { >                    .name = "rkvdec", > -                  .of_match_table = of_match_ptr(of_rkvdec_match), > +                  .of_match_table = of_rkvdec_match, >                    .pm = &rkvdec_pm_ops, >         }, >  }; Looks good. Reviewed-by: Ezequiel Garcia Thanks, Ezequiel